| Message ID | 20250108011812.627-2-mjchen0829@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for nuvoton ma35d1 keypad controller | expand |
On Wed, Jan 08, 2025 at 01:18:11AM +0000, Ming-Jen wrote: > From: Ming-jen Chen <mjchen0829@gmail.com> > > Add YAML bindings for MA35D1 SoC keypad. > > Signed-off-by: Ming-jen Chen <mjchen0829@gmail.com> > --- > .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml > new file mode 100644 > index 000000000000..889f253b3bc2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml I don't see changes. I already raised concern that you sent new versions without implementing or responding to comments. So the fourth (!!!) time: Filename matching compatible. Best regards, Krzysztof
Krzysztof Kozlowski 於 2025/1/8 16:13 寫道: > On Wed, Jan 08, 2025 at 01:18:11AM +0000, Ming-Jen wrote: >> From: Ming-jen Chen <mjchen0829@gmail.com> >> >> Add YAML bindings for MA35D1 SoC keypad. >> >> Signed-off-by: Ming-jen Chen <mjchen0829@gmail.com> >> --- >> .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 +++++++++++++++++++ >> 1 file changed, 82 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >> >> diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >> new file mode 100644 >> index 000000000000..889f253b3bc2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml > I don't see changes. > > I already raised concern that you sent new versions without implementing > or responding to comments. So the fourth (!!!) time: Filename matching > compatible. > > Best regards, > Krzysztof Thank you for your feedback! I now understand the changes I need to make. I will modify it as blow: compatible: const: nuvoton,ma35d1-keypad
On 08/01/2025 09:42, Ming-Jen Chen wrote: > > Krzysztof Kozlowski 於 2025/1/8 16:13 寫道: >> On Wed, Jan 08, 2025 at 01:18:11AM +0000, Ming-Jen wrote: >>> From: Ming-jen Chen <mjchen0829@gmail.com> >>> >>> Add YAML bindings for MA35D1 SoC keypad. >>> >>> Signed-off-by: Ming-jen Chen <mjchen0829@gmail.com> >>> --- >>> .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 +++++++++++++++++++ >>> 1 file changed, 82 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >>> new file mode 100644 >>> index 000000000000..889f253b3bc2 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml >> I don't see changes. >> >> I already raised concern that you sent new versions without implementing >> or responding to comments. So the fourth (!!!) time: Filename matching >> compatible. >> >> Best regards, >> Krzysztof > > Thank you for your feedback! I now understand the changes I need to make. > > I will modify it as blow: > > compatible: > const: nuvoton,ma35d1-keypad Or change the filename... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml new file mode 100644 index 000000000000..889f253b3bc2 --- /dev/null +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml @@ -0,0 +1,82 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/nuvoton,ma35d1-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton MA35D1 Keypad + +maintainers: + - Ming-jen Chen <mjchen0829@gmail.com> + +allOf: + - $ref: /schemas/input/matrix-keymap.yaml# + +properties: + compatible: + const: nuvoton,ma35d1-kpi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + linux,keymap: + description: Keymap for the keypad. + + keypad,num-rows: + description: Number of rows in the keypad. + minimum: 2 + maximum: 8 + + keypad,num-columns: + description: Number of columns in the keypad. + minimum: 1 + maximum: 8 + + debounce-delay-ms: + description: Debounce delay time in milliseconds. + maxItems: 1 + + scan-interval-ms: + description: Scan interval time in milliseconds. + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - linux,keymap + - keypad,num-rows + - keypad,num-columns + - debounce-delay-ms + - scan-interval-ms + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/input/input.h> + keypad@404a0000 { + compatible = "nuvoton,ma35d1-kpi"; + reg = <0x404a0000 0x10000>; + interrupts = <79>; + clocks = <&clk>; + keypad,num-rows = <2>; + keypad,num-columns = <2>; + + linux,keymap = < + MATRIX_KEY(0, 0, KEY_ENTER) + MATRIX_KEY(0, 1, KEY_ENTER) + MATRIX_KEY(1, 0, KEY_SPACE) + MATRIX_KEY(1, 1, KEY_Z) + >; + + debounce-delay-ms = <1>; + scan-interval-ms = <20>; + };