From patchwork Wed Jan 8 11:27:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 13930749 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19089E77188 for ; Wed, 8 Jan 2025 12:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XHvuixTwqqh0Qu3289u599wnSAYH94rGURNz8Rbe/mU=; b=noPAcQ0IDwfgcBGrYdlW4eS7le Qovcg1+aJ8WirWuv6dq+GYM3K1FxkW9cUxaP6kqOWhwXgOfQd5g6Bjkqci+nwAUdLXXkUM9DFIjj0 hzlycuBqXD31ByGJAurhSTTOYU5Qi42evnhRWU7jKfCE7q6F3YHgh/xPUA/J7t2CGPEOkh/sD3Qhf 5gZjWFALymxKe6HqXCNEtkjTKSsBR9Slpf5fcGgU8Wvlb2Pv/sBuwGW6a5DIYaO20dEoK0a+WtFYl pZYD8/asj6jKZdKYdm7zPvJcxlWLzQzGDdnoDt2msiK/p6t7xevTcMbtYnQ2Onw0ShQGqhifCUkFO sE4Ht7JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVUlH-00000008LHP-2f1J; Wed, 08 Jan 2025 12:02:11 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tVUEq-00000008Cbd-3ZQN; Wed, 08 Jan 2025 11:28:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736335719; bh=pQJ7SDNXxvf59weU8A9yxhu9HG3aXISLPMjLleuFHR8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XFwWrzXZNW16psV/U8eg02gvhhrvrdk8JVITghd0J20SQ2P+feP/Ed1yh2xJz0w13 v1Dtf92bT4l0IA9gmMclZD7vjHhESSBZnnFPduECy40de1jFzXevUQJYGSyLP5V1ym NrjVCXV0XtA/rj/+WA2KMEF7zcDbYzuMC6WPCo8W7DnWTsUBaBmlbTccp/xnBSylI+ UTUzhG6W7Q6Ohko3fmfSuVqzmy8hoMjXBvhufy8fDMv5WsgEJ8qSJ8CV6Ttdji6CaA lQl4ZBxOf9nhUBcrwb9QnoNu4vpEm/saMNywh1j0CewkEAaYJNTmgwn/hlPC4ZsOu0 bkc9+mwqUavjw== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3F7DF17E1570; Wed, 8 Jan 2025 12:28:38 +0100 (CET) From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, jie.qiu@mediatek.com, junzhi.zhao@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, dmitry.baryshkov@linaro.org, lewis.liao@mediatek.com, ives.chenjh@mediatek.com, tommyyl.chen@mediatek.com, jason-jh.lin@mediatek.com Subject: [PATCH v4 27/34] drm/mediatek: mtk_hdmi: Cleanup function mtk_hdmi_resume() Date: Wed, 8 Jan 2025 12:27:37 +0100 Message-ID: <20250108112744.64686-28-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250108112744.64686-1-angelogioacchino.delregno@collabora.com> References: <20250108112744.64686-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250108_032841_035138_6E8C96BF X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove the error print in case of mtk_hdmi_clk_enable_audio() failures: since the APIs will already print on their own, having one in there is redundant. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 55b72ed271bf..a14b117286ad 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1703,15 +1703,8 @@ static __maybe_unused int mtk_hdmi_suspend(struct device *dev) static __maybe_unused int mtk_hdmi_resume(struct device *dev) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); - int ret = 0; - ret = mtk_hdmi_clk_enable_audio(hdmi); - if (ret) { - dev_err(dev, "hdmi resume failed!\n"); - return ret; - } - - return 0; + return mtk_hdmi_clk_enable_audio(hdmi); } static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume);