Message ID | 20250113145232.227674-28-angelogioacchino.delregno@collabora.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Add support for MT8195/88 DPI, HDMIv2 and DDCv2 | expand |
Hi, Angelo: On Mon, 2025-01-13 at 15:52 +0100, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > Remove the error print in case of mtk_hdmi_clk_enable_audio() > failures: since the APIs will already print on their own, having > one in there is redundant. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 40eea5c125d2..c5431f160fe4 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1703,15 +1703,8 @@ static __maybe_unused int mtk_hdmi_suspend(struct device *dev) > static __maybe_unused int mtk_hdmi_resume(struct device *dev) > { > struct mtk_hdmi *hdmi = dev_get_drvdata(dev); > - int ret = 0; > > - ret = mtk_hdmi_clk_enable_audio(hdmi); I do not find where to print the error message, could you provide where would print the error message? Regards, CK > - if (ret) { > - dev_err(dev, "hdmi resume failed!\n"); > - return ret; > - } > - > - return 0; > + return mtk_hdmi_clk_enable_audio(hdmi); > } > > static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume); > -- > 2.47.0 >
Il 07/02/25 07:04, CK Hu (胡俊光) ha scritto: > Hi, Angelo: > > On Mon, 2025-01-13 at 15:52 +0100, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until you have verified the sender or the content. >> >> >> Remove the error print in case of mtk_hdmi_clk_enable_audio() >> failures: since the APIs will already print on their own, having >> one in there is redundant. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +-------- >> 1 file changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> index 40eea5c125d2..c5431f160fe4 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c >> @@ -1703,15 +1703,8 @@ static __maybe_unused int mtk_hdmi_suspend(struct device *dev) >> static __maybe_unused int mtk_hdmi_resume(struct device *dev) >> { >> struct mtk_hdmi *hdmi = dev_get_drvdata(dev); >> - int ret = 0; >> >> - ret = mtk_hdmi_clk_enable_audio(hdmi); > > I do not find where to print the error message, could you provide where would print the error message? > It's handled in drivers/base/power/main.c - upon failure, a pm_dev_err() will be executed, printing an error message stating that this (or any other) driver has failed resuming. Cheers, Angelo > Regards, > CK > >> - if (ret) { >> - dev_err(dev, "hdmi resume failed!\n"); >> - return ret; >> - } >> - >> - return 0; >> + return mtk_hdmi_clk_enable_audio(hdmi); >> } >> >> static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume); >> -- >> 2.47.0 >> >
On Mon, 2025-02-10 at 12:23 +0100, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > Il 07/02/25 07:04, CK Hu (胡俊光) ha scritto: > > Hi, Angelo: > > > > On Mon, 2025-01-13 at 15:52 +0100, AngeloGioacchino Del Regno wrote: > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > > > > > > > Remove the error print in case of mtk_hdmi_clk_enable_audio() > > > failures: since the APIs will already print on their own, having > > > one in there is redundant. > > > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > --- > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +-------- > > > 1 file changed, 1 insertion(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > index 40eea5c125d2..c5431f160fe4 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > @@ -1703,15 +1703,8 @@ static __maybe_unused int mtk_hdmi_suspend(struct device *dev) > > > static __maybe_unused int mtk_hdmi_resume(struct device *dev) > > > { > > > struct mtk_hdmi *hdmi = dev_get_drvdata(dev); > > > - int ret = 0; > > > > > > - ret = mtk_hdmi_clk_enable_audio(hdmi); > > > > I do not find where to print the error message, could you provide where would print the error message? > > > > It's handled in drivers/base/power/main.c - upon failure, a pm_dev_err() will be > executed, printing an error message stating that this (or any other) driver has > failed resuming. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Cheers, > Angelo > > > Regards, > > CK > > > > > - if (ret) { > > > - dev_err(dev, "hdmi resume failed!\n"); > > > - return ret; > > > - } > > > - > > > - return 0; > > > + return mtk_hdmi_clk_enable_audio(hdmi); > > > } > > > > > > static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume); > > > -- > > > 2.47.0 > > > > > >
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 40eea5c125d2..c5431f160fe4 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1703,15 +1703,8 @@ static __maybe_unused int mtk_hdmi_suspend(struct device *dev) static __maybe_unused int mtk_hdmi_resume(struct device *dev) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); - int ret = 0; - ret = mtk_hdmi_clk_enable_audio(hdmi); - if (ret) { - dev_err(dev, "hdmi resume failed!\n"); - return ret; - } - - return 0; + return mtk_hdmi_clk_enable_audio(hdmi); } static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume);
Remove the error print in case of mtk_hdmi_clk_enable_audio() failures: since the APIs will already print on their own, having one in there is redundant. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)