| Message ID | 20250117095217.661070-2-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add AST2600 LPC PCC support | expand |
On 17/01/2025 10:52, Kevin Chen wrote: > Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller. > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > --- Patchsets start from 1, not 0. This wasn't tested as it has obvious errors, so no review. Test your patches before you send them. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
> On 17/01/2025 10:52, Kevin Chen wrote: > > Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller. > > > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > > --- > > Patchsets start from 1, not 0. Agree, I will resend the patchsets of v1. > > This wasn't tested as it has obvious errors, so no review. Test your patches > before you send them. Agree, I will run "make dtbs_check W=1" and " make dt_binding_check " to check result is clean before the next commits. > > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people and lists > to CC. It might happen, that command when run on an older kernel, gives you > outdated entries. Therefore please be sure you base your patches on recent > Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so > fix your workflow. Tools might also fail if you work on some ancient tree (don't, > instead use mainline) or work on fork of kernel (don't, instead use mainline). > Just use b4 and everything should be fine, although remember about `b4 prep > --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be tested by > automated tooling. Performing review on untested code might be a waste of > time. > > Please kindly resend and include all necessary To/Cc entries. > </form letter> > > Best regards, > Krzysztof
On 13/02/2025 09:46, Kevin Chen wrote: >> On 17/01/2025 10:52, Kevin Chen wrote: >>> Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller. >>> >>> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> >>> --- >> >> Patchsets start from 1, not 0. > Agree, I will resend the patchsets of v1. > >> >> This wasn't tested as it has obvious errors, so no review. Test your patches >> before you send them. > Agree, I will run "make dtbs_check W=1" and " make dt_binding_check " to check result is clean before the next commits. > >> >> >> <form letter> >> Please use scripts/get_maintainers.pl to get a list of necessary people and lists >> to CC. It might happen, that command when run on an older kernel, gives you >> outdated entries. Therefore please be sure you base your patches on recent >> Linux kernel. >> >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so >> fix your workflow. Tools might also fail if you work on some ancient tree (don't, >> instead use mainline) or work on fork of kernel (don't, instead use mainline). >> Just use b4 and everything should be fine, although remember about `b4 prep >> --auto-to-cc` if you added new patches to the patchset. >> >> You missed at least devicetree list (maybe more), so this won't be tested by >> automated tooling. Performing review on untested code might be a waste of >> time. >> >> Please kindly resend and include all necessary To/Cc entries. >> </form letter> How did you implement this feedback? Best regards, Krzysztof
> On 13/02/2025 09:46, Kevin Chen wrote: > >> On 17/01/2025 10:52, Kevin Chen wrote: > >>> Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller. > >>> > >>> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > >>> --- > >> > >> Patchsets start from 1, not 0. > > Agree, I will resend the patchsets of v1. > > > >> > >> This wasn't tested as it has obvious errors, so no review. Test your > >> patches before you send them. > > Agree, I will run "make dtbs_check W=1" and " make dt_binding_check " to > check result is clean before the next commits. > > > >> > >> > >> <form letter> > >> Please use scripts/get_maintainers.pl to get a list of necessary > >> people and lists to CC. It might happen, that command when run on an > >> older kernel, gives you outdated entries. Therefore please be sure > >> you base your patches on recent Linux kernel. > >> > >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of > >> people, so fix your workflow. Tools might also fail if you work on > >> some ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). > >> Just use b4 and everything should be fine, although remember about > >> `b4 prep --auto-to-cc` if you added new patches to the patchset. > >> > >> You missed at least devicetree list (maybe more), so this won't be > >> tested by automated tooling. Performing review on untested code might > >> be a waste of time. > >> > >> Please kindly resend and include all necessary To/Cc entries. > >> </form letter> > > How did you implement this feedback? make dtbs_check W=1 # Check the lpc-pcc or pcc message from the log make dt_binding_check # No Error make coccicheck MODE=report # Stop at the following log but no related log. # OCaml scripting is unsupported. # coccicheck failed > > Best regards, > Krzysztof
On 18/02/2025 12:05, Kevin Chen wrote: >> On 13/02/2025 09:46, Kevin Chen wrote: >>>> On 17/01/2025 10:52, Kevin Chen wrote: >>>>> Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller. >>>>> >>>>> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> >>>>> --- >>>> >>>> Patchsets start from 1, not 0. >>> Agree, I will resend the patchsets of v1. >>> >>>> >>>> This wasn't tested as it has obvious errors, so no review. Test your >>>> patches before you send them. >>> Agree, I will run "make dtbs_check W=1" and " make dt_binding_check " to >> check result is clean before the next commits. >>> >>>> >>>> >>>> <form letter> >>>> Please use scripts/get_maintainers.pl to get a list of necessary >>>> people and lists to CC. It might happen, that command when run on an >>>> older kernel, gives you outdated entries. Therefore please be sure >>>> you base your patches on recent Linux kernel. >>>> >>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >>>> people, so fix your workflow. Tools might also fail if you work on >>>> some ancient tree (don't, instead use mainline) or work on fork of kernel >> (don't, instead use mainline). >>>> Just use b4 and everything should be fine, although remember about >>>> `b4 prep --auto-to-cc` if you added new patches to the patchset. >>>> >>>> You missed at least devicetree list (maybe more), so this won't be >>>> tested by automated tooling. Performing review on untested code might >>>> be a waste of time. >>>> >>>> Please kindly resend and include all necessary To/Cc entries. >>>> </form letter> >> >> How did you implement this feedback? > > make dtbs_check W=1 > # Check the lpc-pcc or pcc message from the log > > make dt_binding_check > # No Error > > make coccicheck MODE=report > # Stop at the following log but no related log. > # OCaml scripting is unsupported. > # coccicheck failed You answered probably to earlier part of email, not to the one I asked about. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml b/Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml new file mode 100644 index 000000000000..6c2134497de2 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# # Copyright (c) 2024 Aspeed Technology Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aspeed Post Cost Capture Controller + +maintainers: + - Kevin Chen <kevin_chen@aspeedtech.com> + - Chia-Wei Wang <chiawei_wang@aspeedtech.com> + +description: + The Aspeed PCC control allow to capture POST code from Host. + + This driver is for the BMC side. POST code data can be access by + /dev/aspeed-lpc-pcc0. For example, POST code data is below. + ~# hexdump /dev/aspeed-lpc-pcc0 + 0000000 40b3 40a0 40a3 40a2 40a2 40b4 40a5 40ee + 0000010 40ee 40ee 40ee 40ee 40ee 40ee 40ee 40ee + 0000020 40ee 40ee 40ee 40ee 40ee 40ee 40ee 40a6 + +properties: + compatible: + items: + - enum: + - aspeed,ast2600-lpc-pcc + reg: + maxItems: 1 + +required: + - compatible + +additionalProperties: false + +examples: + - | + lpc: lpc@1e789000 { + compatible = "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon"; + reg = <0x1e789000 0x1000>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e789000 0x1000>; + + lpc_pcc: lpc-pcc@0 { + compatible = "aspeed,ast2600-lpc-pcc"; + reg = <0x0 0x140>; + }; + };
Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller. Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> --- .../bindings/soc/aspeed/lpc-pcc.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml