| Message ID | 20250121063900.3211-2-quic_jinlmao@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | coresight: Add remote etm support | expand |
On Tue, Jan 21, 2025 at 02:38:59PM +0800, Mao Jinlong wrote: > Use different compatible to distinguish between different remote > etms. Why? Every second time for qcom. Don't say what, we see that easily. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../bindings/arm/qcom,coresight-remote-etm.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml > index 4fd5752978cd..199f2ca4b8a9 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml > @@ -18,7 +18,14 @@ description: > > properties: > compatible: > - const: qcom,coresight-remote-etm > + contains: No, you are now saying this is "qcom,pink-pony" as well... Sorry, this change is neither explained, nor correct. > + enum: > + - qcom,coresight-modem-etm > + - qcom,coresight-wcn-etm > + - qcom,coresight-adsp-etm > + - qcom,coresight-sensor-etm > + - qcom,coresight-modem2-etma And how anyone can understand the difference between modem and modem2? NAK for entire patch in this form. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml index 4fd5752978cd..199f2ca4b8a9 100644 --- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml @@ -18,7 +18,14 @@ description: properties: compatible: - const: qcom,coresight-remote-etm + contains: + enum: + - qcom,coresight-modem-etm + - qcom,coresight-wcn-etm + - qcom,coresight-adsp-etm + - qcom,coresight-sensor-etm + - qcom,coresight-modem2-etm + - qcom,coresight-cdsp-etm out-ports: $ref: /schemas/graph.yaml#/properties/ports @@ -38,7 +45,7 @@ additionalProperties: false examples: - | etm { - compatible = "qcom,coresight-remote-etm"; + compatible = "qcom,coresight-modem-etm"; out-ports { port {
Use different compatible to distinguish between different remote etms. Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> --- .../bindings/arm/qcom,coresight-remote-etm.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)