| Message ID | 20250124052611.3705-1-eagle.alexander923@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Fix broken tsadc pinctrl binding for rk3588 | expand |
Hi Alexander, On Fri, Jan 24, 2025 at 9:26 AM Alexander Shiyan <eagle.alexander923@gmail.com> wrote: > > There is no pinctrl "gpio" and "otpout" (probably designed as "output") > handling in the tsadc driver. > Let's use proper binding "default" and "sleep". This looks reasonable, however I've tried it on my Radxa Rock 5C and the driver still doesn't claim GPIO0 RK_PA1 even with this change. As a result, a simulated thermal runaway condition (I've changed the tshut temperature to 65000 and tshut mode to 1) doesn't trigger a PMIC reset, even though a direct `gpioset 0 1=0` does. Are any additional changes needed to the driver itself? Best regards, Alexey
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi index a337f3fb8377..f141065eb69d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi @@ -2667,9 +2667,9 @@ tsadc: tsadc@fec00000 { rockchip,hw-tshut-temp = <120000>; rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */ rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */ - pinctrl-0 = <&tsadc_gpio_func>; - pinctrl-1 = <&tsadc_shut>; - pinctrl-names = "gpio", "otpout"; + pinctrl-0 = <&tsadc_shut>; + pinctrl-1 = <&tsadc_gpio_func>; + pinctrl-names = "default", "sleep"; #thermal-sensor-cells = <1>; status = "disabled"; };
There is no pinctrl "gpio" and "otpout" (probably designed as "output") handling in the tsadc driver. Let's use proper binding "default" and "sleep". Fixes: 32641b8ab1a5 ("arm64: dts: rockchip: add rk3588 thermal sensor") Cc: stable@vger.kernel.org Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)