| Message ID | 20250204-exynos7870-usb-v1-2-a7753f8183a4@disroot.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce DWC3 support for Exynos7870 | expand |
On Tue, Feb 04, 2025 at 02:09:30AM +0530, Kaustabh Chakraborty wrote: > Exynos7870 devices have a DWC3 compatible USB 2.0 controller. > Add support in the driver by: > - Adding its own compatible string, "samsung,exynos7870-dwusb2". > - Adding three USBDRD clocks named "usbdrd20", "usbdrd20_ctrl_clk", and > "usbdrd20_ref_clk", to be controlled by the driver. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > --- > drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c > index f5d963fae9e069e1bd145ff5bd1b704da89fb74c..34f2b9e8529303cd2a957baed5819a45cbcf3309 100644 > --- a/drivers/usb/dwc3/dwc3-exynos.c > +++ b/drivers/usb/dwc3/dwc3-exynos.c > @@ -163,6 +163,12 @@ static const struct dwc3_exynos_driverdata exynos7_drvdata = { > .suspend_clk_idx = 1, > }; > > +static const struct dwc3_exynos_driverdata exynos7870_drvdata = { > + .clk_names = { "usbdrd20", "usbdrd20_ctrl_clk", "usbdrd20_ref_clk" }, We already stopped this mad downstream pattern, so don't reintroduce it. Use proper names describing the purpose of the clock, not the source name. See Exynos850 or GS101. This is probably bus_early, "something?" and finally ref. Best regards, Krzysztof
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index f5d963fae9e069e1bd145ff5bd1b704da89fb74c..34f2b9e8529303cd2a957baed5819a45cbcf3309 100644 --- a/drivers/usb/dwc3/dwc3-exynos.c +++ b/drivers/usb/dwc3/dwc3-exynos.c @@ -163,6 +163,12 @@ static const struct dwc3_exynos_driverdata exynos7_drvdata = { .suspend_clk_idx = 1, }; +static const struct dwc3_exynos_driverdata exynos7870_drvdata = { + .clk_names = { "usbdrd20", "usbdrd20_ctrl_clk", "usbdrd20_ref_clk" }, + .num_clks = 3, + .suspend_clk_idx = -1, +}; + static const struct dwc3_exynos_driverdata exynos850_drvdata = { .clk_names = { "bus_early", "ref" }, .num_clks = 2, @@ -185,6 +191,9 @@ static const struct of_device_id exynos_dwc3_match[] = { }, { .compatible = "samsung,exynos7-dwusb3", .data = &exynos7_drvdata, + }, { + .compatible = "samsung,exynos7870-dwusb2", + .data = &exynos7870_drvdata, }, { .compatible = "samsung,exynos850-dwusb3", .data = &exynos850_drvdata,
Exynos7870 devices have a DWC3 compatible USB 2.0 controller. Add support in the driver by: - Adding its own compatible string, "samsung,exynos7870-dwusb2". - Adding three USBDRD clocks named "usbdrd20", "usbdrd20_ctrl_clk", and "usbdrd20_ref_clk", to be controlled by the driver. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++ 1 file changed, 9 insertions(+)