From patchwork Wed Feb 5 00:58:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960295 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E83B9C02193 for ; Wed, 5 Feb 2025 01:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=zk2K5TNhvfsoukHYOwDMPii0Ne vYYT7005gP/+StVJ36iyrAWhl0ql32MyNxSjHPVw+VA7VkvdujqimNE/AfAT+aVSUU97FhzvaQ2vp D+E8JGbT0znGZHvOFMyx0Eadyc+OKF6ZgXbRvvET4YGtcDiGAfUmh8PFPLbJI3JKPBigaSQkl0X6H OqAOhfUEhOAi1M+EAwLXn6r2NFZBun0gJU3GoyfBQu1b93sOHmWupfcCZlsV70/VNzbnoCEsaxEcu tbsOhIK5/h6QDjqfUPMvRlsosoK8fMmPqrjU+SuwLSNqzyvfVXrQM16MWYdeC7y38WtxRLYCNryNd Gof3RQ/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTqP-00000001zFH-2Y2E; Wed, 05 Feb 2025 01:04:45 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlE-00000001yMs-1DTL; Wed, 05 Feb 2025 00:59:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hF8jQHR1bHpGG7DBMWG4w3dibEjlI6xmYMtp9LizNLzqVEpVShVxsK/P7yi+jAMA+G1oEtckq4bUg6jsXubb7aB2UqT8LP6ghhRb9avIcyRrXuwa+myDF9Gj8PyD2LFPOFhT7ecdWodliU7C0BuKg0+r8duJEWKgtoHff+uz+HPtCwogkdY6QV5fHNKF+F9xRBN2am13k33Q1AIQKm7eT57pyigS0k8JSuZZnDcbwd98ehoQ4hnegB64IElKvtZFEJ66ezvJ2xC21au8t+1vFgfM9biMT6imqJTVXIHYEucRHzLQgbqtCre+whbfTDzfIPFkWu2EVDM7DPc11qVFSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=WMdWd50jrOVMQcKddw2nlMF8w4S+GQBYMZ/TvtYCfmtBvRiwYhoCPChfxOWmOe1+V0gM/K6nJUxy0CM1+MYRq1VsWeM2Ya6E51qZC3a83MjrzdIYAIGeiYIfujs+eozcvAQ8nqLNNVEJZ1dElO2Ocei/aHl697psv6Chi38iRy9tBcySN0VIUI3i+hm4yQWUXKPzf9GNcpWrTNwgUGi0Q8wqznJsytrcNWmEB/jptOLeUePEoDZY64PMvUk12xCum6UIGVA1fZDBqGedr4p/ZkBgGwUqZLklfnzK7gary5BQ4CMp8yqKZbYbni1cBPC0Uk17ihWwDI9TjFmEAIkRsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=jpP49Yi1f/uJKBF/HuCKyH1176JGLscSmnjV4HizVqOpDN3EYSVXdKRFhiOd347ukXPhRqPzRo4N48Udj3QDyXX2IfxTcpHcmBwU+qKfbeeD0OD4JQR1tUKUhTlMq/4JV1bp6foAm/TN1rQUpRZxznZvaEcN4/vpNY/uy0kSv1mtfQHV5m3c/X4J9Bv8G+iP7U0P1Gz8f6+xPLxrWTstKD7/UBTGpt1zV7U75HvO/FvplFj8mWIxsPOLnkF/ZFJjMK2uzbUOWwo6q4pB9Vmn7rIVI2TncRF2xfk5L9flIpL41JzP5zpGcNj/lYBlogLk9nG5ysSRzQT/FnCK+NFmjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:21 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:21 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:21 +0800 Subject: [PATCH 3/7] rtc: ds1343: Use devm_pm_set_wake_irq Message-Id: <20250205-rtc-cleanup-v1-3-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1119; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=yYeVC601Fmqm3h8IRsE1e0gqqkwuyZ6uKwkA4brZ+6s=; b=+jZfInCaWBrh1hOlNrO+2f2hgBbfBUBVT/+siBpwsFBqPZBBARXE+oQbSs2ZdbRSDvheP5xec 3EQXrX8A67WANLhoZl/HhnkDbpTNAaVHp4vwnuMDgWKmNZ+/5J+sQJ0 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 91fcd344-6bdf-4d9d-9292-08dd4580537a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?UVIhPBJte3pL0hK/RDj2J0G0PUiYE5x?= =?utf-8?q?UFUPGLjN5XFi8m8BI+ik0il9XwbUNALqO41K/SeAgWWgBWHGtK68gwOZ/Z6oWXAa6?= =?utf-8?q?N4hnJNgtxC/LS2wdM5AKazac0a1ojYtp1jhqkU+qSCm52WWQx5G4ReFvv63EUOjSK?= =?utf-8?q?t3uRfIPTASWvwbkylnVngQaATTV3l8vhVSC9pb6rawOeHyTOMmuTuAYmrKuz2nbS8?= =?utf-8?q?4x+A0UORojLpNCrE1zipDfyg2lKoIY5cLGp8NfvcFwtYa/BOnMh7UW0UBVgqW8gTL?= =?utf-8?q?wWp+9/X/kj/iTYN1ZpcNuV2zmFYoLH+T36sN+9zUeNgwGjCUd5THmmlrFJKsimx7D?= =?utf-8?q?t2dxhiivRMb/V5c+Isay4rLK9JQNe9snQRvn9JuTYYoupS/JhYn40poRd1l9Q0sYx?= =?utf-8?q?rliFgOnNAD79icJnGB1dwd7wVx97Tzi2d/lKi2hBDSY3q2Y0VIlny/8GYDqtxNOeC?= =?utf-8?q?fob/pUrntpGNbAc4jR7RSZhFLT24jIiJzD1ASJ9XFceoG5xO6HJiqvpXpJt+rz+jQ?= =?utf-8?q?+HdY1xln1Jd3CTGg3R3bnL4v6A87KE9r3S9nB3pmZ5USzAjCGIrpPpbZ7/kQQBjnC?= =?utf-8?q?vl0ys2T9oL89HydOZCPjnugckQnxT+aDRWRJ5Txoff8VCmV2YBvF0hnotH8rddQNv?= =?utf-8?q?TxTI1+g/bQnAz6VzGzhxVrxTmso24pU+vMnu/XtTrRxRF1JtBPUhNy1HutAInpzR5?= =?utf-8?q?+0Ydt1uZA5pC6nozHUZc5/hxTsljtvsdGY3A1iqdRotDxqlly0OMskT9SaQdE/hf3?= =?utf-8?q?iWozs5C1oXdW/Dn/BzoTLyALvq6Ym2C7UYbmuOnT1bkExg9uEld0YWbg5h/sQF8Fc?= =?utf-8?q?IIqqp/5QKZt/TMe/dVzoFBD5foFLDh3o+7F/SmVzgRD1WbBPggddhMx69w5j1bIUc?= =?utf-8?q?TaeDITaboLwYx4ExUlXOsmBzrK0zPWQL5ughs3J7rpwbUn+8ovtwcPmxc9xFd573v?= =?utf-8?q?S9UIeLqI2eqpzLcmt4gSd4H1i/irqFU3vU1vTZjLQqQCKpHlk6j4Rtce6uLgNn9Ex?= =?utf-8?q?7q1D6SMqXLwMHHy2RvBlLgnDINhk2CL9r0BbzMUlgyFoYxRQzH4RSFRQ1ClpiwlL4?= =?utf-8?q?OUeeUwGwN6dJnF9W81URy+gLgVk8eRwyBdvk4ppYTacSoBT7vuxzxIB/8xe329bN/?= =?utf-8?q?RYOZdz69t3X7YIIZQl/Z8jD8Kt/1UMc+Nvh3SHJUMlE4IgcwORqmNlZzeX7XsZW7+?= =?utf-8?q?8K/4Z116VzLNoLJgeQspd3woq8Uhh/rtea8yI6viNYPwHosIDJ2QVoUDv/1L3Qvxg?= =?utf-8?q?PkGMjffmq8PrHAfDabq6e0wwS8HPXe2xtW1TJwhzsxj5LzDVKshWZK67h1gkZOLl+?= =?utf-8?q?RPqqhZuAYZAmBB9vau9pPDOfFJ/n4ZfrFfqz39/z2KJqy/d5JVJWCMKJC9THhHtEP?= =?utf-8?q?n3vzLQBF/FE?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1qxFidNJgDjg/n8jJfx+W6/87viX?= =?utf-8?q?EKSn+4gbnkAkdSLO+zg+oxUSRFzwVpF5HoNaOgpUXa5a0SwCayl5+RwNO4aLx7pgG?= =?utf-8?q?6gT/cLDqOc4iv0++4rLILweYvIko6+8q3p2qUvrcju/KsF8uV4AcFPUdYIpMboj0m?= =?utf-8?q?sCSXFzU6IU3P350UfoIUxCHsa8zPbBbxtveMdCn0i0I58TRmbDsxvOSlTVZRINYiE?= =?utf-8?q?/EzndxgjXoW4gzxN9UEt244yJg38KA8cfukgspmp+eYUCSOQIgpvJxmj/MmPSNg4i?= =?utf-8?q?qvjkqBDjytsNZL8a+9y0Gxz3jsvRYwWVh2DYAQvRogocc9ICRl5iLezwF5D11L1tm?= =?utf-8?q?I+mveVfpiocz2tcWZFz2Ql7rbCgFPhWQVI4grNgR/96MnVOxavJt/DnsZAiVbqTC6?= =?utf-8?q?mbwmnRvjo/FD5v8bmseI7b9PF6acBi34JLq+UVYielpruNgKDSQyw6qYusNvdoMDe?= =?utf-8?q?dHmARr9tWrWi1LjNMaTq8tkdZmNJgmEYgjApgRO88S3rW4HF6Zfl7HwK2/TmFXWAH?= =?utf-8?q?Ejj7ZXxEp58tv5iCDMH236yWYFWuEwhKTqDyGkSB4bXBk+0exK9bjRio4xwFE4Zmd?= =?utf-8?q?qOYxt2DZEQgqgqhQM7buYyM+2lWBViJkIaiIoelAjSw6MUi1yxXsvbSpZxLN9uu0P?= =?utf-8?q?ZlaZwb7Nbu/3WLQB0B9cPRtdXdKkGUVpNkHIrCkJa2Dnuvw7J/IEdQldSrDGQKt29?= =?utf-8?q?ESpqFs1dWCfaCe6PtuOWgkIrQgBtCHgKSI1fda7a554v99xQdKiqB7MnKw1xiMuVM?= =?utf-8?q?kTWOZNMMJCRYE3X2sWEBBFzNKe16ZytPopNjOPlwdn8NY3EnnM0/AQuCp5VRTfvOW?= =?utf-8?q?gC6Rdj8Owlz/7zXJ/Hd4FB+wp2QaTC0F/0fcexnaZKI4e3c9vDydUMAGVCdi3Pg0r?= =?utf-8?q?CrnDKNKATIQZj6zFBOttFys8xxG1sb0T1DI2eT4hVfj0i8GYH++w2vplrl7UmDdIz?= =?utf-8?q?VHT3KSdz5qmOA/FATrqVrGQ4NShWMfUI2gsq8ZO/r2ENbS7CoLEH+KlQb0o3Sp9GY?= =?utf-8?q?tnpk43p5OivCsFpSvjICnkqTV8ApRZG/DKUs8Fl1vCVPY7QOMVgzmVrKYmmTm7XVV?= =?utf-8?q?b+HFtriaXUSaVjnbRf8OpjAI58xn2dDom4CtGdtWIhfLyYUeMHNva0GoOXvGW1zOp?= =?utf-8?q?OJcu1zpMvm4nI4/TZFveiuFlwlMaKzT9gbXvKHPZuFCfObYNDpmgjNnD941l30t4R?= =?utf-8?q?eyDWe6fMHIBuMICbz0uI5/f8OntuUCtkwWu6rcL9HjUT9/u/p7nwTAPQMfLOHtXtN?= =?utf-8?q?DrmwzQTIH9cAF0XkNxsK1P4o7KDWajlX03BoiFbkCEIys36SuGx50HJ+ShmyAkApH?= =?utf-8?q?z2OKRCvEmmHesc4uHI0k5AOGhbSNlNmHJpeEOQdCG7SYmOPBGSQ2GPd5M9fUGuFJR?= =?utf-8?q?ysN+1XWIaxAEZ0sWYb3M4BBX1WkmSEtcbNKEXcOMgfcA7nutF4FCRAZM3+ywu7BlO?= =?utf-8?q?TssErwkMVZbDlMI++o2sne6LLPWDhPdu1XcvOBcmZQhTFDyq1iD+mtnIHzzSumwxQ?= =?utf-8?q?01Fjf8o8xctj?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91fcd344-6bdf-4d9d-9292-08dd4580537a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:21.6295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TPliWJlOGwUsNudt58OJ3wpS0t9EwlWYAW3C9ombczuPWBe+NO0MXOqpoeeWMO6eSjaJO0D/+jY1Ac3M27AgVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165924_341904_434A796D X-CRM114-Status: UNSURE ( 8.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-ds1343.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index ed5a6ba89a3eeb2a0b9d6dea3c8b3d40aa2cf317..aa9500791b7e0300b150bd654b69c74f3e5e6e6b 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -427,18 +427,13 @@ static int ds1343_probe(struct spi_device *spi) "unable to request irq for rtc ds1343\n"); } else { device_init_wakeup(&spi->dev, true); - dev_pm_set_wake_irq(&spi->dev, spi->irq); + devm_pm_set_wake_irq(&spi->dev, spi->irq); } } return 0; } -static void ds1343_remove(struct spi_device *spi) -{ - dev_pm_clear_wake_irq(&spi->dev); -} - #ifdef CONFIG_PM_SLEEP static int ds1343_suspend(struct device *dev) @@ -471,7 +466,6 @@ static struct spi_driver ds1343_driver = { .pm = &ds1343_pm, }, .probe = ds1343_probe, - .remove = ds1343_remove, .id_table = ds1343_id, };