clk: rockchip: mark hclk_vi as critical on rk3568

Commit Message

Michael Riesch Feb. 10, 2025, 8:29 a.m. UTC

The clock 'pclk_vi_niu' has a dependency on 'hclk_vi_niu' according
to the Technical Reference Manual section '2.8.6 NIU Clock gating
reliance'. However, this kind of dependency cannot be addressed
properly at the moment (until the support for linked clocks is
implemented for the RK3568).
As an intermediate solution, mark the hclk_vi as critical on the
Rockchip RK3568.

Suggested-by: Nicolas Frattaroli <[e-mail]>
Signed-off-by: Michael Riesch <[e-mail]>
---
 drivers/clk/rockchip/clk-rk3568.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250210-rk3568-hclk-vi-aace45995131

Best regards,

Comments

Heiko Stübner Feb. 26, 2025, 7:49 p.m. UTC | #1

On Mon, 10 Feb 2025 09:29:02 +0100, Michael Riesch wrote:
> The clock 'pclk_vi_niu' has a dependency on 'hclk_vi_niu' according
> to the Technical Reference Manual section '2.8.6 NIU Clock gating
> reliance'. However, this kind of dependency cannot be addressed
> properly at the moment (until the support for linked clocks is
> implemented for the RK3568).
> As an intermediate solution, mark the hclk_vi as critical on the
> Rockchip RK3568.
> 
> [...]

Applied, thanks!

[1/1] clk: rockchip: mark hclk_vi as critical on rk3568
      commit: 83dbeca33f7422f4a30c8a91a79d6c0dba4fb6af

Best regards,

Patch

diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index 53d10b1c627b..7d9279291e76 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1602,6 +1602,7 @@  static const char *const rk3568_cru_critical_clocks[] __initconst = {
 	"pclk_php",
 	"hclk_usb",
 	"pclk_usb",
+	"hclk_vi",
 	"hclk_vo",
 };