| Message ID | 20250211065223.4831-1-ada@thorsis.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Microchip OTPC driver on SAM9X60 exposing UIDxR as additional nvmem device | expand |
On 11.02.2025 08:52, Alexander Dahl wrote: > Makes no sense to have a timeout shorter than the sleep time, it would > run into timeout right after the first sleep already. > While at it, use a more specific macro instead of the generic one, which > does exactly the same, but needs less parameters. > > Signed-off-by: Alexander Dahl <ada@thorsis.com> > Fixes: 98830350d3fc ("nvmem: microchip-otpc: add support") Fixes tag goes above you SoB tag. > --- > > Notes: > v2: > - Add Fixes tag > > drivers/nvmem/microchip-otpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c > index e2851c63cc0b4..bf7e5167152cb 100644 > --- a/drivers/nvmem/microchip-otpc.c > +++ b/drivers/nvmem/microchip-otpc.c > @@ -85,8 +85,8 @@ static int mchp_otpc_prepare_read(struct mchp_otpc *otpc, > writel_relaxed(MCHP_OTPC_CR_READ, otpc->base + MCHP_OTPC_CR); > > /* Wait for packet to be transferred into temporary buffers. */ > - return read_poll_timeout(readl_relaxed, tmp, !(tmp & MCHP_OTPC_SR_READ), > - 10000, 2000, false, otpc->base + MCHP_OTPC_SR); > + return readl_relaxed_poll_timeout(otpc->base + MCHP_OTPC_SR, tmp, > + !(tmp & MCHP_OTPC_SR_READ), 2000, 10000); > } > > /*
diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c index e2851c63cc0b4..bf7e5167152cb 100644 --- a/drivers/nvmem/microchip-otpc.c +++ b/drivers/nvmem/microchip-otpc.c @@ -85,8 +85,8 @@ static int mchp_otpc_prepare_read(struct mchp_otpc *otpc, writel_relaxed(MCHP_OTPC_CR_READ, otpc->base + MCHP_OTPC_CR); /* Wait for packet to be transferred into temporary buffers. */ - return read_poll_timeout(readl_relaxed, tmp, !(tmp & MCHP_OTPC_SR_READ), - 10000, 2000, false, otpc->base + MCHP_OTPC_SR); + return readl_relaxed_poll_timeout(otpc->base + MCHP_OTPC_SR, tmp, + !(tmp & MCHP_OTPC_SR_READ), 2000, 10000); } /*
Makes no sense to have a timeout shorter than the sleep time, it would run into timeout right after the first sleep already. While at it, use a more specific macro instead of the generic one, which does exactly the same, but needs less parameters. Signed-off-by: Alexander Dahl <ada@thorsis.com> Fixes: 98830350d3fc ("nvmem: microchip-otpc: add support") --- Notes: v2: - Add Fixes tag drivers/nvmem/microchip-otpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)