| Message ID | 20250212-kernel-upstreaming-add_gpio_support-v1-5-080e724a21f3@blaize.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for VeriSilicon APB GPIO driver | expand |
On 12/02/2025 14:46, Nikolaos Pasaloukos wrote:
> Add support for VeriSilicon GPIO controller.
You enable not add support, but still the main question is: Why? Which
devices needs it? Why this cannot be a module?
Best regards,
Krzysztof
On 12/02/2025 15:25, Krzysztof Kozlowski wrote: > On 12/02/2025 14:46, Nikolaos Pasaloukos wrote: >> Add support for VeriSilicon GPIO controller. > You enable not add support, but still the main question is: Why? Which > devices needs it? Why this cannot be a module? Hi Krzysztof, Thank you for your fast review and apologies for the typo. I forgot to mention on the commit message but I have mentioned in the cover letter that the driver is needed for the Blaize BLZP1600 CB2 board which is already supported on v6.14. I will fix the commit message on V2. This driver enables support (controls) for multiple peripherals on the board, like Ethernet for NFS boot, SD and eMMC to load modules from these media. Without this driver build in the kernel, it will be hard to mount a filesystem and load modules. Kind regards, Nikolaos > > > > Best regards, > Krzysztof
On Wed, Feb 12, 2025 at 5:20 PM Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com> wrote: > > On 12/02/2025 15:25, Krzysztof Kozlowski wrote: > > > On 12/02/2025 14:46, Nikolaos Pasaloukos wrote: > >> Add support for VeriSilicon GPIO controller. > > You enable not add support, but still the main question is: Why? Which > > devices needs it? Why this cannot be a module? > > Hi Krzysztof, > > Thank you for your fast review and apologies for the typo. I forgot to > mention on the commit message but I have mentioned in the cover letter > that the driver is needed for the Blaize BLZP1600 CB2 board which is > already supported on v6.14. I will fix the commit message on V2. > > This driver enables support (controls) for multiple peripherals on > the board, like Ethernet for NFS boot, SD and eMMC to load modules from > these media. Without this driver build in the kernel, it will be hard to > mount a filesystem and load modules. > That's alright but typically you'd want to have something like: default y if ARCH_BLAIZE in the driver's Kconfig entry. Bart
On 12/02/2025 16:28, Bartosz Golaszewski wrote: > On Wed, Feb 12, 2025 at 5:20 PM Nikolaos Pasaloukos > <nikolaos.pasaloukos@blaize.com> wrote: >> On 12/02/2025 15:25, Krzysztof Kozlowski wrote: >> >>> On 12/02/2025 14:46, Nikolaos Pasaloukos wrote: >>>> Add support for VeriSilicon GPIO controller. >>> You enable not add support, but still the main question is: Why? Which >>> devices needs it? Why this cannot be a module? >> Hi Krzysztof, >> >> Thank you for your fast review and apologies for the typo. I forgot to >> mention on the commit message but I have mentioned in the cover letter >> that the driver is needed for the Blaize BLZP1600 CB2 board which is >> already supported on v6.14. I will fix the commit message on V2. >> >> This driver enables support (controls) for multiple peripherals on >> the board, like Ethernet for NFS boot, SD and eMMC to load modules from >> these media. Without this driver build in the kernel, it will be hard to >> mount a filesystem and load modules. >> > That's alright but typically you'd want to have something like: > > default y if ARCH_BLAIZE > > in the driver's Kconfig entry. > > Bart Hi Bart, Thank you for your suggestion. I will fix it on V2. Kind regards, Nikolaos
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 246a13412bf05221e4e306ff0857dde13f0fd155..26d7b99a276f737b57f317f7d7ca1228d1183a02 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -660,6 +660,7 @@ CONFIG_GPIO_RCAR=y CONFIG_GPIO_SYSCON=y CONFIG_GPIO_UNIPHIER=y CONFIG_GPIO_VISCONTI=y +CONFIG_GPIO_VSIAPB=y CONFIG_GPIO_WCD934X=m CONFIG_GPIO_VF610=y CONFIG_GPIO_XGENE=y
Add support for VeriSilicon GPIO controller. Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)