| Message ID | 20250213180309.485528-2-vincenzo.frascino@arm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: Add Arm Morello support | expand |
Hi Vincenzo, thanks for your patch! On Thu, Feb 13, 2025 at 7:03 PM Vincenzo Frascino <vincenzo.frascino@arm.com> wrote: > Add compatibility to Arm Morello System Development Platform. > > Note: Morello is at the same time the name of an Architecture [1], an SoC > [2] and a Board [2]. > To distinguish in between Architecture/SoC and Board we refer to the first > as arm,morello and to the second as arm,morello-sdp. > > [1] https://developer.arm.com/Architectures/Morello > [2] https://www.morello-project.org/ > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > --- > Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml | 4 ++++ I was thinking, that since the .dtsi and .dts files are not reusing any of the Juno .dtsi (correct me if I'm wrong!) this should not be in vexpress-juno.yaml, instead perhaps you should create a new morello.yaml file? Yours, Linus Walleij
On Fri, Feb 14, 2025 at 11:38:54AM +0100, Linus Walleij wrote: > Hi Vincenzo, > > thanks for your patch! > > On Thu, Feb 13, 2025 at 7:03 PM Vincenzo Frascino > <vincenzo.frascino@arm.com> wrote: > > > Add compatibility to Arm Morello System Development Platform. > > > > Note: Morello is at the same time the name of an Architecture [1], an SoC > > [2] and a Board [2]. > > To distinguish in between Architecture/SoC and Board we refer to the first > > as arm,morello and to the second as arm,morello-sdp. > > > > [1] https://developer.arm.com/Architectures/Morello > > [2] https://www.morello-project.org/ > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > > --- > > Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml | 4 ++++ > > I was thinking, that since the .dtsi and .dts files are not reusing > any of the Juno .dtsi (correct me if I'm wrong!) this should not > be in vexpress-juno.yaml, instead perhaps you should create a new > morello.yaml file? > It is me who suggested to put it along with other vexpress stuff as I wasn't sure how much of vexpress bindings will be reused here when Vincenzo started this. I agree it can be a separate binding on its own as I don't see much commonality now with the vexpress bindings. Just a note, though the file is named arm,vexpress-juno.yaml, it also carries bindings for all Vexpress based Arm Ltd boards(both 32-bit and 64-bit ones), but they all use common vexpress bindings in general. I just thought of highlighting that so that the expectation to reuse this file is not to check commonality in juno dtsi files but to check the vexpress binding reuse. Hope we are aligned with that. -- Regards, Sudeep
diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml index 8dd6b6446394..40e7910756c8 100644 --- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml +++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml @@ -118,6 +118,10 @@ properties: items: - const: arm,foundation-aarch64 - const: arm,vexpress + - description: Arm Morello System Development Platform + items: + - const: arm,morello-sdp + - const: arm,morello arm,vexpress,position: description: When daughterboards are stacked on one site, their position