| Message ID | 20250214011556.1891113-1-marshall_zhan@wiwynn.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [dev,6.6,v3] ARM: dts: aspeed: yosemite4: add I3C config in DTS | expand |
Hi Marshall, On Fri, 2025-02-14 at 09:15 +0800, MarshallZhan-wiwynn wrote: > Set I3C config in yosemite4 DTS. > > Test plan: > Tested pass with aspeed I3C patches and I3C hub driver. Can you please expand the commit message to provide details? This statement is quite vague, and I don't find it terribly helpful as it stands. Which aspeed patches? What tests? > > Signed-off-by: MarshallZhan-wiwynn <marshall_zhan@wiwynn.com> > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 88 > +++++++++++++++++++ > 1 file changed, 88 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook- > yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook- > yosemite4.dts > index ab4904cf2c0e..3f98e67674d0 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -1317,6 +1317,94 @@ eeprom@50 { > }; > }; > > ... > &adc0 { > status = "okay"; > pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default > -- > 2.25.1 > > WIWYNN PROPRIETARY > This email (and any attachments) contains proprietary or confidential > information and is for the sole use of its intended recipient. Any > unauthorized review, use, copying or distribution of this email or > the content of this email is strictly prohibited. If you are not the > intended recipient, please notify the sender and delete this email > immediately. Please avoid including these confidentiality clauses: https://subspace.kernel.org/etiquette.html#do-not-include-confidentiality-disclaimers Andrew
On Mon, 2025-02-17 at 11:14 +1030, Andrew Jeffery wrote: > Hi Marshall, > > On Fri, 2025-02-14 at 09:15 +0800, MarshallZhan-wiwynn wrote: > > Set I3C config in yosemite4 DTS. > > > > Test plan: > > Tested pass with aspeed I3C patches and I3C hub driver. > > Can you please expand the commit message to provide details? This > statement is quite vague, and I don't find it terribly helpful as it > stands. Which aspeed patches? What tests? Also, you've sent this patch to the upstream lists and maintainers, but it appears you're intending this to be applied to the OpenBMC kernel fork. Please understand the difference between the two and review my recent response to Rush Chen: https://lore.kernel.org/all/9f0447151e6574d74e7fa9cbbb50d8e970059273.camel@codeconstruct.com.au/ Beyond that, for patches to be backported into the OpenBMC fork they should first be merged upstream, in which case they must be tested against a recent upstream tag (e.g. v6.14-r3) before they are sent. It will be worth reviewing the following: https://docs.kernel.org/process/development-process.html The "Submitting Patches" documentation provides a more succinct treatment: https://docs.kernel.org/process/submitting-patches.html If you have any questions, please feel free to contact myself or Joel off-list. Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index ab4904cf2c0e..3f98e67674d0 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -1317,6 +1317,94 @@ eeprom@50 { }; }; +&i3c0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i3c1_default>; + i3c-scl-hz = <8000000>; + i3c-pp-scl-hi-period-ns = <62>; + i3c-pp-scl-lo-period-ns = <63>; + i3c-od-scl-hi-period-ns = <380>; + i3c-od-scl-lo-period-ns = <620>; + sda-tx-hold-ns = <10>; + + mctp-controller; + hub@0x70 { + reg = <0x70 0x3c0 0x00700000>; + cp0-ldo-en = "disabled"; + cp1-ldo-en = "disabled"; + cp0-ldo-volt = "1.2V"; + cp1-ldo-volt = "1.2V"; + tp0145-ldo-en = "disabled"; + tp2367-ldo-en = "disabled"; + tp0145-ldo-volt = "1.2V"; + tp2367-ldo-volt = "1.2V"; + tp0145-pullup = "2k"; + tp2367-pullup = "2k"; + + target-port@0 { + mode = "i3c"; + pullup = "enabled"; + }; + target-port@1 { + mode = "i3c"; + pullup = "enabled"; + }; + target-port@2 { + mode = "i3c"; + pullup = "enabled"; + }; + target-port@3 { + mode = "i3c"; + pullup = "enabled"; + }; + }; +}; + +&i3c1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i3c2_default>; + i3c-scl-hz = <8000000>; + i3c-pp-scl-hi-period-ns = <62>; + i3c-pp-scl-lo-period-ns = <63>; + i3c-od-scl-hi-period-ns = <380>; + i3c-od-scl-lo-period-ns = <620>; + sda-tx-hold-ns = <10>; + + mctp-controller; + hub@0x70 { + reg = <0x70 0x3c0 0x00700000>; + cp0-ldo-en = "disabled"; + cp1-ldo-en = "disabled"; + cp0-ldo-volt = "1.2V"; + cp1-ldo-volt = "1.2V"; + tp0145-ldo-en = "disabled"; + tp2367-ldo-en = "disabled"; + tp0145-ldo-volt = "1.2V"; + tp2367-ldo-volt = "1.2V"; + tp0145-pullup = "2k"; + tp2367-pullup = "2k"; + + target-port@0 { + mode = "i3c"; + pullup = "enabled"; + }; + target-port@1 { + mode = "i3c"; + pullup = "enabled"; + }; + target-port@2 { + mode = "i3c"; + pullup = "enabled"; + }; + target-port@3 { + mode = "i3c"; + pullup = "enabled"; + }; + }; +}; + &adc0 { status = "okay"; pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
Set I3C config in yosemite4 DTS. Test plan: Tested pass with aspeed I3C patches and I3C hub driver. Signed-off-by: MarshallZhan-wiwynn <marshall_zhan@wiwynn.com> --- .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 88 +++++++++++++++++++ 1 file changed, 88 insertions(+) -- 2.25.1 WIWYNN PROPRIETARY This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.