| Message ID | 20250218054405.2017918-6-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add GCE support for MT8196 | expand |
Il 18/02/25 06:41, Jason-JH Lin ha scritto: > Since GCE has been moved to mminfra in MT8196, all transactions from > mminfra to DRAM will have their addresses adjusted by subtracting a > mminfra offset. > This information should be handled inside the CMDQ driver, allowing > CMDQ users to call CMDQ APIs as usual. > > Therefore, CMDQ driver needs to use the mbox API to get the > mminfra_offset value of the SoC, and then add it to the DRAM address > when generating instructions to ensure GCE accesses the correct DRAM > address. > > Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com> > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 35 ++++++++++++++++++++++++-- > 1 file changed, 33 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index aa9853100d78..f2853a74af01 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -314,10 +314,22 @@ EXPORT_SYMBOL(cmdq_pkt_write_s_mask_value); > > int cmdq_pkt_mem_move(struct cmdq_pkt *pkt, dma_addr_t src_addr, dma_addr_t dst_addr) > { > + struct cmdq_client *cl = (struct cmdq_client *)pkt->cl; > const u16 high_addr_reg_idx = CMDQ_THR_SPR_IDX0; > const u16 value_reg_idx = CMDQ_THR_SPR_IDX1; > int ret; > > + if (!cl) { > + pr_err("%s %d: pkt->cl is NULL!\n", __func__, __LINE__); > + return -EINVAL; > + } > + > + if (cmdq_addr_need_offset(cl->chan, src_addr)) > + src_addr += cmdq_get_offset_pa(cl->chan); If the offset is just DRAM IOSTART, you could manage that differently in the cmdq helper as well as the cmdq mailbox... :-) > + > + if (cmdq_addr_need_offset(cl->chan, dst_addr)) > + dst_addr += cmdq_get_offset_pa(cl->chan); > + Cheers, Angelo
On Tue, 2025-03-04 at 10:37 +0100, AngeloGioacchino Del Regno wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 18/02/25 06:41, Jason-JH Lin ha scritto: > > Since GCE has been moved to mminfra in MT8196, all transactions > > from > > mminfra to DRAM will have their addresses adjusted by subtracting a > > mminfra offset. > > This information should be handled inside the CMDQ driver, allowing > > CMDQ users to call CMDQ APIs as usual. > > > > Therefore, CMDQ driver needs to use the mbox API to get the > > mminfra_offset value of the SoC, and then add it to the DRAM > > address > > when generating instructions to ensure GCE accesses the correct > > DRAM > > address. > > > > Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com> > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 35 > > ++++++++++++++++++++++++-- > > 1 file changed, 33 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c > > b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index aa9853100d78..f2853a74af01 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -314,10 +314,22 @@ EXPORT_SYMBOL(cmdq_pkt_write_s_mask_value); > > > > int cmdq_pkt_mem_move(struct cmdq_pkt *pkt, dma_addr_t src_addr, > > dma_addr_t dst_addr) > > { > > + struct cmdq_client *cl = (struct cmdq_client *)pkt->cl; > > const u16 high_addr_reg_idx = CMDQ_THR_SPR_IDX0; > > const u16 value_reg_idx = CMDQ_THR_SPR_IDX1; > > int ret; > > > > + if (!cl) { > > + pr_err("%s %d: pkt->cl is NULL!\n", __func__, > > __LINE__); > > + return -EINVAL; > > + } > > + > > + if (cmdq_addr_need_offset(cl->chan, src_addr)) > > + src_addr += cmdq_get_offset_pa(cl->chan); > > If the offset is just DRAM IOSTART, you could manage that differently > in the cmdq > helper as well as the cmdq mailbox... :-) > The offset_pa is not DRAM IOSTART, it is the MMINFRA subtracting offset. CMDQ helper is used to generate the instruction to the command buffer. Since this offset_pa is added for the PA put into the instruction, I think adding the offset_pa here is more suitable than CMDQ mailbox. Does that make sense? :-) Regards, Jason-JH Lin > > + > > + if (cmdq_addr_need_offset(cl->chan, dst_addr)) > > + dst_addr += cmdq_get_offset_pa(cl->chan); > > + > Cheers, > Angelo
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index aa9853100d78..f2853a74af01 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -314,10 +314,22 @@ EXPORT_SYMBOL(cmdq_pkt_write_s_mask_value); int cmdq_pkt_mem_move(struct cmdq_pkt *pkt, dma_addr_t src_addr, dma_addr_t dst_addr) { + struct cmdq_client *cl = (struct cmdq_client *)pkt->cl; const u16 high_addr_reg_idx = CMDQ_THR_SPR_IDX0; const u16 value_reg_idx = CMDQ_THR_SPR_IDX1; int ret; + if (!cl) { + pr_err("%s %d: pkt->cl is NULL!\n", __func__, __LINE__); + return -EINVAL; + } + + if (cmdq_addr_need_offset(cl->chan, src_addr)) + src_addr += cmdq_get_offset_pa(cl->chan); + + if (cmdq_addr_need_offset(cl->chan, dst_addr)) + dst_addr += cmdq_get_offset_pa(cl->chan); + /* read the value of src_addr into high_addr_reg_idx */ ret = cmdq_pkt_assign(pkt, high_addr_reg_idx, CMDQ_ADDR_HIGH(src_addr)); if (ret < 0) @@ -428,10 +440,19 @@ EXPORT_SYMBOL(cmdq_pkt_poll_mask); int cmdq_pkt_poll_addr(struct cmdq_pkt *pkt, dma_addr_t addr, u32 value, u32 mask) { + struct cmdq_client *cl = (struct cmdq_client *)pkt->cl; struct cmdq_instruction inst = { {0} }; u8 use_mask = 0; int ret; + if (!cl) { + pr_err("%s %d: pkt->cl is NULL!\n", __func__, __LINE__); + return -EINVAL; + } + + if (cmdq_addr_need_offset(cl->chan, addr)) + addr += cmdq_get_offset_pa(cl->chan); + /* * Append an MASK instruction to set the mask for following POLL instruction * which enables use_mask bit. @@ -509,11 +530,21 @@ EXPORT_SYMBOL(cmdq_pkt_assign); int cmdq_pkt_jump_abs(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_pa) { + struct cmdq_client *cl = (struct cmdq_client *)pkt->cl; struct cmdq_instruction inst = { .op = CMDQ_CODE_JUMP, - .offset = CMDQ_JUMP_ABSOLUTE, - .value = addr >> shift_pa + .offset = CMDQ_JUMP_ABSOLUTE }; + + if (!cl) { + pr_err("%s %d: pkt->cl is NULL!\n", __func__, __LINE__); + return -EINVAL; + } + + if (cmdq_addr_need_offset(cl->chan, addr)) + addr += cmdq_get_offset_pa(cl->chan); + + inst.value = addr >> shift_pa; return cmdq_pkt_append_command(pkt, inst); } EXPORT_SYMBOL(cmdq_pkt_jump_abs);
Since GCE has been moved to mminfra in MT8196, all transactions from mminfra to DRAM will have their addresses adjusted by subtracting a mminfra offset. This information should be handled inside the CMDQ driver, allowing CMDQ users to call CMDQ APIs as usual. Therefore, CMDQ driver needs to use the mbox API to get the mminfra_offset value of the SoC, and then add it to the DRAM address when generating instructions to ensure GCE accesses the correct DRAM address. Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com> --- drivers/soc/mediatek/mtk-cmdq-helper.c | 35 ++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-)