| Message ID | 20250221-mtk-socinfo-fix-print-v1-1-20500f30ef66@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | soc: mediatek: mtk-socinfo: Avoid using machine attribute in SoC detection log | expand |
On Fri, Feb 21, 2025 at 7:04 PM Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> wrote: > > The recently introduced SoC attribute info rework avoided modifying the > machine attribut but still used it in the log message on successful SoC > matching. It leads to print a confusing log about a board-related info > (read from devicetree) and not about the matched SoC: > ``` > mtk-socinfo mtk-socinfo.0.auto: MediaTek MediaTek Genio-510 EVK SoC > detected > ``` > > So, fix the dev_info format to display SoC family and name attribute > instead. > ``` > mtk-socinfo mtk-socinfo.0.auto: MediaTek Genio 510 (MT8370) SoC detected. > ``` > > Fixes: da77c2d3d06c ("soc: mediatek: mtk-socinfo: Restructure SoC attribute information") > Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> Ah... my bad, I forgot to update the log. Thanks for the follow-up fix. Reviewed-by: Fei Shao <fshao@chromium.org> Tested-by: Fei Shao <fshao@chromium.org> > --- > drivers/soc/mediatek/mtk-socinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-socinfo.c b/drivers/soc/mediatek/mtk-socinfo.c > index a15d8f854cefa90883377b47bbc16a7072ee21cd..ac7bb0cbff2df5e1c4033646cd3b644e67ee7f69 100644 > --- a/drivers/soc/mediatek/mtk-socinfo.c > +++ b/drivers/soc/mediatek/mtk-socinfo.c > @@ -87,7 +87,7 @@ static int mtk_socinfo_create_socinfo_node(struct mtk_socinfo *mtk_socinfop) > if (IS_ERR(mtk_socinfop->soc_dev)) > return PTR_ERR(mtk_socinfop->soc_dev); > > - dev_info(mtk_socinfop->dev, "%s %s SoC detected.\n", soc_manufacturer, attrs->machine); > + dev_info(mtk_socinfop->dev, "%s (%s) SoC detected.\n", attrs->family, attrs->soc_id); > return 0; > } > > > --- > base-commit: 964b0ceed00032fa0fa841fd61e5f315880a2d36 > change-id: 20250220-mtk-socinfo-fix-print-e83f3b3e50bb > > Best regards, > -- > Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> >
diff --git a/drivers/soc/mediatek/mtk-socinfo.c b/drivers/soc/mediatek/mtk-socinfo.c index a15d8f854cefa90883377b47bbc16a7072ee21cd..ac7bb0cbff2df5e1c4033646cd3b644e67ee7f69 100644 --- a/drivers/soc/mediatek/mtk-socinfo.c +++ b/drivers/soc/mediatek/mtk-socinfo.c @@ -87,7 +87,7 @@ static int mtk_socinfo_create_socinfo_node(struct mtk_socinfo *mtk_socinfop) if (IS_ERR(mtk_socinfop->soc_dev)) return PTR_ERR(mtk_socinfop->soc_dev); - dev_info(mtk_socinfop->dev, "%s %s SoC detected.\n", soc_manufacturer, attrs->machine); + dev_info(mtk_socinfop->dev, "%s (%s) SoC detected.\n", attrs->family, attrs->soc_id); return 0; }
The recently introduced SoC attribute info rework avoided modifying the machine attribut but still used it in the log message on successful SoC matching. It leads to print a confusing log about a board-related info (read from devicetree) and not about the matched SoC: ``` mtk-socinfo mtk-socinfo.0.auto: MediaTek MediaTek Genio-510 EVK SoC detected ``` So, fix the dev_info format to display SoC family and name attribute instead. ``` mtk-socinfo mtk-socinfo.0.auto: MediaTek Genio 510 (MT8370) SoC detected. ``` Fixes: da77c2d3d06c ("soc: mediatek: mtk-socinfo: Restructure SoC attribute information") Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> --- drivers/soc/mediatek/mtk-socinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 964b0ceed00032fa0fa841fd61e5f315880a2d36 change-id: 20250220-mtk-socinfo-fix-print-e83f3b3e50bb Best regards,