From patchwork Wed Mar 5 16:20:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14002966 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5978C282DE for ; Wed, 5 Mar 2025 16:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JfmWP206WT+CurGk+Y3Bm4wIo+djFMkIPFjf+mtIKy8=; b=m1mdu5B/7RpTs6sStkmZqlQ0pq 37o3wyHnBFp48zZLwq8m/C8UojHL6vQaNecOCCK8nF3P1br+cnTMWAy3EPMcwRfaIKEs+msG1/hSo XvQX3Ei3LpofWoFNIODEaQ/jsZ+7fux240lbpSDXCw4Nphjsp4q2t4INTUJ5SQFC0ZouMvaS7vTh9 0PlGRcHx4oU33ayNvgvplT8+lM2mzxSl00MA2WWncT5ZWGA+iDRjCgs3QNwUhmaQQ7oEqv5fmgN1L fHa8/oiyem0d0noBqhxhUB2jrA+T8GOZuPmkfQkTEoW8Hoaw6BcR/nNiB1NWZYvykLxQZVnkPmYoB hlP7+mCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tprZ4-00000008eeq-0mo4; Wed, 05 Mar 2025 16:25:46 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tprUN-00000008dug-0nho for linux-arm-kernel@lists.infradead.org; Wed, 05 Mar 2025 16:20:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HBuTN83YIA6kJDP4EkBZ1ZoWDoG8qjQ7d3gFSrTZogp0vnRjpae56+DaRTPvHC8l2ONZe7E2IfSMJmb3XY0TqZ2XCymCVCenVz0MMnBpJ+y2hnnakStgxijQCBNvvhHzw4Gu6KC3Id8E3MZ9sMsYoamsRcm/FNPurHUk3euk2xI8NakeMYh5kG3/zcWv3OR65L112ARV5hDwRprjCWBa74e1Duz8m7SSk3RcIUTTg2Kn6p1EgxG5xBoJndVm62VZzu8xdUklgJI5lQqOWeaAaeyPdXWvGfRcyCXNK6gdTgVME2pVrasnm9nUb6xx7VOOc9uqtId/KlQPG3VogHIKzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JfmWP206WT+CurGk+Y3Bm4wIo+djFMkIPFjf+mtIKy8=; b=MDfRgymIsXWDRtTVXaCO7Vtg7DW1KsJ4SHHLjr8+6gttvBkCJ9DDrb/YgrmdbWI/Ll5HkpHm9jWzUSJUKLp6X43i4b2VqouvC2aA2XM+/F5e1G9S/OS5Z2l1PBiC2qUDmhuPQvehFjAeTYcqRvsyTJN3GT+A+L9N1tdJGp2eBBgjfllpWE7UW5YRmqjHjl0Kbj4PQoKTjco8aJiDvV/XmAu47wYzlS3Rs1fF4ezQt/zYbB+1f2A9myHa70MSNaHg20AhiTG91SwpD3rdkrW4e8nOwFSzIdWiKXRCxGq/gU7wNYVbDhCKisxNJ4j3VvutZ9jAH5XNBci2+n4Ld21p/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JfmWP206WT+CurGk+Y3Bm4wIo+djFMkIPFjf+mtIKy8=; b=Waxv3JY6d6rtH0wC0uu9eMplRRrpo6G4z78CI0TxrFivLQxgijfbidjpm1L7ot2jNWWdeW/+ArLGzoGHX+OUdA2aRlEnZ1VizcDDSGocY8VgXxF5Z/UJ0fZiZz8BKTuMM93t4484hxm18i/CN9iwfWyYV+muQf7Ti82eo8G68jWAl2hKHP/fwP1iuf74RR7QQo3MAIj6wqbxGb7at3lpNtOB2YH5bIt5uIgwjWSIjIC7HX3R3qZdugzATUQo4OQzn9/zSQj7708Tz/7e8ozgAH9DnCX1hX/NtqbYbWmn+Be8VRtHzpZn165JTM2jsx4fL5Jkj2EvQYxonkmYOMzdUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by DUZPR04MB10039.eurprd04.prod.outlook.com (2603:10a6:10:4d9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Wed, 5 Mar 2025 16:20:50 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8489.025; Wed, 5 Mar 2025 16:20:50 +0000 From: Frank Li Date: Wed, 05 Mar 2025 11:20:23 -0500 Subject: [PATCH PATCH RFC NOT TESTED 2/2] PCI: dra7xx: Use use_parent_dt_ranges and clean up dra7xx_pcie_cpu_addr_fixup() Message-Id: <20250305-dra-v1-2-8dc6d9a0e1c0@nxp.com> References: <20250305-dra-v1-0-8dc6d9a0e1c0@nxp.com> In-Reply-To: <20250305-dra-v1-0-8dc6d9a0e1c0@nxp.com> To: Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1741191638; l=1775; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=rMAwxY81r5cnoE5s4hqm3gUf7WOPOk2usevJ9Cbe3Fc=; b=mVYiylEvT4CiDbtNNM8GwKGYWGNrPDwNAn3/WiYpy2srJ6Hqy8dXA9gQf9b2+IpcGeLRk6DsH Qt26IZy+PLyBb9rrBngxXFG1rFGWs99tYuhKQXOelOxavGZ5Yzs4pZ1 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0153.namprd13.prod.outlook.com (2603:10b6:a03:2c7::8) To DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|DUZPR04MB10039:EE_ X-MS-Office365-Filtering-Correlation-Id: ef61f8d1-aa43-44da-a1ee-08dd5c01b1cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?GOo1euzYQ3Y5PeCdSC/gcPAvDd9EfQw?= =?utf-8?q?WNWKHsAnri8l5nhz5hnw712lz7Iv8ZzB7KXveRirxZq+155dsiUG7jOLWissS8CRa?= =?utf-8?q?GsKF4RRtgswVctG7MuOcDvMeVOkmIhPMunmO4Otg1T9AwJVkdi64M1QC9Ot/kI4sP?= =?utf-8?q?Ul/oN82P8D1V+rHLCOviGKJy8HMsYRHhQR6zyVkvUeHDlGkvzU3Ir8uNwyiyYmyY1?= =?utf-8?q?22+UTQXC93eJWlrgEpOnWWG3HqK9Dme7xxbLeF6C2ShYijar8Rge+w2nDk9oJSniA?= =?utf-8?q?Nb68HYyHBsF8uNEfh9KgP7W5+C8XoGizbW/KU9gjhM5H2WEsND2b77zxomH4/fECs?= =?utf-8?q?E3Tf2DFEGlcPLKCXblfoGtru3LzkHp6Jpw5zE7tvPgn2HOXMWKwfa38YAki+BsrSX?= =?utf-8?q?EHSPObkhwgaFJFqHd/ve4tzJ89jSxWjp/Cwa3aj7KVhwiv5B8r/MLZNUQhbgyRs1o?= =?utf-8?q?BrS0fWbqpCbBxU47T3dptETXjiQznqYpXpG5tz4zFsqeGqL2p7cIO43Lli7N8hr88?= =?utf-8?q?WxCe8cp3YwiuLNNcoLRyphgND5em5hSSzjTMa4zvCVPIwsVZ/ySQRARPzTDp846XV?= =?utf-8?q?qgPLD6EbWol2V4Buod4b8YgBN6+WhilOzOrvlEvDZqAXl1//O29wKajy/Nb/LlPBq?= =?utf-8?q?GcKkw6u1rbwS46PRtHEiPsawvze0oDnx8CbZeop28iUWBiahTQLXx9DO18ERbSbaK?= =?utf-8?q?VxHP8i3VxrYetCz9GFNBeTBO1pLAeulL71O6a7TN2zCGz8Kc8cwxjrBQYXWaChtIs?= =?utf-8?q?7VlTmffEKv2vKiTY+af6fYkpjO5nm1yY9zmdIblzTuGK2fFTluMyz1n9HtzN1K7hs?= =?utf-8?q?J2uRoypOjEODk3S/92gT57FRMsRbvs7kVhmWHs7T3kBy2Oyf0LvNlk0NltWn/fQ34?= =?utf-8?q?G9eW7MVrAp/3N3kfvp3eEELhOUgPB30tHorIBC1mtf9OyeyDd/zXZuHEFN73Db6dD?= =?utf-8?q?dXQtHgZ9UbiF0xbjAIGh3dxBKMbcmlrFE0nYGFoTp2u09oIumRjAI87XhPDtVtDt5?= =?utf-8?q?7G8YkyueRhI7bGhhk1GT9j1eKYlQ+7xCMEJ+hlZ5U9Lz8U13xWprb6gvrQwmfM0du?= =?utf-8?q?ClejGweCKjEFgWIcR2zikeWaLEAbZePyzQAWV6ZKM+JJNC//os2KUnaIGRwbKys6E?= =?utf-8?q?TBX2Ed65eudZAf2Hhisf6f6Pi1LZX+2BAm7kXwLTCoY9i1vQzV+0IC6ldUGhHeg9G?= =?utf-8?q?Ng6gSmgb0RQmnVVQM4hodZGSNXGOAzUeiI6m2qmTDsWyv+IzqbV7CPisqvqzogXSD?= =?utf-8?q?W1TcNN+BspDpwHovo0lAtH50ot/kPvstHoupLyQL+f5zOcllhtW+VywVxUAkI/isK?= =?utf-8?q?wAh5oPhJpVyqFii8SCHjnBCnQXxelML4De0pcXwD2JDroYt8FfTHTWD6NM7fFIBxA?= =?utf-8?q?bpBfoJTbRED6I4ey2scnejgjqY3qgGyIQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?mtDb9qkW7VwCyeHY7zwFwAKJ6KQo?= =?utf-8?q?4S0deSKkfO2HrTevBomFbRf8Pm1GhyOAIgml62kieSeyxT289+VMlFFWWpRo42EX5?= =?utf-8?q?JUKX4rBTYjF2iRJBAIHdq1wH4mDUvz21wLiBVCnMkaQY5laSMosBh0tAVxTCMIN0J?= =?utf-8?q?k1uy6682hWvJURy6wEAsM+JGajOx6SlJR/aFutQxq/h+R24HMdbLY6jjF3z5Y9kcS?= =?utf-8?q?E/jTVVyDCLXU1vtfxA6LsYWB6CH4W26rCuQEFXB+mfakMWKGabze558iHpgXQx/lN?= =?utf-8?q?wM0fbKJySrNYN2w4iynw5PVI8CzfxAXpAOxdBWMEdhCWBrn2AW37ShnUq9GIHeIX5?= =?utf-8?q?HCW6tU1b3UAvGC3HKJYnrPgKeTytPEHieUF1zs8fpEnFZvC+voSFwpMahkh94qGeR?= =?utf-8?q?34q3ZRGsnXfxEipexUqWsfNfOqo4/K+mG9MVX4/TaVzccBfWa8wKctF5+rRpS1OVx?= =?utf-8?q?Kk7PhfoyNUrg87Ntz1b8sREeB9FYcDOx8EUz6F3kJ8Hfpg+rVUzaMm0QIi9kkud4E?= =?utf-8?q?YJwe0Wy35VRTzWaSXgG9kZ8xex2PUtzF543mhPDSUT8MhS7vZXNDtDQvwRe1fMolo?= =?utf-8?q?t2cpLHqRLhsY7p2/bXSysYyvCv5EOqvDc3wl6U0JlLtJajne7qEIw454BdgF5KhHV?= =?utf-8?q?97awdgcpBsAkGTVk074cTv9zMWVHWABCizUkBQxE0z9JrPz8zF2Ag8Zk5gvIXIh0E?= =?utf-8?q?6jq51nibj4Q7iWGHvRGhU3wJ59ufR2NSuta9yN5C/0TBQTzlivRhucvyagyqQoF//?= =?utf-8?q?C8bsD8uV2gy5CLVQnNkVPeH5RHN7tJkqnHST5a73g0V9FZLS/iKBKdoZvcZsZoUMN?= =?utf-8?q?IS3bLYbdMzIWtZGB9FV9SZGk6Wr+0oLtXcO+UecacrkjLXwrODQIB5Gq03FV2CBj8?= =?utf-8?q?ciMD+Bm3I4GSdJv+uTGv0No5b4nOFMS4McxQDnnHEu4TTq0x3hup/IOsTcB1wi2/3?= =?utf-8?q?xA1KyZ9vxzf3WXSUWiAj4Ke1z7zvI64IGHVaAGFKCRq1qWNGRb6u2Y1WMn7dV6oZT?= =?utf-8?q?5IBxXqa0k5E70PIZEUufOziddjOVNjgDqns9tNtLXX/mEXX7Va8q1YgyS5LAqZVOY?= =?utf-8?q?toY5V69ZJV+oMsDbuxbXYroMOJ3+7JiU0L2aiwBf1jPbVzQB+08TIyYifsV0s+eCi?= =?utf-8?q?9MoIh8/k1jzkNShq1+HQRSgMPOqISdP08bO+r8mj95qHWEnQQDScRozgOO0Ud2UNB?= =?utf-8?q?R99QFYOc/cVEFAImxSbExIYvvw8U3Q5DfgtcoSR1UkEsdVqTDuFM8qAuqtru1crgF?= =?utf-8?q?nJNohjzB7c2mj1laRp5Hc3XcTpolkBJ81SoRj14LQLhUAVzDjEIKeWY6expvoAze7?= =?utf-8?q?1hsOKAOFjuLncQMjmMG6XGOabmYkwoMoH+JZg/cK9ZSC+9DdjNnUh95LmEuAkSSeN?= =?utf-8?q?GjOAjBnIC5TTV4wAtwUZ/xEIK25bUuFURWpKKfsKCULnNXE2sP4PDqti5IxITse3i?= =?utf-8?q?k2cJJC3A8At500sJTnulem0gEF/SEdTx4+N0V1Cst1RU0F8wQh9eKLe2vey2JFou0?= =?utf-8?q?+RxoJWx0sy26?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef61f8d1-aa43-44da-a1ee-08dd5c01b1cb X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 16:20:50.6335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gH5tiyH7DaLstIFzNUip/La2io+Zq2hpND7SyrQ7dXHpO+sgd2AqbijUZs09wVhaDG9iBEJ1hLWYq0QOyNK0jA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB10039 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250305_082055_235901_4DAE18BD X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove dra7xx_pcie_cpu_addr_fixup() as the DT bus fabric should provide correct address translation. Set use_parent_dt_ranges to allow the DWC core driver to fetch address translation from the device tree Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-dra7xx.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 33d6bf460ffe5..d6e0bf67a07b3 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -72,7 +72,6 @@ #define PCIECTRL_DRA7XX_CONF_PHY_CS 0x010C #define LINK_UP BIT(16) -#define DRA7XX_CPU_TO_BUS_ADDR 0x0FFFFFFF #define PCIECTRL_TI_CONF_INTX_ASSERT 0x0124 #define PCIECTRL_TI_CONF_INTX_DEASSERT 0x0128 @@ -113,11 +112,6 @@ static inline void dra7xx_pcie_writel(struct dra7xx_pcie *pcie, u32 offset, writel(value, pcie->base + offset); } -static u64 dra7xx_pcie_cpu_addr_fixup(struct dw_pcie *pci, u64 cpu_addr) -{ - return cpu_addr & DRA7XX_CPU_TO_BUS_ADDR; -} - static int dra7xx_pcie_link_up(struct dw_pcie *pci) { struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci); @@ -514,7 +508,6 @@ static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx, } static const struct dw_pcie_ops dw_pcie_ops = { - .cpu_addr_fixup = dra7xx_pcie_cpu_addr_fixup, .start_link = dra7xx_pcie_establish_link, .stop_link = dra7xx_pcie_stop_link, .link_up = dra7xx_pcie_link_up, @@ -712,6 +705,7 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) pci->dev = dev; pci->ops = &dw_pcie_ops; + pci->use_parent_dt_ranges = true; irq = platform_get_irq(pdev, 0); if (irq < 0)