| Message ID | 20250305130026.642219-4-faizal.abdul.rahim@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | igc: Add support for Frame Preemption feature in IGC | expand |
On Wed, Mar 05, 2025 at 08:00:18AM -0500, Faizal Rahim wrote: > When the link partner goes down, "ethtool --show-mm" still displays > "Verification status: SUCCEEDED," reflecting a previous state that is > no longer valid. > > Reset the verification status to ensure it reflects the current state. > > Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com> > --- > net/ethtool/mm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c > index aa43df2ecac0..ad9b40034003 100644 > --- a/net/ethtool/mm.c > +++ b/net/ethtool/mm.c > @@ -415,8 +415,9 @@ void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up) > /* New link => maybe new partner => new verification process */ > ethtool_mmsv_apply(mmsv); > } else { > - mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; > - mmsv->verify_retries = ETHTOOL_MM_MAX_VERIFY_RETRIES; This is not what I requested. The lines with "-" here should have never been introduced by patch 02/11 in the first place. > + /* Reset the reported verification state while the link is down */ > + if (mmsv->verify_enabled) > + mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; > > /* No link or pMAC not enabled */ > ethtool_mmsv_configure_pmac(mmsv, false); > -- > 2.34.1 >
diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c index aa43df2ecac0..ad9b40034003 100644 --- a/net/ethtool/mm.c +++ b/net/ethtool/mm.c @@ -415,8 +415,9 @@ void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up) /* New link => maybe new partner => new verification process */ ethtool_mmsv_apply(mmsv); } else { - mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; - mmsv->verify_retries = ETHTOOL_MM_MAX_VERIFY_RETRIES; + /* Reset the reported verification state while the link is down */ + if (mmsv->verify_enabled) + mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; /* No link or pMAC not enabled */ ethtool_mmsv_configure_pmac(mmsv, false);
When the link partner goes down, "ethtool --show-mm" still displays "Verification status: SUCCEEDED," reflecting a previous state that is no longer valid. Reset the verification status to ensure it reflects the current state. Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com> --- net/ethtool/mm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)