| Message ID | 20250306-rk3576-hdptx-phy-v1-1-288cc4b0611a@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | phy: phy-rockchip-samsung-hdptx: Add support for RK3576 | expand |
Hi, On 3/6/25 9:29 PM, Nicolas Frattaroli wrote: > Despite the compatible already being listed in the bindings, the PHY > driver never gained explicit support for it. This is especially a > problem because the explicitly listed PHY addresses need to be specified > for each SoC. > > To solve this, add the compatible, and a PHY config, with the address > gleaned from rk3576.dtsi. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> > --- > I thought this must've been already submitted somewhere, but it wasn't > in linux-next and searching for the modified file on lore also didn't > yield any results. I guess this slipped through the cracks, and > torpedoes HDMI support for RK3576 entirely until merged, so it'd be > great if this could be merged in time for 6.15. > > Let me know if I'm just very confused and this is already handled in > some other series that's about to be applied. I'm not aware of this being submitted as part of another series, that's probably because commit f08d1c085638 ("phy: phy-rockchip-samsung-hdptx: Don't use dt aliases to determine phy-id"), which actually changed the approach of mapping the PHY IDs, has been applied fairly recently. Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Cheers, Cristian
diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c index f88369864c50e4563834ccbb26f1f9f440e99271..fe7c057483563686b8076cf2ce562440cfa6fe55 100644 --- a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c +++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c @@ -2017,6 +2017,13 @@ static const struct dev_pm_ops rk_hdptx_phy_pm_ops = { rk_hdptx_phy_runtime_resume, NULL) }; +static const struct rk_hdptx_phy_cfg rk3576_hdptx_phy_cfgs = { + .num_phys = 1, + .phy_ids = { + 0x2b000000, + }, +}; + static const struct rk_hdptx_phy_cfg rk3588_hdptx_phy_cfgs = { .num_phys = 2, .phy_ids = { @@ -2026,6 +2033,10 @@ static const struct rk_hdptx_phy_cfg rk3588_hdptx_phy_cfgs = { }; static const struct of_device_id rk_hdptx_phy_of_match[] = { + { + .compatible = "rockchip,rk3576-hdptx-phy", + .data = &rk3576_hdptx_phy_cfgs + }, { .compatible = "rockchip,rk3588-hdptx-phy", .data = &rk3588_hdptx_phy_cfgs
Despite the compatible already being listed in the bindings, the PHY driver never gained explicit support for it. This is especially a problem because the explicitly listed PHY addresses need to be specified for each SoC. To solve this, add the compatible, and a PHY config, with the address gleaned from rk3576.dtsi. Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> --- I thought this must've been already submitted somewhere, but it wasn't in linux-next and searching for the modified file on lore also didn't yield any results. I guess this slipped through the cracks, and torpedoes HDMI support for RK3576 entirely until merged, so it'd be great if this could be merged in time for 6.15. Let me know if I'm just very confused and this is already handled in some other series that's about to be applied. --- drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 11 +++++++++++ 1 file changed, 11 insertions(+) --- base-commit: a03be51d680391ba113e2e22b38743c276b6e2fa change-id: 20250306-rk3576-hdptx-phy-4ef6630166cd Best regards,