| Message ID | 20250307093309.44950-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: rng: rockchip,rk3588-rng: Drop unnecessary status from example | expand |
On Friday, 7 March 2025 10:33:09 Central European Standard Time Krzysztof Kozlowski wrote: > Device nodes are enabled by default, so no need for 'status = "okay"' in > the DTS example. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes in v2: > 1. Drop unnecessary full stop in subject prefix after ':'. > 2. Add Rb tag. > --- > Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml index > 757967212f55..ca71b400bcae 100644 > --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > @@ -53,7 +53,6 @@ examples: > interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>; > clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>; > resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>; > - status = "okay"; > }; > }; Hi, is there the possibility we could make dtschema as invoked by `make dt_binding_check W=1` (or W=2) add a warning for examples that have disabled or explicitly listed status properties when not needed? Or is this something better handled in, say, checkpatch.pl? The question arises because dumb mistakes by me like this should ideally be caught before they waste precious maintainer time. If it's best handled in dtschema, I can look into working on that so you guys don't have to do even more work due to me. Cheers, Nicolas Frattaroli
diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml index 757967212f55..ca71b400bcae 100644 --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml @@ -53,7 +53,6 @@ examples: interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>; clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>; resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>; - status = "okay"; }; };