From patchwork Mon Mar 10 20:16:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14010652 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C2B3C282DE for ; Mon, 10 Mar 2025 20:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+9m8NiOYA2VGSMRubWfPC/5dxLj+RPScFITjZUVIVjk=; b=jd0pqB3NnT/8vy8e+OtgkFyhxR PzA1jskHpD45SqNdmU7xfSFHimV75638r4l9/sh2BcGOCphvd6azUibfpIAY70Gyb8MsBbT2KRqm3 aULSujltZMOoHP7On2nt2+GgpmkpXOhwF7DDPa9fvSNwt2nucFk6NkYMlDhWHaRpMOoqD+Ub/cHMq qfOiwGGcCiGxbTUffT3lhxfhDt5xN31RwSY/gnCP20qlH3+7H7WDOyRPcAQdW4Nn8ga8fHhfLGw70 /E511CXgkpFNQk4p9drEuvq1XvJtvlVB7v1xrj+5HOpLHl4CVjGkX4lfTDOGaWZImO+r6IZhSX+n7 AZC50paQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trjrg-00000003tRt-3ku4; Mon, 10 Mar 2025 20:36:44 +0000 Received: from mail-northeuropeazlp170110001.outbound.protection.outlook.com ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trjZZ-00000003qe9-0JAg for linux-arm-kernel@lists.infradead.org; Mon, 10 Mar 2025 20:18:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wOTtTd0nU3r9m2cnn4UamJAzXZTckMkP1bKFjuGKOvultd6+/uLDG+fWI2YjSTDAwfb9lbGwYT/30N73l8h/a/sZXQlQf/UvTxc+zA5pHkd293s6RFocEGcxlcUcoYBD15wR8uWn5PjKIQnXJ9kHFZ9vd+ImJ2UZhkUq8CehglInJw0cVwjx4SRWPBzmL77i07hT677cXAHYJTSxGgXx1FShEx0DByRb/mPAAxzwv5kH11cmDGfoKtlkFhKi7FnRnmCftzGhxvfotHlnbCJH+s0TTJzd0iS34b+OH3WIwYeF/V93yNfUf3vkj/U68gZM3POaIuF7OAtyPYtq/xtyJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+9m8NiOYA2VGSMRubWfPC/5dxLj+RPScFITjZUVIVjk=; b=bRResrOTKWXSNAkK5J9HIL1lX8MeBkwxsauVo4bktPCZ4BO/CV3569oCHdCPZ70A7iN3zrjMn8XNuof/7++MkinJVQdMvzWCkA3Cm2V1/LCi6auDrw+KUk6SaKO9PZhkloTqkDTtOcoemn//jPwwfa4ETs0166Dvr8kfR7q1hypAKrQAIuWipVTNHVyFf9ZlKqJgw/HbFELv9VS2lTGiobRgAL1odwbVjYt7rrCjTgqBwrmUGajIGyF4dnj7ZPeD0NSN5A+7osT8UfLvLpiTpHIv4KSWHFebYLXLnpEVJimR4baqnvZ7UKVzSLRrmHflSuuwedB0SCtXuUPcNAhcwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9m8NiOYA2VGSMRubWfPC/5dxLj+RPScFITjZUVIVjk=; b=iQonARVci6IRUQOpwmVACT2IsfHhGA+Kq5XE3QTxJSrnhdOLpoBn6ElC4i7+Zq5Xu4yEiBC1p681wAeuREdePBw3VzLorcpxyrG56EGuVROWZ91oZu56BaV5iq9+s0YBuYgcyLpV/N7zZuEkzUg2/IixE6qZrmLZmFeteFJEsTXqltqEOR3c19riYZ7HogNRnQbDiEEXymDDQuP31w4WHItcINroJic3/c/AgSBynjgRLV/AQV8W5Ap4YtQvtJrSDe32DPXli5knpx4VRzYN+1vVYzfw6s1z0+F+VQtvTy2wevBC0IebBN3/bR0TcuPeuwIBzU9jE0HmWOsVAGYa+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS8PR04MB8261.eurprd04.prod.outlook.com (2603:10a6:20b:3b1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.26; Mon, 10 Mar 2025 20:17:58 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%3]) with mapi id 15.20.8511.025; Mon, 10 Mar 2025 20:17:58 +0000 From: Frank Li Date: Mon, 10 Mar 2025 16:16:46 -0400 Subject: [PATCH v10 08/10] PCI: dwc: Print warning message when cpu_addr_fixup() exists Message-Id: <20250310-pci_fixup_addr-v10-8-409dafc950d1@nxp.com> References: <20250310-pci_fixup_addr-v10-0-409dafc950d1@nxp.com> In-Reply-To: <20250310-pci_fixup_addr-v10-0-409dafc950d1@nxp.com> To: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Niklas Cassel , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1741637834; l=1041; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=+3MidV7XoojBAWFebcj1RI1TKBDTvuas/ORdvq98PK0=; b=f+c2fQFST6BaETKVDccQMUW8c/KeNmeOjqrdGApCWgINs63xwbb2manqvo6vZgsCXUr+JqpKe ZegMovj99rlCj5ux1p83vd/aHZJTQuYBTBQuZwB/Pff4Q+Vkd5ddBF4 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR08CA0058.namprd08.prod.outlook.com (2603:10b6:a03:117::35) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS8PR04MB8261:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b0f55a7-98af-4b9a-c1f4-08dd6010a673 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?mxghR2zO5GstMJctxtdSQu/7EyzdTwU?= =?utf-8?q?c630t758rOs0waBAT2RvWF9Q2yDTJpQX/x1wnlH48AsPCnRxYNA4AAmXtp5HAJser?= =?utf-8?q?3LmiDF7qQi4WfMnDW8hLP25GyRK0lWc+dfmHm4SrlbLItRj714JzbL6m/JH+wOdQb?= =?utf-8?q?3OCPD6B3HQK44I5qSEgkRysydGXMjVGMukoMi0xRaP5cueq13OR0WBk6AKOrscmCQ?= =?utf-8?q?wpRFv8X/mMM/JXzx5X5OySj+i7fjmGvZJFtPRk6m6E9Ta2EvQlP080h0wgF2S5WY1?= =?utf-8?q?0NpHdkyrHeuni31oRO+k0LXba2s56YzwydDb2NGngVzeSYsm/D3ijUqPB/FQcHW9N?= =?utf-8?q?DcbLRKFstWIecxA5FVn1b2DtAVJ/YvsgKaLCSzx3EtExmQxbsLGe2fijNRsyAtDjd?= =?utf-8?q?WsNdV8NmeLmJLEOtM+nNCVw4cMw3PWB+rE1IoLOECgbwpjf3AS86yJd/FTK+fxrCj?= =?utf-8?q?zgedvIOcrTj/lhSbqMvxEy13w0hHyyQEP/yFu1kZO2enBCn5TDw+Dncj2nZ87eGW4?= =?utf-8?q?SGX+Fje5+A/Y8UZXzrX/o5Jztyl5ufX7fmD/XErjkJCUaLEjiu4bzjBBudv7ZYSh5?= =?utf-8?q?+UPPTPBHdvAiv6ts66WQkKWbKw43OHf8olBRRdZdJG+Sx3l/y5anidpoqNNVuvBTu?= =?utf-8?q?JUC3XdXKJjObjMVPSBYWI2sr67OmxA9Jn6PPJJjJRUZRBzcy0bGIEbL+/Xm5W/mpz?= =?utf-8?q?UdpOx7BW+P0laHN2Pwq51Hombon58WBnqI3SmYCLxk8DeJy85OX162YJ1at1O5BDO?= =?utf-8?q?B4aMj3o0FEl23npmqmtGQF8UjbNxH0M0FqYv6SHYUn69Nqqfbg7LotKFobJOFqUDK?= =?utf-8?q?LXpiv9ak6xLm1cnh53fFQCnG+QnMkjypMuuHIjuCLblpwPi4QlYHoY53ttNZpt8CI?= =?utf-8?q?b0Ea7IHH5plyncBKGERT+4q1a9hQAFzL1h7OSNqPK7udXj/iPGaO07r8VUVbU4BAD?= =?utf-8?q?tvrsQxoNpuPjmOUKyHMtpQq2Z1jXSTxOKeZiIh67JpjM1hR0qlYTAF2UJ061ukcAR?= =?utf-8?q?RZdd9vi8NU83cm4ng/5jzOARkh5WPN3k4sQdiQq/SLwEZHl5gBKcanIrfHG/ioPkT?= =?utf-8?q?egIQUX34vlxdvX65VaI2IHppgNXpaS7Dg5NYmneKaqvxufxAKOF1m4rebB23QBZW/?= =?utf-8?q?ec40jcfjtXOtXV+6m/uiPjIpuyTdTr2L7RuK/IkCbceAYV1Kz63m2OX8mj/P2V8W0?= =?utf-8?q?CiVUFLN9rGWdS2XAGOTmffT6bTJGG1YFxM8Gc4vVYTM56lMRPGilBuiPhetNJLjLY?= =?utf-8?q?tQER5gktMcf4D3Zm0Q7WB+af77loVRIwnGF6Kmq2eBcaAwzAOHj1L9V0mItiOcs5O?= =?utf-8?q?UJ3ds0eotikBcGwHO2YvwicMXCQLqeosyO0TfCUamAJrM8nDidClv3RPhrnQqpTA0?= =?utf-8?q?xyPBR6K2GqtrymzAvRrpN6vV9RdKZ7VUA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Wqr4CPhiVbqEv5qh+HnFtF0+EuDA?= =?utf-8?q?d2cCK1GkdzFHtOGzjCcky6Ywi8tW7gXZYbz014jbE+1shXYI9fozWkTdEj3+k2EKP?= =?utf-8?q?tlOO7V42Q3rbq5VzMxT970pAvCQzCGWgxkDmacH6IqswxvbG2yafPvd/F9mZf8gVQ?= =?utf-8?q?9WznsYnwyi7hUdmsJ4pHou845Ckxuj/ThtZP8plALm0J8FUpR2XxKWU5N/Jl/Fz39?= =?utf-8?q?Z3ERnI+zxjlYchsMxQbZIKQnvqtE6jxD1NK6q1dsC81hdw6Esa0CRPK9fE7nriwjS?= =?utf-8?q?0ZBS1Lb01ygPI1cY6+AigZFqruTvR5/XjlfyFaRdKeiMgoUhpbVoIPUYpMSado9ts?= =?utf-8?q?g+L2+QKFB3Hj0d1spCthcGPk9ogFS9vfQHWUFtvls3hEm7eLCvbRTgMhkfzIKeCru?= =?utf-8?q?DsR0N4rmePCnXTf8oqPlDZOE6g5lnk5eQf1tqhXrz5HFZ2weFtTPITU3EIos7GULT?= =?utf-8?q?LycukYyppP/CCQ0UmDZs4GaKhonPqsGIxtjzOuU62oSOJXbHQKEIzBlideKtbG/Jp?= =?utf-8?q?PvqKVkdbltClInS6W9jmdMwzlNn6Ywu7M+PSLuHLxsc67ngXufHJ4YFQH+jPubAV8?= =?utf-8?q?8DaYm4BNUsa04IEJQPbTA5rSA8VOlbtjFfVumZdoR54BCkR9ibZ5t5eqnTSnbrysE?= =?utf-8?q?1Nj7UU+bUV4FkZaJxhTgO3HiCWKxUto8CN2LnHLLDNKSIN3C63L9rSaurOijYriVh?= =?utf-8?q?McmMP96iU7jg0i10Cj+9+2YKMlcvLcEn1jK4av5PGEBj/Hz0ToMjMWEJJEFyJH9/e?= =?utf-8?q?NM9pnI8JlMCOaqytLyZQL7rdy448Eae3US6XpTT7QG4CvshJSF0njY6SuzaQP3rR8?= =?utf-8?q?iL8A23RQS9HTxtvKFEpAb4dSqiyjveqYrNEyfV4GCt8XQ8o083ohCQb52lN1OESm5?= =?utf-8?q?q5TYWSJP3oPEjfilcfEcKvbzZI2MavFmUPwQ+B+L6dY/+xMXfC0b7ucLfU8Inx3CQ?= =?utf-8?q?7cHMdknU5CyfOr2pqpBXt8biZToHk9IxCeF4aTnhx76HZUmIljfEJvP76TCwDHEab?= =?utf-8?q?SmBrMt/UCmhGTcCx8KAhiZ336w2qQGyCwVV1l4sHSueFvMa+N1uBH8NkTFvw6zer7?= =?utf-8?q?5VU1T9iDkhp29izbdPbqlWIdFlKtM5BmbDOy2lBbD0+rcSfHDxPqcv8nGRHEVWIEp?= =?utf-8?q?DFatv1NW+TmEDrB4qskVEWq0pxQtR/upzZMApq8UHwo5dxjC8wuObNVDENcE0NLUj?= =?utf-8?q?Po/OsR8zwn/alkMT6X9bWhknV28duA92h2kp+jktfDxXxrbrWzrGXagPC0JIoWoNd?= =?utf-8?q?f/yjW8r5hvrM4xmnzFMuz30Uo2QBnubovtOolKA2fW8hEF+VviHKgHz0Dj8Z34/3l?= =?utf-8?q?e5IchLoxZKCJN68rVcNj6jb73ntcYQAKrLUYBDfDmcf4S2lt9qOg8caw6F15UMpJj?= =?utf-8?q?PMN1GeCXGEC8ZRzDXdlyAE8DUZE5spHfo2a+9gnbMQ43c/qZcUvKmpITZHtaSy+Ya?= =?utf-8?q?04vCuROFtH79SoFvGAdOR0s1/I4wQsGJ1fEZ43olnrmzvr0W7XSLyM0vvpcKch6LY?= =?utf-8?q?KiGi2qCv0Ga/?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b0f55a7-98af-4b9a-c1f4-08dd6010a673 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2025 20:17:58.5878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dZebD/H7/s3pWpW3eT35O0Etstas4INjjXwOh0vlWwTbnc69VOLVeQ5D1KoGdLDG6M3MtvPRViwWOqFnA4CsNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8261 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_131801_120312_44EB7014 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the parent 'ranges' property in DT correctly describes the address translation, the cpu_addr_fixup() callback is not needed. Print a warning message to inform users to correct their DT files. Signed-off-by: Frank Li --- change from v9 to v10 - new patch --- drivers/pci/controller/dwc/pcie-designware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index 7061a7ec08cb2..3ab85dde22ce4 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -1125,6 +1125,8 @@ int dw_pcie_init_parent_bus_offset(struct dw_pcie *pci, const char *reg_name, fixup = pci->ops->cpu_addr_fixup; if (fixup) { + dev_warn_once(pci->dev, "cpu_addr_fixup() usage detected. Please fix DT!\n"); + fixup_addr = fixup(pci, cpu_phy_addr); if (reg_addr == fixup_addr) { dev_info(dev, "%#010llx %s reg[%d] == %#010llx; %ps is redundant\n",