From patchwork Thu Mar 13 15:38:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14015337 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE92FC282DE for ; Thu, 13 Mar 2025 15:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DZfCysn5S4+XnUcPLACOvSajhoolaGVZluObBWMpN4A=; b=a0M3K8eddblXKhOBmveb+Tpvit LEmw//grh7zcIRv7Dr/FRke/ZmLh1sm9cFRJTkM/ly+2QZVHEDY6ekGZxsp+Qt3OMqDG2aQv8N6+Y pRVbm/zgL8+gF/UboUNnb5+QIxKHBBNp3mg50e3folMg2GY1kquXLFB2ANoerRU8qXGRqxHh3NGmR fW3u6u9LDG6v7TGXbBJurom+hPfr9c8s6VTWx7LAGD511O3BYz5oSg4e2aGcq7Nofy9LnhgDrx5F0 O6aKwZdVXMkiyp57miFcpCTvL9BTfV/FvrFr/eqjd7f/94CvRCzifumZ16A3n86vs24kcxxkzzu5k O8o12kgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tskmT-0000000BhlW-3H4y; Thu, 13 Mar 2025 15:47:33 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tskeR-0000000BgXT-2O1c for linux-arm-kernel@lists.infradead.org; Thu, 13 Mar 2025 15:39:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zfn8MvGaPhvvtf+QrRo744IfarHruhDfz+umV5cE8tkYoeZ2G1d9xMNa4eIBNPzQijBzzomvihmPkYg+1YA2tTICM2vWYVxZwX041UZv4JGJaWHoAIB2IdcTxSukio9POR1CdeJH+n+fgbwBjFRVpmUs0ZwSZGJWnuZ84rN4PUUwBnD1upXj7xrnZeDUeBu5vJfFvJb4FpHPgzCdrQJZ4t0vCb/sBC6xOZwUEej5i4S9uVLtnAF5YMyVHnthYFY1KZiBz+l2dT9kHuckNL26No4YTUygLLeETq0JzQ8QhFnlXMo3NHy1bOXry2Lv7+4IT4j5u9q3PveCLa16NSq85Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DZfCysn5S4+XnUcPLACOvSajhoolaGVZluObBWMpN4A=; b=o90LUKJPLpuRk3/YExmoYZbYOzO+YHIGLYoXUAnLFoYXJY6dr0x7upn9SJPyrxY5ZeMWN9s5U6e8vlIrS/9QkloZlReLgtQMHh/EyUu7iyuX4KU4meM5qUOaBBMDbNvUGFSzq1uflnDmbX+5TvjLNdCd10L8vK5fS+ZU+Lc5HlHfgRkvKmHHviGg42VqvcIFROyqEBqIkM73Ulm2xBymqPkMrffAANEx+KTNWTgqyC0sMmcEuv5MEW/7MwgGDkKO+JuTwqPUZstAS11O1c5xeaK6AcW9koxbXYUZkDrEPqYz3OzWH9CdqqS7+nqcmcfziGFXpgmrVjJwiR1bQcwFaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZfCysn5S4+XnUcPLACOvSajhoolaGVZluObBWMpN4A=; b=NolOB7eIH/wPC1QcQvJvCMJrkM9Wglg+6DXB65cev9e47He1+yrsnwqDStDqguUjwYFmxOFPh8ogPtDeUG/2WQ1b8vCNxubSwmNeemlOFVsm5rxZT0fKwFyqwoPahOVHRr/cjlYqpeGc0GEDsL+mJn64DyiBJbgRsMkVyzXDqr2guu1YuHrDeygeVZpwfQrR3AzOAua59q0LLWgMlntzBsBjLLi/L3VnYPS97IMAe0tmPcCgfGnephZYxAx8GWe00yT2pV3/PS6+ArtuO/uZppjZomFWWHl/REW8u6U9ShtuL53xIpRWHqaa1dI0tDX+/7U0Fekiam1dpxM2r3z73w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS8PR04MB8119.eurprd04.prod.outlook.com (2603:10a6:20b:3f9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.25; Thu, 13 Mar 2025 15:39:12 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%3]) with mapi id 15.20.8511.026; Thu, 13 Mar 2025 15:39:12 +0000 From: Frank Li Date: Thu, 13 Mar 2025 11:38:40 -0400 Subject: [PATCH v11 04/11] PCI: dwc: Move devm_pci_alloc_host_bridge() to the beginning of dw_pcie_host_init() Message-Id: <20250313-pci_fixup_addr-v11-4-01d2313502ab@nxp.com> References: <20250313-pci_fixup_addr-v11-0-01d2313502ab@nxp.com> In-Reply-To: <20250313-pci_fixup_addr-v11-0-01d2313502ab@nxp.com> To: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Niklas Cassel , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1741880335; l=1299; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=AUXtC8H/FTHPcXtiN3EH1E52WI5BlzetCri0vzeowoA=; b=QlC3jIKCFYtP52F64pUzrd/DKyz66z/Cx8FMqRBKXWB5nYKToVIdl9GQjKzpcgUfkPS/f6682 Zpso90T3+7KBJz6RVcLvTAP2iTBouGYgJQLEjKL4qkQj/junDAnDFZf X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SA9PR13CA0038.namprd13.prod.outlook.com (2603:10b6:806:22::13) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS8PR04MB8119:EE_ X-MS-Office365-Filtering-Correlation-Id: 775f0dd4-b825-486f-d259-08dd6245342f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|7416014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?9UY7ByoYk1JD5aEsYN2tYpyrepQ6xzG?= =?utf-8?q?orTyFxbZ5erJwKpiy8I/G5Yv2cu20wGaDbcToeqaJBhlSAQO3wddKptMaCoKUmjuk?= =?utf-8?q?gb5mxuqcCE+9m8Awl4c9ymPABO1aw0NUDlFmY4ywfrJIUkTEyq1W7iy3H5yY3nalJ?= =?utf-8?q?lOz1q5X4CEFg5hPJBIN21YpWlrAUTnb9xWGhA4Orzgiech2aYonyJLMvM4seNPmFz?= =?utf-8?q?xV2gCwdR9oahQ5Ky7+PeMSgloRE94R9af0KOz04Ylsf8tJ2iuGjy3LV1u2snXemGQ?= =?utf-8?q?YgwffooFOzXStqRC8LRT4gjz918nZg/yQbIrL0Cl1w59dmq7Y7QVlkOv6XKgx04NB?= =?utf-8?q?Dlpgekl56FyfMoq6zzEt/aCcT8ZIixSMJvpt00e95eXhsWVRaCtOyT+Fmg28DGYRB?= =?utf-8?q?eQ3+R1fqAUUlFEeDEiWgdgNXLqPtLKiJ5zn2PF4TgRPwoc1lmXKp9fRXMKhHbZUUh?= =?utf-8?q?fs48l69WkPvo8IhuP4zJASG3XlRKWp95FjOu1yOFNS3AFYK7WAA9wg3hVborThqWU?= =?utf-8?q?NPMTaT2FLwXWw0yqzhgJA9MMBNRT18hSYqtdiWned3VbIYt1JaNz/yuE/9voDJSZE?= =?utf-8?q?MmGGi3R/gO8OXxyu/S6aI0xqlOB5srd9u0Nc47K5Ml4ntOyMuHlSSz1uQuE0nzQwe?= =?utf-8?q?NQkMDCqvSXJ7nc6atZTaCrFrVRxHTiNrLh6U7mT6Cn6FGZZPYDOYel8f6pASByzOX?= =?utf-8?q?LyLB7KLgsxyQ8TIa3x+WcrFcXgK3tI7urczi23taHZBRayaJFFaKdGgmnOO1nd7SS?= =?utf-8?q?DLZeg6ZlhY+D/xj3TXWjsc48He82ScRL9cWGIQ7EY0zHe0EuovG6UBcAk0GHY0Uaq?= =?utf-8?q?ivNWy1tPG1a/LjpXAJq4RGsxjgd7LUKUNgLWlWvJDMCPj852quSO2li5vsFjX9u0Q?= =?utf-8?q?UGEzbsQfCT3cbr9ReiGTd7gdnKyTdImcA4EpCj1NPFMvhOvax7qt3/odSggYMcR/y?= =?utf-8?q?f5HhkECGjbXjeblwBmeteqiQNtrWK5dK8DYk2rzxEGAUO0QdIZt7/tTNHlLRHQMoV?= =?utf-8?q?2RetPYmBX7JDwHE2TorKshj/pk+XTmGXK5TCzvLnJfoxnvs/IvXxXAb4cz4Xb/eBn?= =?utf-8?q?guSLUFSCIj4cKthH23MITUPclWd31IT1/f+xEEbTMWRL8RRFdWamZt7OZ0T05Gy2R?= =?utf-8?q?P6FXQ3TTXY13DlAhOgq1USozZYYb+xCx8avBAqP9vqxxxmlGxLxGBBuaBkdfVZOdC?= =?utf-8?q?A0TPKwjQiCWoz81jM2E2/O/BR+nECuxQqt+ML1wtanTmpDf1cnVbzF+sJUbasw5y5?= =?utf-8?q?RUxA7jqC36exPA1RZlugqJJW33EfG2/iS9tSqzxQYM0vuDLoyPak78b55zmK4gUx3?= =?utf-8?q?gCeqDQluBnQcYn6BWARjmEjQm8H5BsDgmgKdlBoO6hy8oISjVUYoTWOQ5/1a6FLHn?= =?utf-8?q?D+7TJLhkVrMdf/VrFzJjX+mWudg8aDHjA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(7416014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?lgOqfnfqNQ73OoTJXG867mtuqISN?= =?utf-8?q?bywBw9egALwTZbaXunCsFJTiuNZHuXZmCHYPh/nnEU3UsLaw1jTTa1g3MzlscTvpG?= =?utf-8?q?V5WwxmUVqlZRz13kgXDVZvzH6EFNrdUtFv72Y8pXy7wQTWlIry0Gh0F/8qJWZ9BN2?= =?utf-8?q?Mai9nNui7dYNs9swcgzDLNbzI4E7M26awDxAu+EEhte72+Xi9VfeNj/0nqWx4SkIt?= =?utf-8?q?2pXyvPfTeoWyuak/KmIZLrC/iNT37dg+KOwNxYFU/RLcMpaYeNbBoJi4wKUzC2vlz?= =?utf-8?q?mARmMHlvLJij/lpu3/YgPIkOSQu+BBIUoKC1LXxgum1wF/M4dreUkd1EduDXRftxA?= =?utf-8?q?bDoNSaLBS7qA7v02TWULm/zn+QK2ByaHYmcXgmRZl9r9hB20CholY2yF5LGptBqlS?= =?utf-8?q?JUC2A+RCefYV66DcMmn9UFFYf4sh9krJYK+sE/x/p/vOx+bssApBNQckeH9QeDQCP?= =?utf-8?q?/Fi5DGJRXw8hRT8ZfCca4o6YM7bvZ64/3FBnavugu/A2fPHjMrnVIjc8rYd0ww453?= =?utf-8?q?qC8QXubbUowMYys8Th4mIMjt+BK/2+pQSdFPrWUyzekUQqEUU4bwAjOi2HDXLs4QI?= =?utf-8?q?qXzDWBsFUnRZK4LXqnTeghM6Bb/M7M4zMn8FIF+6npakhnoizUuZwNWkeEyNI6vB/?= =?utf-8?q?eYpWFmxh+3UOVbJpYi4IGDTIKLpsghKCu30hpXeo7/ImS/R1JBnxteo5eMCy8rL3i?= =?utf-8?q?2Urc9NlTutHCj7gp/BI3R17nYTnVYcgELdXwhKggMdLxtaDTY/t00iIX16QVkE5OI?= =?utf-8?q?2QYq7jAwyen2ifgimLPvTf0f1rC+6nTQORuVfXKkTgUdrX6aYxKuj56yhxTVJ3L9O?= =?utf-8?q?C2eZmlK0jiE7rqVxUbswJ0aGyRGU4OXEXcC45TV2Ur+v9/ClTde6haAuIwAM6CptX?= =?utf-8?q?3tgK6a5cL9JDn2PjZZfAW7Ek67Qj0j43ng9ZOkE+WTqzuaYesbn9Wi24v8k+TNih5?= =?utf-8?q?Wj6e2+vKRHC/XF5+M0XCnMAgOHFa2rCw3q0z5htNZWa4tnaTIHW4iqNRB311CmIgV?= =?utf-8?q?PfL8QVgsTdOPkP32F6ne0MUNOdFAH/H8LxrsiSwDdnnW2ub/7Pd11nxLtQJdTmpHx?= =?utf-8?q?4XOUOcPd15lSg58P5Avp8aS8XkUzbUNWIr9nu/pHS2H31NZNiPfWrpV4skLX1dt4i?= =?utf-8?q?JwUwg9CLrr8WypRX/h4aHJ9REo2eO85YV8MviJtx9+M6JLRmm3bWZ9IISZUpDPyTq?= =?utf-8?q?K9dtGpdXcbRdYOjCKkpPk6hTrMFu8m2CMRuI7aBWVvNr67Bxid0ZgeR8u7K55y/LY?= =?utf-8?q?rwdU4FTMtCDFdjfdW6LDY1GAle9sIuvA9FSoDdbL7ljhi/KXfDSaJnKQWgyqUZWGJ?= =?utf-8?q?oiBECkZSw8wHL/JMwY4N6GvAiJvRL3u6elxaE7Vw2GsBxcmwRLqb5ye7EB8N82rfk?= =?utf-8?q?MiBmQgu3WuBETYw28/YQvnfScYMMVg2t9NBnk6ne9f550HykLAvF7Sr+W6XSXJ7JE?= =?utf-8?q?GmnmBJSREmx78mWTlFnBagPmRUwqsU1OKSauc02xl2SclrXRHW5iAzUhHkPdhZQRf?= =?utf-8?q?Ewa5dJiHXHSi?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 775f0dd4-b825-486f-d259-08dd6245342f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2025 15:39:12.5542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7KFmNpIImgNhjhIyashhjzCPHktP06ReCk8skmWV+AfN/LkicGBoYqTeKfzESJkpBAlqu0C2GbHVmnvpQKJ09w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8119 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_083915_619150_1B95F7E1 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move devm_pci_alloc_host_bridge() to the beginning of dw_pcie_host_init(). Since devm_pci_alloc_host_bridge() is common code that doesn't depend on any DWC resource, moving it earlier improves code logic and readability. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pcie-designware-host.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index c57831902686e..52a441662cabe 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -452,6 +452,12 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) raw_spin_lock_init(&pp->lock); + bridge = devm_pci_alloc_host_bridge(dev, 0); + if (!bridge) + return bridge; + + pp->bridge = bridge; + ret = dw_pcie_get_resources(pci); if (ret) return ret; @@ -460,12 +466,6 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) if (ret) return ret; - bridge = devm_pci_alloc_host_bridge(dev, 0); - if (!bridge) - return -ENOMEM; - - pp->bridge = bridge; - /* Get the I/O range from DT */ win = resource_list_first_type(&bridge->windows, IORESOURCE_IO); if (win) {