diff mbox series

usb: remove the invalid comments

Message ID 20250314070921.355986-1-liqiong@nfschina.com (mailing list archive)
State New
Headers show
Series usb: remove the invalid comments | expand

Commit Message

Li Qiong March 14, 2025, 7:09 a.m. UTC
These function don't return value, remove the invalid comments.

Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
 drivers/usb/cdns3/cdns3-plat.c      | 2 --
 drivers/usb/gadget/udc/udc-xilinx.c | 2 --
 2 files changed, 4 deletions(-)

Comments

Greg KH March 14, 2025, 7:12 a.m. UTC | #1
On Fri, Mar 14, 2025 at 03:09:21PM +0800, Li Qiong wrote:
> These function don't return value, remove the invalid comments.
> 
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>  drivers/usb/cdns3/cdns3-plat.c      | 2 --
>  drivers/usb/gadget/udc/udc-xilinx.c | 2 --

This should be 2 different patches, right?

thanks,

greg k-h
Li Qiong March 14, 2025, 7:32 a.m. UTC | #2
在 2025/3/14 15:12, Greg Kroah-Hartman 写道:
> On Fri, Mar 14, 2025 at 03:09:21PM +0800, Li Qiong wrote:
>> These function don't return value, remove the invalid comments.
>>
>> Signed-off-by: Li Qiong <liqiong@nfschina.com>
>> ---
>>  drivers/usb/cdns3/cdns3-plat.c      | 2 --
>>  drivers/usb/gadget/udc/udc-xilinx.c | 2 --
> This should be 2 different patches, right?
Yeah, I will split this patch and send again.
thanks.



>
> thanks,
>
> greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
index 59ec505e198a..735df88774e4 100644
--- a/drivers/usb/cdns3/cdns3-plat.c
+++ b/drivers/usb/cdns3/cdns3-plat.c
@@ -179,8 +179,6 @@  static int cdns3_plat_probe(struct platform_device *pdev)
 /**
  * cdns3_plat_remove() - unbind drd driver and clean up
  * @pdev: Pointer to Linux platform device
- *
- * Returns 0 on success otherwise negative errno
  */
 static void cdns3_plat_remove(struct platform_device *pdev)
 {
diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index ae2aeb271897..fa94cc065274 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -2178,8 +2178,6 @@  static int xudc_probe(struct platform_device *pdev)
 /**
  * xudc_remove - Releases the resources allocated during the initialization.
  * @pdev: pointer to the platform device structure.
- *
- * Return: 0 always
  */
 static void xudc_remove(struct platform_device *pdev)
 {