From patchwork Tue Mar 18 03:07:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Faizal Rahim X-Patchwork-Id: 14020230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63DB9C282EC for ; Tue, 18 Mar 2025 03:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W9jQaTb5CsffvduHafwuL2MW5ezniOSQBOlGo1IpeIs=; b=UHRRQZb6SkwA0ugImu9qKdRyEh tZrVvmaqf508+5feOKObM9rqi7qbL8B8/SnXInFId4JoOpWd5RSJxtYGFkRZXGwGGyLRXI37Wpm4u Rn9yHiwgzs2cGyHdhsixx09JA1NJfeAFJnmevdaviruvqD9HjHsmw7Fb3z3pX0IPq/qGDMMHpQj4P h3P8o16Z5i65rDhG+O8EoqOk2SDnX/2eV1mOUvkFrjS3XPlij84M6QQSPNc4VF+KV5WlyxoF4brzF 4hn1FR/iKcPYTZRqTYAcXA7cJiMA9F+w7xMjLjT9OT8yvP6/9ePOh7D+4XxiF1EvI5mgxXKosmRpN IcAessZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuNRP-00000004UlQ-2Hrj; Tue, 18 Mar 2025 03:16:31 +0000 Received: from mgamail.intel.com ([198.175.65.13]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuNJv-00000004TGc-2YVR for linux-arm-kernel@lists.infradead.org; Tue, 18 Mar 2025 03:08:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742267327; x=1773803327; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=PJHnS41RUykAMZDQTME6227bQeCUwgkT8h6G/tRYcm0=; b=T2NG5POgQhXTpRgRdficK9NpM0/LIyTwSBoWCsh2ZHRDaL/wfn5RVT2k vsgr7WBtL7egNkWSDL9lDqw0wdoCKMZ4Ik/IfIw0tuz6/9F07/MLu/2iH lwxc+Zj6U/ZNn2RQqthgCMQ3deDVtoziv+2EmP+dVc91xLXAGDQXr8AVT EFkQS0B+E/TAdBBhC8xV0JJM2qgnfaABbxvQOMhvF5whnXCtNBoYKp9Hb /ZDPacEldSVRsvyFzmcFmRn7wnTO2q8EEom6lyG2X1Fc06mar7Lawjcp0 Tobs09tzGI4s4KnWqusVWqojA6yEktenLxZywcWuwNVdxNolY4LiiwYh7 A==; X-CSE-ConnectionGUID: BK7cZgsfSKuQBaJDxVJbzQ== X-CSE-MsgGUID: BcSy9bb3TPW+BSi52nUO2w== X-IronPort-AV: E=McAfee;i="6700,10204,11376"; a="54382922" X-IronPort-AV: E=Sophos;i="6.14,255,1736841600"; d="scan'208";a="54382922" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2025 20:08:47 -0700 X-CSE-ConnectionGUID: /qfjgyHdSmaLQk0bcjHiFQ== X-CSE-MsgGUID: NQxLXbvgRFW/wb8W1q+nrw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,255,1736841600"; d="scan'208";a="126313753" Received: from mohdfai2-ilbpg12-1.png.intel.com ([10.88.227.73]) by fmviesa003.fm.intel.com with ESMTP; 17 Mar 2025 20:08:40 -0700 From: Faizal Rahim To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Vladimir Oltean , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Furong Xu <0x1207@gmail.com>, Choong Yong Liang , Russell King , Hariprasad Kelam , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-stm32@st-md-mailman.stormreply.com, Chwee-Lin Choong , Vinicius Costa Gomes , Faizal Rahim , Kunihiko Hayashi , Serge Semin Subject: [PATCH iwl-next v10 03/14] net: ethtool: mm: reset verification status when link is down Date: Mon, 17 Mar 2025 23:07:31 -0400 Message-Id: <20250318030742.2567080-4-faizal.abdul.rahim@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318030742.2567080-1-faizal.abdul.rahim@linux.intel.com> References: <20250318030742.2567080-1-faizal.abdul.rahim@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250317_200847_682140_56851959 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When the link partner goes down, "ethtool --show-mm" still displays "Verification status: SUCCEEDED," reflecting a previous state that is no longer valid. Reset the verification status to ensure it reflects the current state. Reviewed-by: Furong Xu <0x1207@gmail.com> Reviewed-by: Vladimir Oltean Signed-off-by: Faizal Rahim --- net/ethtool/mm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c index bfd988464d7d..ad9b40034003 100644 --- a/net/ethtool/mm.c +++ b/net/ethtool/mm.c @@ -415,6 +415,10 @@ void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up) /* New link => maybe new partner => new verification process */ ethtool_mmsv_apply(mmsv); } else { + /* Reset the reported verification state while the link is down */ + if (mmsv->verify_enabled) + mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; + /* No link or pMAC not enabled */ ethtool_mmsv_configure_pmac(mmsv, false); ethtool_mmsv_configure_tx(mmsv, false);