| Message ID | 20250318174730.1921983-2-Rajaganesh.Rathinasabapathi@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible | expand |
On 18/03/2025 18:47, Rajaganesh Rathinasabapathi wrote: > Add initial device tree and makefile updates for > AMD Onyx platform. > > AMD Onyx platform is an AMD customer reference board with an Aspeed > ast2600 BMC manufactured by AMD. > It describes I2C devices, UARTs, MAC, FMC, etc. > present on AMD Onyx platform. > > Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@amd.com> > Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com> > --- > Changes since v1: > * Incorporate review comments Which ones? I do not see my comments addressed and if you do not list them, I treat it as a clear sign you do not care. > * Update commit message > * Remove vmalloc and earlyprintk > > Changes since v2: > * Address review comments Which ones? This has to be specific > * Fix checkpatch warnings > * Remove bootargs > > Changes since v3: > * Fix stdout-path > * Change commit summary > --- > arch/arm/boot/dts/aspeed/Makefile | 1 + > .../boot/dts/aspeed/aspeed-bmc-amd-onyx.dts | 102 ++++++++++++++++++ > 2 files changed, 103 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts > > diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile > index 2e5f4833a073..1e6a130377b8 100644 > --- a/arch/arm/boot/dts/aspeed/Makefile > +++ b/arch/arm/boot/dts/aspeed/Makefile > @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-ast2600-evb.dtb \ > aspeed-bmc-amd-daytonax.dtb \ > aspeed-bmc-amd-ethanolx.dtb \ > + aspeed-bmc-amd-onyx.dtb \ > aspeed-bmc-ampere-mtjade.dtb \ > aspeed-bmc-ampere-mtjefferson.dtb \ > aspeed-bmc-ampere-mtmitchell.dtb \ > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts > new file mode 100644 > index 000000000000..32509a651183 > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts > @@ -0,0 +1,102 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright (c) 2021 - 2024 AMD Inc. > +// Author: Supreeth Venkatesh <supreeth.venkatesh@amd.com> > + > +/dts-v1/; > + > +#include "aspeed-g6.dtsi" > +#include <dt-bindings/gpio/aspeed-gpio.h> > + > +/ { > + model = "AMD Onyx BMC"; > + compatible = "amd,onyx-bmc", "aspeed,ast2600"; > + > + aliases { > + serial0 = &uart1; > + serial4 = &uart5; > + }; > + > + chosen { > + stdout-path = "serial4:115200n8"; > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; > + > +}; How did you address comment here from v1 which was responded with "ACK"? What else what exactly fixed and what not? Best regards, Krzysztof
> +&mac3 { > + status = "okay"; > + phy-mode = "rgmii"; Still broken. And it appears you are just ignoring my comments. Sorry, but: NACK There is a discussion here: https://lore.kernel.org/lkml/20250317025922.1526937-1-jacky_chou@aspeedtech.com/ There is also IBM in a similar situation to you: https://lore.kernel.org/linux-arm-kernel/20250108163640.1374680-6-ninad@linux.ibm.com/ and NVIDIA https://lore.kernel.org/lkml/20250312045802.4115029-1-wthai@nvidia.com/ Could i suggest you, IBM and NVIDIA work together to get Aspeed to fix this. Andrew
diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile index 2e5f4833a073..1e6a130377b8 100644 --- a/arch/arm/boot/dts/aspeed/Makefile +++ b/arch/arm/boot/dts/aspeed/Makefile @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-ast2600-evb.dtb \ aspeed-bmc-amd-daytonax.dtb \ aspeed-bmc-amd-ethanolx.dtb \ + aspeed-bmc-amd-onyx.dtb \ aspeed-bmc-ampere-mtjade.dtb \ aspeed-bmc-ampere-mtjefferson.dtb \ aspeed-bmc-ampere-mtmitchell.dtb \ diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts new file mode 100644 index 000000000000..32509a651183 --- /dev/null +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts @@ -0,0 +1,102 @@ +// SPDX-License-Identifier: GPL-2.0+ +// Copyright (c) 2021 - 2024 AMD Inc. +// Author: Supreeth Venkatesh <supreeth.venkatesh@amd.com> + +/dts-v1/; + +#include "aspeed-g6.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> + +/ { + model = "AMD Onyx BMC"; + compatible = "amd,onyx-bmc", "aspeed,ast2600"; + + aliases { + serial0 = &uart1; + serial4 = &uart5; + }; + + chosen { + stdout-path = "serial4:115200n8"; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + +}; + +&mdio0 { + status = "okay"; + ethphy0: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + }; +}; + +&mac3 { + status = "okay"; + phy-mode = "rgmii"; + phy-handle = <ðphy0>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgmii4_default>; +}; + +&fmc { + status = "okay"; + flash@0 { + compatible = "jedec,spi-nor"; + status = "okay"; + #include "openbmc-flash-layout-128.dtsi" + }; +}; + +//Host Console +&uart1 { + status = "okay"; +}; + +//BMC Console +&uart5 { + status = "okay"; +}; + +&gpio0 { +gpio-line-names = + /*A0-A7*/ "","","","","","","","", + /*B0-B7*/ "","","","","MON_POST_COMPLETE","P0_PRESENT_L","","", + /*C0-C7*/ "","","","","","","","", + /*D0-D7*/ "","","","","","","","", + /*E0-E7*/ "","","","","","","","", + /*F0-F7*/ "","","","","","","","", + /*G0-G7*/ "","","","","","","","", + /*H0-H7*/ "","ASSERT_WARM_RST_BTN_L","ASSERT_SOC_RST_BTN_L","","","","","", + /*I0-I7*/ "","","","","","","","P0_I3C_APML_ALERT_L", + /*J0-J7*/ "","","","","","","","", + /*K0-K7*/ "","","","","","","","", + /*L0-L7*/ "","","","","","","","", + /*M0-M7*/ "","","","","","","","", + /*N0-N7*/ "","","","","","","PSP_SOFT_FUSE_NOTIFY","ASSERT_BMC_READY", + /*O0-O7*/ "","","HDT_SEL","HDT_XTRIG5","HDT_XTRIG6","JTAG_TRST_N","","", + /*P0-P7*/ "MON_RST_BTN_L","ASSERT_RST_BTN_L","MON_PWR_BTN_L","ASSERT_PWR_BTN_L", + "HPM_FPGA_LOCKOUT","ASSERT_NMI_BTN_L","MON_PWR_GOOD","", + /*Q0-Q7*/ "","","HDT_DBREQ_L","","BIOS_SPD_MUX_CTRL_RELEASED_L","","","", + /*R0-R7*/ "","","","","","","","", + /*S0-S7*/ "","","","","","","P0_DIMM_AF_ERROR","P0_DIMM_GL_ERROR", + /*T0-T7*/ "","","","","","","","", + /*U0-U7*/ "","","","","","","","", + /*V0-V7*/ "","","","","","","","", + /*W0-W7*/ "","","","","","","","", + /*X0-X7*/ "","","","","","","","", + /*Y0-Y7*/ "","","","","","","","", + /*Z0-Z7*/ "","","","","","","",""; +}; + +&i2c7 { + status = "okay"; + mbeeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; +};