| Message ID | 20250319-audio_drvier-v4-2-686867fad719@amlogic.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for S4 audio | expand |
On Wed, Mar 19, 2025 at 03:04:45PM +0800, jiebing chen wrote: > Add clock IDs for the mclk pads found on s4 SoCs > > Signed-off-by: jiebing chen <jiebing.chen@amlogic.com> > --- > include/dt-bindings/clock/axg-audio-clkc.h | 11 +++++++++++ This belongs to the binding patch, usually. Anyway - do not ask us to do the work twice. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
在 2025/3/19 16:22, Krzysztof Kozlowski 写道: > [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > [ EXTERNAL EMAIL ] > > On Wed, Mar 19, 2025 at 03:04:45PM +0800, jiebing chen wrote: >> Add clock IDs for the mclk pads found on s4 SoCs >> >> Signed-off-by: jiebing chen <jiebing.chen@amlogic.com> >> --- >> include/dt-bindings/clock/axg-audio-clkc.h | 11 +++++++++++ > This belongs to the binding patch, usually. > > Anyway - do not ask us to do the work twice. > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions of patchset, under or above your Signed-off-by tag, unless > patch changed significantly (e.g. new properties added to the DT > bindings). Tag is "received", when provided in a message replied to you > on the mailing list. Tools like b4 can help here. However, there's no > need to repost patches *only* to add the tags. The upstream maintainer > will do that for tags received on the version they apply. > > Please read: > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> thanks for your remind > Best regards, > Krzysztof >
diff --git a/include/dt-bindings/clock/axg-audio-clkc.h b/include/dt-bindings/clock/axg-audio-clkc.h index 607f23b83fa7287fe0403682ebf827e2df26a1ce..75dde05343d1fa74304ee21c9ec0541a8f51b15e 100644 --- a/include/dt-bindings/clock/axg-audio-clkc.h +++ b/include/dt-bindings/clock/axg-audio-clkc.h @@ -162,5 +162,16 @@ #define AUD_CLKID_EARCRX_DMAC_SEL 182 #define AUD_CLKID_EARCRX_DMAC_DIV 183 #define AUD_CLKID_EARCRX_DMAC 184 +#define AUD_CLKID_TDM_MCLK_PAD0_SEL 185 +#define AUD_CLKID_TDM_MCLK_PAD1_SEL 186 +#define AUD_CLKID_TDM_MCLK_PAD0_DIV 187 +#define AUD_CLKID_TDM_MCLK_PAD1_DIV 188 +#define AUD_CLKID_TDM_MCLK_PAD2 189 +#define AUD_CLKID_TDM_MCLK_PAD2_SEL 190 +#define AUD_CLKID_TDM_MCLK_PAD2_DIV 191 +#define AUD_CLKID_TDM_SCLK_PAD3 192 +#define AUD_CLKID_TDM_SCLK_PAD4 193 +#define AUD_CLKID_TDM_LRCLK_PAD3 194 +#define AUD_CLKID_TDM_LRCLK_PAD4 195 #endif /* __AXG_AUDIO_CLKC_BINDINGS_H */