From patchwork Sun Mar 23 22:39:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14026699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE122C28B30 for ; Sun, 23 Mar 2025 22:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i5FeheMvzJmbwWW+zZr6R44NUMWEXy77OJnz7z8P8Mo=; b=f9C3FDYczKk8r2Tk8ZHBYwTZQ7 pfHHj2fq+iYBSRYBzLDGJSVfs9BE64RbmatUMFTgMCcIE0b3uxTRum7WjpLsP7QIdvYqDkP5ghiP0 N8LsXabnj+kB2Rm9AsmxwO0jyOduKzffdJPgpRVEKf/Den93vbWV1j5lAoc4vMQ/JERTDQ/MB6HMu kwNH/gJ8/aAX9cT98cWqhbPHsEDKWKctCtpE4/3eF/9Lssg8W3hBqr4MXBDqvLTDQqjNJMiPBy9mZ h3UQqrmr7tUXXOkXrdQPy7Od/6CNtG05wL7V2pUayW9Z2P8l154QxGAE2bdhHWqOSpPyqDYgW9kQs TTFxrALg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1twUHK-00000001s9c-2ZDj; Sun, 23 Mar 2025 22:58:50 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1twTye-00000001p7V-2tf6 for linux-arm-kernel@lists.infradead.org; Sun, 23 Mar 2025 22:39:33 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-ac2a9a74d9cso776697266b.1 for ; Sun, 23 Mar 2025 15:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742769571; x=1743374371; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i5FeheMvzJmbwWW+zZr6R44NUMWEXy77OJnz7z8P8Mo=; b=ESioBpX9H0o4YJS134lTT2fB3ePuVN6CCSJ/ZsdgqWGVIxyItKdrh/fp9qHtZzfisR 8HBPaf0q6m7BuFrnwxiTAH3eQu9zwtqMO8uN5Q7z92mMQY5ZNdiFicRzpEda5xlBsTHm qBH2gDnTAkhJWwd4tGKJTjvanMqZVk6LZLHI1x7Kl2qgkprz4TAnttEi5GXR3JjDa3GV T6Hi0HjBSJ8ZpEOtaGvYvpRku+NNFAENWLNd7IKi0BQWLH9VPcfEJMyoqoa6c+699Q4Y iv/gd8T5nj0pITGA81NGI97c9iJ2znuBat8ohwPDFCqEDQ8frLfy2rbKhUdaoNT7GgZq x7aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742769571; x=1743374371; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5FeheMvzJmbwWW+zZr6R44NUMWEXy77OJnz7z8P8Mo=; b=NkoUYAbbTPr/e7j35SokcUepBnuzLldgoNKGtaKD3Lk0hsdFJlCOIseWTEo5YfX9Pc X1a7U/hYAQBde297xkSaKuyQ1sCPto+xdp4Vr5vI5h7me2Kjnt6SZBVGWdzKvDeaOVU2 e96z7uGUl5IMrYQghVyRm7shVFOUhQRVhBtktfpU6loL1TKdkky61Bw4OZeE4eqmBUWM 1l3mzHcJa/fTRTbPEJOHM/ge52apPf4QUWzSR/ijSdSZOxxeJRVDCL/2zWjvwnaBW6rW yZfzSrd85eVj0Af/kaLe+C00ZZcGJJfNwdfW4qDKfJIQqhI5eOfgGgJYFY5ZZZCe/Fc4 aZbg== X-Forwarded-Encrypted: i=1; AJvYcCVnexq6V5h8/eqTXSlRq3xcJb2owEQKZ7Ix1RMEsSxR7gS4jFX5RZyGjcj/Qzm+FVwHObmnxowIfqWl07FpLylW@lists.infradead.org X-Gm-Message-State: AOJu0Yz04xdr/pmQC61MXBln83SFHM+hby8RjYShlBoa00O1tztJoQDJ NJVA2121H13QKZLmZZIMI0ooKVSo0WXPq8HqpeGlvLd8Pwcwdw4GhN90HwgQF+g= X-Gm-Gg: ASbGncseTDDZg6JGQWxi6Y/TfeQZi7xn7auBYrHFtPXXCn9s+U0HRpLw5QKiK2B/cvE sI+oZc93iXTOBmhxp5CPy9ek4TZmWLlkiGlWVJnp5vwaQybd2/z4JxCX502iRR2SQWnYeB+ZiJL 5TpUqkL1xkYDKUW9sHhVvVceAcwaiUMzV8qUcA5uXIXJe7jVidr6US99dm2wgTuoOXgAjikT6Cd GyYa5pVecApw6B0qMyIEWXDQEBYyzKER+nV1B9SDx+ECr/IMd+pvTiuz7I7+6IYU99CL0hVBNh1 rUTpaulXhteJbTZjNIPb0ihJ8uPyYm15Vio2WsmybSIzrNNO15b9z7wi7iZ0uayIZ3M4QVOz/IF K+2hBBW7yGXmmktJyIqjVP8pJS6HJ X-Google-Smtp-Source: AGHT+IGUlU/bQ4EEwEZ8SvxfGdwz6JP0ixr4oFBkCNhTZdri22pju1M/NgGRE9XtZE8yWlr6k3maUQ== X-Received: by 2002:a17:907:3d88:b0:ac3:8d24:a7e with SMTP id a640c23a62f3a-ac3f22b476amr1025053966b.26.1742769571302; Sun, 23 Mar 2025 15:39:31 -0700 (PDT) Received: from puffmais.c.googlers.com (8.239.204.35.bc.googleusercontent.com. [35.204.239.8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3ef86e44dsm559686666b.31.2025.03.23.15.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 15:39:30 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Sun, 23 Mar 2025 22:39:29 +0000 Subject: [PATCH 13/34] mfd: sec: merge separate core and irq modules MIME-Version: 1.0 Message-Id: <20250323-s2mpg10-v1-13-d08943702707@linaro.org> References: <20250323-s2mpg10-v1-0-d08943702707@linaro.org> In-Reply-To: <20250323-s2mpg10-v1-0-d08943702707@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250323_153932_731860_C511BCFE X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no reason to have these two kernel modules separate. Having them merged into one kernel module also slightly reduces memory consumption and module load times a little. mapped size (lsmod): before: after: sec_core 20480 sec_core 24576 sec_irq 16384 ---------------- total 36864 Section sizes (size -A): before: after: sec_core 6780 sec_core 13239 sec_irq 8046 ---------------- Total 14826 Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- Checkpatch suggests to update MAINTAINERS, but the new file is covered already due to using a wildcard. --- drivers/mfd/Makefile | 3 ++- drivers/mfd/{sec-core.c => sec-common.c} | 2 ++ drivers/mfd/sec-irq.c | 8 -------- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 8a8c678134a9721c7f78e432ddd0df33b2b0de69..67fac46c8eeb9c7b4429e8a496a1d7d40d2b7b31 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -232,7 +232,8 @@ obj-$(CONFIG_MFD_RK8XX) += rk8xx-core.o obj-$(CONFIG_MFD_RK8XX_I2C) += rk8xx-i2c.o obj-$(CONFIG_MFD_RK8XX_SPI) += rk8xx-spi.o obj-$(CONFIG_MFD_RN5T618) += rn5t618.o -obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o sec-irq.o +sec-core-objs := sec-common.o sec-irq.o +obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o obj-$(CONFIG_MFD_SEC_ACPM) += sec-acpm.o obj-$(CONFIG_MFD_SEC_I2C) += sec-i2c.o obj-$(CONFIG_MFD_SYSCON) += syscon.o diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-common.c similarity index 98% rename from drivers/mfd/sec-core.c rename to drivers/mfd/sec-common.c index 27f5036ffa1009304147755c91d00be333dd206a..fcf7668efd3215ad70d81916ede249ed5f9d45ae 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-common.c @@ -290,6 +290,8 @@ DEFINE_SIMPLE_DEV_PM_OPS(sec_pmic_pm_ops, sec_pmic_suspend, sec_pmic_resume); EXPORT_SYMBOL_GPL(sec_pmic_pm_ops); MODULE_AUTHOR("André Draszik "); +MODULE_AUTHOR("Chanwoo Choi "); +MODULE_AUTHOR("Krzysztof Kozlowski "); MODULE_AUTHOR("Sangbeom Kim "); MODULE_DESCRIPTION("Core driver for the Samsung S5M"); MODULE_LICENSE("GPL"); diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index bf86281401ac6ff05c90c2d71c84744709ed79cb..4afac3aa0a582994bf04c41768c1c788c54ee2e9 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include @@ -510,10 +509,3 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) return 0; } -EXPORT_SYMBOL_GPL(sec_irq_init); - -MODULE_AUTHOR("Sangbeom Kim "); -MODULE_AUTHOR("Chanwoo Choi "); -MODULE_AUTHOR("Krzysztof Kozlowski "); -MODULE_DESCRIPTION("Interrupt support for the S5M MFD"); -MODULE_LICENSE("GPL");