| Message ID | 20250404-kconfig-defaults-clk-v1-4-4d2df5603332@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | clk: Do not enable by default during compile testing | expand |
On Fri, 04 Apr 2025 13:57:00 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: Hi > Enabling the compile test should not cause automatic enabling of all > drivers. Restrict the default to ARCH also for individual drivers, even > though their choice is not visible without selecting parent Kconfig > symbol, because otherwise selecting parent would select the child during > compile testing. so I remember we changed this to "default y", because there were some tricky problems with regards to RISC-V and ARM. See commits: commit 0ff347db4c97cc16b4e428dc1db550ba3628f1e2 Author: Samuel Holland <samuel@sholland.org> Date: Sat Dec 31 17:14:25 2022 -0600 clk: sunxi-ng: Move SoC driver conditions to dependencies and commit a26dc096f683ca27ac5e68703bfd3098b4212abd Author: Samuel Holland <samuel@sholland.org> Date: Sat Dec 31 17:14:24 2022 -0600 clk: sunxi-ng: Remove duplicate ARCH_SUNXI dependencies Don't remember what broke, exactly, but just wanted to give a heads up. Cheers, Andre > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/clk/sunxi-ng/Kconfig | 48 ++++++++++++++++++++++---------------------- > 1 file changed, 24 insertions(+), 24 deletions(-) > > diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig > index 5830a9d87bf25d536ac787fe83669c64c8214952..8896fd052ef1784d60d488ab1498737c1405deb2 100644 > --- a/drivers/clk/sunxi-ng/Kconfig > +++ b/drivers/clk/sunxi-ng/Kconfig > @@ -9,123 +9,123 @@ if SUNXI_CCU > > config SUNIV_F1C100S_CCU > tristate "Support for the Allwinner newer F1C100s CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUNIV || COMPILE_TEST > > config SUN20I_D1_CCU > tristate "Support for the Allwinner D1/R528/T113 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || RISCV || COMPILE_TEST > > config SUN20I_D1_R_CCU > tristate "Support for the Allwinner D1/R528/T113 PRCM CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || RISCV || COMPILE_TEST > > config SUN50I_A64_CCU > tristate "Support for the Allwinner A64 CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN50I_A100_CCU > tristate "Support for the Allwinner A100 CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN50I_A100_R_CCU > tristate "Support for the Allwinner A100 PRCM CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN50I_H6_CCU > tristate "Support for the Allwinner H6 CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN50I_H616_CCU > tristate "Support for the Allwinner H616 CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN50I_H6_R_CCU > tristate "Support for the Allwinner H6 and H616 PRCM CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN55I_A523_CCU > tristate "Support for the Allwinner A523/T527 CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN55I_A523_R_CCU > tristate "Support for the Allwinner A523/T527 PRCM CCU" > - default y > + default ARCH_SUNXI > depends on ARM64 || COMPILE_TEST > > config SUN4I_A10_CCU > tristate "Support for the Allwinner A10/A20 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN4I || MACH_SUN7I || COMPILE_TEST > > config SUN5I_CCU > bool "Support for the Allwinner sun5i family CCM" > - default y > + default ARCH_SUNXI > depends on MACH_SUN5I || COMPILE_TEST > depends on SUNXI_CCU=y > > config SUN6I_A31_CCU > tristate "Support for the Allwinner A31/A31s CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN6I || COMPILE_TEST > > config SUN6I_RTC_CCU > tristate "Support for the Allwinner H616/R329 RTC CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || ARM64 || RISCV || COMPILE_TEST > > config SUN8I_A23_CCU > tristate "Support for the Allwinner A23 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || COMPILE_TEST > > config SUN8I_A33_CCU > tristate "Support for the Allwinner A33 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || COMPILE_TEST > > config SUN8I_A83T_CCU > tristate "Support for the Allwinner A83T CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || COMPILE_TEST > > config SUN8I_H3_CCU > tristate "Support for the Allwinner H3 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || ARM64 || COMPILE_TEST > > config SUN8I_V3S_CCU > tristate "Support for the Allwinner V3s CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || COMPILE_TEST > > config SUN8I_DE2_CCU > tristate "Support for the Allwinner SoCs DE2 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || ARM64 || RISCV || COMPILE_TEST > > config SUN8I_R40_CCU > tristate "Support for the Allwinner R40 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || COMPILE_TEST > > config SUN9I_A80_CCU > tristate "Support for the Allwinner A80 CCU" > - default y > + default ARCH_SUNXI > depends on MACH_SUN9I || COMPILE_TEST > > config SUN8I_R_CCU > tristate "Support for Allwinner SoCs' PRCM CCUs" > - default y > + default ARCH_SUNXI > depends on MACH_SUN8I || ARM64 || COMPILE_TEST > > endif >
On 04/04/2025 16:13, Andre Przywara wrote: > On Fri, 04 Apr 2025 13:57:00 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Hi >> Enabling the compile test should not cause automatic enabling of all >> drivers. Restrict the default to ARCH also for individual drivers, even >> though their choice is not visible without selecting parent Kconfig >> symbol, because otherwise selecting parent would select the child during >> compile testing. > > so I remember we changed this to "default y", because there were some > tricky problems with regards to RISC-V and ARM. See commits: > > commit 0ff347db4c97cc16b4e428dc1db550ba3628f1e2 > Author: Samuel Holland <samuel@sholland.org> > Date: Sat Dec 31 17:14:25 2022 -0600 > clk: sunxi-ng: Move SoC driver conditions to dependencies > > and > > commit a26dc096f683ca27ac5e68703bfd3098b4212abd > Author: Samuel Holland <samuel@sholland.org> > Date: Sat Dec 31 17:14:24 2022 -0600 > clk: sunxi-ng: Remove duplicate ARCH_SUNXI dependencies > > Don't remember what broke, exactly, but just wanted to give a heads up. > Hm, I missed that. Quite unexpected commits. I would expect they to change default to match exact case but apparently for simplicity they became default for everyone? No clue... Commit says: " Do not duplicate the same expression on the `default` line, so the two lines do not need to be kept in sync." what it did, but not WHY. Why is the most important thing... The rest of the commit msg: "Drivers stay disabled under COMPILE_TEST because of the `default ARCH_SUNXI` applied to SUNXI_CCU." is true, until you enable SUNXI_CCU. Then all of them became enabled by default, which is not necessary and in general not welcomed. You should compile test only things which you want, not everything. Best regards, Krzysztof
diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig index 5830a9d87bf25d536ac787fe83669c64c8214952..8896fd052ef1784d60d488ab1498737c1405deb2 100644 --- a/drivers/clk/sunxi-ng/Kconfig +++ b/drivers/clk/sunxi-ng/Kconfig @@ -9,123 +9,123 @@ if SUNXI_CCU config SUNIV_F1C100S_CCU tristate "Support for the Allwinner newer F1C100s CCU" - default y + default ARCH_SUNXI depends on MACH_SUNIV || COMPILE_TEST config SUN20I_D1_CCU tristate "Support for the Allwinner D1/R528/T113 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || RISCV || COMPILE_TEST config SUN20I_D1_R_CCU tristate "Support for the Allwinner D1/R528/T113 PRCM CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || RISCV || COMPILE_TEST config SUN50I_A64_CCU tristate "Support for the Allwinner A64 CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN50I_A100_CCU tristate "Support for the Allwinner A100 CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN50I_A100_R_CCU tristate "Support for the Allwinner A100 PRCM CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN50I_H6_CCU tristate "Support for the Allwinner H6 CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN50I_H616_CCU tristate "Support for the Allwinner H616 CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN50I_H6_R_CCU tristate "Support for the Allwinner H6 and H616 PRCM CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN55I_A523_CCU tristate "Support for the Allwinner A523/T527 CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN55I_A523_R_CCU tristate "Support for the Allwinner A523/T527 PRCM CCU" - default y + default ARCH_SUNXI depends on ARM64 || COMPILE_TEST config SUN4I_A10_CCU tristate "Support for the Allwinner A10/A20 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN4I || MACH_SUN7I || COMPILE_TEST config SUN5I_CCU bool "Support for the Allwinner sun5i family CCM" - default y + default ARCH_SUNXI depends on MACH_SUN5I || COMPILE_TEST depends on SUNXI_CCU=y config SUN6I_A31_CCU tristate "Support for the Allwinner A31/A31s CCU" - default y + default ARCH_SUNXI depends on MACH_SUN6I || COMPILE_TEST config SUN6I_RTC_CCU tristate "Support for the Allwinner H616/R329 RTC CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || ARM64 || RISCV || COMPILE_TEST config SUN8I_A23_CCU tristate "Support for the Allwinner A23 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || COMPILE_TEST config SUN8I_A33_CCU tristate "Support for the Allwinner A33 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || COMPILE_TEST config SUN8I_A83T_CCU tristate "Support for the Allwinner A83T CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || COMPILE_TEST config SUN8I_H3_CCU tristate "Support for the Allwinner H3 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || ARM64 || COMPILE_TEST config SUN8I_V3S_CCU tristate "Support for the Allwinner V3s CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || COMPILE_TEST config SUN8I_DE2_CCU tristate "Support for the Allwinner SoCs DE2 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || ARM64 || RISCV || COMPILE_TEST config SUN8I_R40_CCU tristate "Support for the Allwinner R40 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN8I || COMPILE_TEST config SUN9I_A80_CCU tristate "Support for the Allwinner A80 CCU" - default y + default ARCH_SUNXI depends on MACH_SUN9I || COMPILE_TEST config SUN8I_R_CCU tristate "Support for Allwinner SoCs' PRCM CCUs" - default y + default ARCH_SUNXI depends on MACH_SUN8I || ARM64 || COMPILE_TEST endif
Enabling the compile test should not cause automatic enabling of all drivers. Restrict the default to ARCH also for individual drivers, even though their choice is not visible without selecting parent Kconfig symbol, because otherwise selecting parent would select the child during compile testing. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/clk/sunxi-ng/Kconfig | 48 ++++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 24 deletions(-)