From patchwork Tue Apr 8 21:53:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14043770 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D31FC36010 for ; Tue, 8 Apr 2025 22:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=duyx0+ALz8gkTQnbJkTxbICnPUi5pZZGzoIPTth4aeQ=; b=3kio92IipaTpmI9OWDDpvTSrxl zS+wTxe71EnrWq4Bipp/odxEmieu/UZ+bGSFubvtViyIAFTiddx75t/s/0xX7vX1LFXKwBEs4gD4G YaD1Hm/OCP3IxxMEAnMD1BY6RER5mAvi7Zwjd04H387dl4kSvGFxbwE4/hkL1x0wn/YIvHrWfMj7G e1tci6zFEyTcX1Izjofz5krvG4A2VWplVu9g+B8oH92hPjOIj8tZQA58SM5zpY7CqURlsTHFqXjCE ZbmCNMoxIPfeODLTBAfAQKn7OQLc5mwCM8QjNJFvPskgJcJZNlhgobFFZawCCJ0gb9d5tNEj2Tqwq UUMoYb1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2H3q-00000005WQv-2nwF; Tue, 08 Apr 2025 22:04:50 +0000 Received: from mail-vi1eur02on20615.outbound.protection.outlook.com ([2a01:111:f403:2607::615] helo=EUR02-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2Gte-00000005UWg-0Ei8 for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 21:54:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ARLqkb2HdxZFbEM1+miFvVBpS/8CVq56LfqHGPqhf/+o9uX0owVLWARNuA5gUduoNL6hySaCEa/nb9FTQhYmNXQ8KWKVAdubii9TY8xJu97MVVR/hBMqB2yyZp/1zZWvfp9ZwzbL/gMsmp1y9WV9bDUOVgLP7YB87U6c/VCW1jwanGvN85ThSyqFoqDi8dhtxJMnrJsQCaZhkvTZYm+pfGlftQbqqHN6cSzzCAXhuWl39V/w/XOWGyx/DJVB9HeVoWR9OmvKZyWnV8PL11wQwnbQCRUiDm4NAMazkVe20gWA6+PUsJjTow6GkjcHRlmYf8WhMEAuYrpgii5WBgMlEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duyx0+ALz8gkTQnbJkTxbICnPUi5pZZGzoIPTth4aeQ=; b=Fdz+O95PTpZv6c67dBVfAcdT+EcB8GIzedYs1klP2ExHCIeOEBZWoY03N3CHOghsYPVogkZNy3PUY+3ZyX6HbtBc6EDmhFi3jvHMuoJ6N2HOSpiAf2HLjPU8wwhSqSbPtT9xCazoO6VuvpiEwsp0IkqDw4w1IZxAi0KmmHeLtjGSFQfkwmlbkWLYPe8IiBLmGEdZDRCxLHqtjdDSWZmH2vn+Z/vOLbM6hMJEGSUK2BgIQj9Zc1gORXxVbwyL4GtiaZ+r5yiZjaVi0GSneZAX6SjeOLcgeo2guTvy9vivtAlRQEu+HTBUznrDgVMQoNzjqmD5/m+L1MevoVTPDc1qSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duyx0+ALz8gkTQnbJkTxbICnPUi5pZZGzoIPTth4aeQ=; b=cOrYo/4JMYdV3pyeZYWoLzWd+Gx38Z5BJovSMDu/OK7fb1k8Yhj0bA3yj3LciiFrMTmadHKIntAyXChWAqHZM7ZBjzydUH+RDPNhYzFlA3jBjQscGeEYjdwDxQJkp/3L/NiDwE0RQqe2u5O2RYyqYAzADDVwP5+yzTEj5pOZDUYPgyd7VEnq8oN7CYfYDF41eudB2TLIV//JwdM3g1Y6Q4QvZlcwsjzViAHjtIll/9F3Z6WmMjd+1UzSJbqvyUPcNcjIFBdGblHekENI1hQrMbp9NeezEd15fWQnI1wuEKSOa9VeHib5etnvHoHVyE9CIpv6dTbFCoVVtFO4aeGl5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:14 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:14 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:03 -0400 Subject: [PATCH v4 05/13] media: nxp: imx8-isi: Remove redundant check for dma_set_mask_and_coherent() Message-Id: <20250408-8qxp_camera-v4-5-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=1059; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=IkEAaXIvaucb1utJPWn/OOEay3TWubA/0duLEbKaCEs=; b=Tabdn1ToWSVawSrC3OxWTdZ3DtSLV+/xNeRpF6qUjuMlus42kRlJZu61qnC53bKS9kT1U32/f rXXa3tafdiFAkVT3jolbDqHNjI1N5ZqrLfxQ9kNCCnA8bCX+Z/8/VRG X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: aa3d79c9-6f09-4784-fce4-08dd76e7e731 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?fhKPlp8nRRu6sVUIu6PaxawhkQYTnrt?= =?utf-8?q?9HFT5uKabUWI8P7Pfjy6uLJpM2Wg4RXyM9Eo9+U6txSE1IvG7UfargIfAdjm7btTe?= =?utf-8?q?6yQ6sxUJxkooffrwWw2wRnT49uAImNeOh82Jc3zAp3+E3sw2aqi0JNiS4avI+WnVB?= =?utf-8?q?jRbFvEHqbV+bkBWOKacCHCaW6o9R3lqJd7LUunUKa16+UsciaxkwOrsKJRB8mjZg5?= =?utf-8?q?kWg/e3J+fAM18Mk58fTWLd7j305lRupuCjDYrGEQHALuFz3OLX+pjnYgpXAVqB+Uu?= =?utf-8?q?arjcB3yflo9f0+WTg5GakfOnKnNSUBLu3sSuIqJMNyYhCy9/mU3axg5g9B9avWXwY?= =?utf-8?q?nMlTS0RE7w2RuaT81lumSGIR7BRVo5ycbFsQDeCheJb9WrAtkNzUGxUuXJd8KSvcI?= =?utf-8?q?Mc0q71ZvG2ag8AqpJBetCLvPqsfd3H2Mh4AHetIun5Utav8/vcRSATGvu6RBkg+GA?= =?utf-8?q?PydhXA/+avm3+zx5tqYIdzp6xk9N275oTQHyxJkUWMlhXxr1ZYJFkyvy0mL1NYT+z?= =?utf-8?q?nlzMH+oIFvgnAa3Rpwwdp3FidSMguvzATJFKEIMQAaA1y7PQUArlOyIEFynSkzs87?= =?utf-8?q?RQBaSFrdYxwoWjOU9gZSCPeB9lMjpjvOPKiDR5JDqlWfNANg6nU0BZRYCpSVGiH6O?= =?utf-8?q?Yf1hID+jCT09BEze4IN4vWI7atAD1nKy27L2EKX4bSdg8p+71lAI5KYKhcxbW19mU?= =?utf-8?q?KjRCUEve1aUY7v76kDpDNDeKO2k/xmsOa3ThIDkYLAeU4tsoabmASDpmKcu8PoP43?= =?utf-8?q?T81usSTWttJ5MskJ7cNmLvkyFBiT/M5eQ9XKbSxYo0F612fd8fzw7h/LqlRYS6FsE?= =?utf-8?q?1V95F7QeRWytaNo5A3Jcy1Q//g364kHKdhjhDz5+YlVTYXfVXf5TFwVK8xO+UrOcU?= =?utf-8?q?ELwqb92DEux5PKPK4GCL2E921cfOOZy9aqOm5AbBvbGuL5tEzQ4D2EDDjysR2CrDC?= =?utf-8?q?jHOveTw5F/a/8uVvqIsJH+MwFjOAEDnICjIrXGzSUYSrrZXTOZrRRWcN7pKujqZkG?= =?utf-8?q?hzCwXHjnAGIgj3UgyeP3ASpGfGatjCF1Lj5ND5b47vcwGFltoMO2FD7EZQi3DiqXi?= =?utf-8?q?6ccrFHLtbbN4n5Lk5UeUp1/BjJvJlFxHHdFlVOr3zizM+tGKXEL5IVFMQrPA0yXyu?= =?utf-8?q?vjkifxJOE11faUYtIOW8nhVXm2tlmgF1pGYTE7smfRa6DaVKUhXwE9RzDLKRkJEPq?= =?utf-8?q?LBHEq9SgN6A7PifoCW0l31PkikthCo2QtY3cB6IqZk0xo1HN6AbRMMM9YSX6xYwEZ?= =?utf-8?q?OchH44Se90qXCB87GVxayte1FWO8KgKrA1pQPP7jkF3JNrn3EJeQEGLuPnOMC0RY6?= =?utf-8?q?ak50rczN6i2xpIocTzXMGw5B0o++mNxpf1SLZdAvl64IZ71y1PZayO8e+BAqgLhdY?= =?utf-8?q?u8cTVm265B9qI9s/fSE010qxmJLec8W0Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?xcI7YhL6zq0oPtQ+NGlXVXEu3EGm?= =?utf-8?q?2aNsZswsmk86nV75RSR7TuEEjnisch9d8/A21xAl6vxJJkOg7evgDpz8SQitKQdhG?= =?utf-8?q?DXMXXU+Uq9WnXw3w8uJyVZ4oW+Tp1jBPyofJM7645VBGEWxWOwxPhkdOrae7RfSko?= =?utf-8?q?jUmU2nAyPv9tUi0ijyxMtP3aN3aNZaPgOcnTKTuMoz4weXB85JnlakU0T/l/OBUXF?= =?utf-8?q?xZlinOVYSxKIPVDqztLY9Mwi4TtapbwxFDefxtJ7j2yVua0Z46wC/vscRWl/U8E21?= =?utf-8?q?wEkgS9bZgj/LV9yR5FGf1tRzJCGU31v0KsJV9e8GoUZLefDVF4mQZNDIwxJauSGMv?= =?utf-8?q?sx71yE4ua7yqImiL8besWYKlNZnIh8z/9kb6psyRDAsgLQY6MfNr54kwrSA1wDNWE?= =?utf-8?q?TTTB9D6I5sY8KYXH277QjjMwNuN7+OTGp03lI9uwLdyotVjDlAd32OCG2O8PO0UAI?= =?utf-8?q?a38FoBa2nSsteN4ynFQL3/IyHwOi+PrafwU9MmmwTriQyq7dJLGSQxy7sf57O78zX?= =?utf-8?q?LJXadOFiNyt08HvWay9xYuY6twFto0Bi7dtk8/diruQfIJeneBio3Yq51BlqHtHBu?= =?utf-8?q?Aqg9Ywc0AwEVSjqKfUWcb+nN9m7NUpDqIcOWqf/cWzViYPgJMqNO8MulhVbTpWXsh?= =?utf-8?q?KuyJQkSt9fhHOwcA18qSk0zCXR/j1e2q8WUP4EhYQ9NBln1b25FbiTy7BWzrMFVgs?= =?utf-8?q?fegJomd5ksm73YUTb1GPR/s6M89/e2IufJq8Bw0k9FDSxdgzickTLYUCxuQPU3cyN?= =?utf-8?q?q7UU8jMPUZJW6e2esmnRJvy9YlOm/0uwQtm+tosGuewWOL7afcCvm6nXhEBCMoQrq?= =?utf-8?q?D9gOhDrpyeksx7gCeojBybMX3JVZxSoKCs1Y3nUbadQmH/HAB1MbgYYDQ1eeuQygx?= =?utf-8?q?tPY/zFZU3V0FB911QfhRspRKFcWgTA6eJYMIH2SxJ02Wwt+6p0R24pr0/p7mtkkKW?= =?utf-8?q?aQTcCe1mEq5hj2fNkt1da/QwEXsiL/S8NDnfH/OLfXBz0UOCjB7aRFiiEHdBHBdrL?= =?utf-8?q?NO1txcGisZRZufW6Ng66hbKfSI6AXlOa6W+6OYo5MertFx8PR5puScBW37ATlllQY?= =?utf-8?q?4/152htLfVdLGZEDqfI2Pw7/prz14nTPaVzSIs5Ux1pptg+3BHwSe1qzTG5vEG0XZ?= =?utf-8?q?2SWGTTVWAO6Iioqkdy/Q/yewwakeSvgOs3oyWPqi++T1QjE0rhMpXJAzS1aKuJTjQ?= =?utf-8?q?GrD0AOkQ8yOhgANSOGozb37xmTqE8w6oBTX77mJtCbfGNjqBhWVCtSetkAYGb5z9i?= =?utf-8?q?ifIWVQXqmPEqdaYwuVYmGw+mQzguDoDYpuYcSb1GI9PeRiXPmzcv9LvVSUOvDpHDl?= =?utf-8?q?4RCbd4coLdDZvv6Uc7iT2eNzuPLMSSGTZqiMZRJZMr/CT9QRam1YWnvUIsc7PgGk5?= =?utf-8?q?OrrXKqppAoOa2RRG+xYS5yq7eM3wtKWWMLcANXfSMDbFQh9JWDdW25kRUe4+s9r/6?= =?utf-8?q?MBoEvwd/iE//+zsZLVXqbuG0fYcezSrZ80eBu2OxdxymxQ6eqct2jJJQor2FqJath?= =?utf-8?q?UVuXSSibw4KY?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa3d79c9-6f09-4784-fce4-08dd76e7e731 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:14.6704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H781xgVTqk22X2WXE0l7o4I0xsoGc6FrGIOi8ydj+evIuoX7QUSVWZwzYPWbopTAKpHK5GMFyJZUy4pwil/35w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_145418_099258_8AAC3319 X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dma_set_mask_and_coherent() never return failure when mask bigger than 32bit. See commit f7ae20f2fc4e ("docs: dma: correct dma_set_mask() sample code") So remove return value check for dma_set_mask_and_coherent(). Signed-off-by: Frank Li --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 015350c6f2784..073ea5912de3b 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev) } dma_size = isi->pdata->has_36bit_dma ? 36 : 32; - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); - if (ret) { - dev_err(dev, "failed to set DMA mask\n"); - return ret; - } + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size)); pm_runtime_enable(dev);