From patchwork Tue Apr 8 21:53:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14043771 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBD50C36010 for ; Tue, 8 Apr 2025 22:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+T2vCWDs8vHqngH/at9Qb/e7wkZP+AMlnAipwWdUNY0=; b=dp79EroqRx5p/RjHXHXDuK68I2 te5P15hDn4J5Zs7ahE5wxWon87E+zgmLiaVHTXVnG9HQMd3Sp/JbOV6PEjk68IpNNKR/Awx6h228W BD4YYV6KmWOkXL/M+aIRubtB5uvxl73RNxPYp9UhkXCIXM2iH/4G++6QlO64hMp2k7iGqPpWQ7Gmb 1+MXwnDFg6aAGrjZstwFgP8esH6lsd7rDhsjW+x1ErvC17G24aPG+DE/90Ue4Uo6W1G7srbt2iZQ8 3KNXY3cpK4LizSGxlMAKtzcatLo6JfwGnIoztcdVxiuRYkYAgBfjSnOu7QZZ6nkP5daoJN6NI87WW 9wvuTW/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2H5b-00000005WjZ-1lgE; Tue, 08 Apr 2025 22:06:39 +0000 Received: from mail-db5eur02on20611.outbound.protection.outlook.com ([2a01:111:f403:2608::611] helo=EUR02-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2Gth-00000005UXl-30pS for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 21:54:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hei6kiu5WFSruUOuQjlLAdJJYwDmNuoXxAeYVhtYkwqEdQSq3R/lYw1gYundnWPgykHxgfxZ9ru0sW5Ev6XTCHHDKjSPT/T/PvWXEPViTc4OPYe5HQbaZF07cJys73SeEfHaRczN2vzw3TjGNK6TdGsbp6CgD3Rh5OvSZuXoX65YK5ekGeFFpI7/gC2pY2MuPBcZdIQjP/t8OTvDKaGW5+FKMGdaUU1lqZRRnHFEBHMBkGQBx8U60cnXOZFXa9e1tVG38YqiG62rvlosfK1kQj5TJPxlOntKB1xpwSbs4iHOwZAOUGBr6ziVVO2tww2Bbe0XtxP9RrmyP53Bc5N/Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+T2vCWDs8vHqngH/at9Qb/e7wkZP+AMlnAipwWdUNY0=; b=NrUnEj7kVneaNox9JOFKRqWJidfzBK/FlC5ddCMgSZVnGxvZH+U1d+7n9NCX+GsS1jt+vuR8KRv8vlViAs5Fo+H1YMbntPIXEkfVdl6Ldl3do9JSBaHALs9AjAiqxYSZ8Q4DJ8RlFncuk/bUQiVNh7vzHG2CHmt1BkGhLXTZpaAsR5sVtU1fG5a+1q1gaKZpO+mJ1mLjxDWgSe4ydNrAYrsimVXrocakXf3frrARm9/7Jy6GFjGEsEI0ukJdN4oropAgGH5BndLc8Yx2mulf33sXcEfes37q3nclh+GmZP+Tl/v8EMR+BnbmEEf518uyp3j9gOxdE4cM3HxguztRlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+T2vCWDs8vHqngH/at9Qb/e7wkZP+AMlnAipwWdUNY0=; b=M+11fB2NaXvchLIirUjsCyvVa8C76F04tS27r3NNpZGiYAqcGRRAP0mWFY3fWTxRWxHskoFsDgINbrrMV1MYnSPrmB+8EbxfdswTT+WKb9pqZtxSEVFb+HIEsm+3WFCLDPUJ0/Z6BBGMYl60+vXdubBijSv71Q6mlkhRBOIFgWAXhoDB/zZCM9A4wqpzIy045Dcx/WmoR4PdVFy7x3NbmAkbYiv9zb1fvyQ876Co+FqeLkysCXB/XdFr7RiJFfRebO2sLg8jKE1zazVYsE1rPg2+UKhVLWux22Ubg9t/qw0e4EBOPyiWcGZlcaDy1txJANneKaHFg5Qjtf/FS3MMHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB6993.eurprd04.prod.outlook.com (2603:10a6:208:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 21:54:19 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 21:54:19 +0000 From: Frank Li Date: Tue, 08 Apr 2025 17:53:04 -0400 Subject: [PATCH v4 06/13] media: nxp: imx8-isi: Use dev_err_probe() simplify code Message-Id: <20250408-8qxp_camera-v4-6-ef695f1b47c4@nxp.com> References: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> In-Reply-To: <20250408-8qxp_camera-v4-0-ef695f1b47c4@nxp.com> To: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras , "Guoniu.zhou" X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744149229; l=1421; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=JVcBDHXKyjksqu7qIzz9vxx7gKd9zWNURmLLuL16DR8=; b=ZVkcr9VeI+3SFFSmnx+FZ5T/+YNTKDA9vK/hrbZgXJdv5jiwyPKsGQRWV5RA49bnmuzzjtc5V hQXBOrfy7NyA7tuqbAKJMizhcC9yic1oNhZCbi2MuYRGnrUc3gCe3P5 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: PH8PR02CA0047.namprd02.prod.outlook.com (2603:10b6:510:2da::8) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB6993:EE_ X-MS-Office365-Filtering-Correlation-Id: 7522b18d-0c26-4bbb-7e19-08dd76e7e9bc X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?YIHqE4BMPtH+NRcqCAimrXsx1wOllpb?= =?utf-8?q?wJ87msQAwHTD84ECPRqyNTm1gr6LgRY28Nv/av/B3MgOYXZOu9swV+XHxetghGmOO?= =?utf-8?q?cPKG0yNIwDtIOdLEkvi82O9pj+QoYW6fIHTIQddh1ziwiM3lCHlVd/tB1WdoegeZc?= =?utf-8?q?2MYoSCvm4Pei8Mvo5JQ7gbUNxo7oCqSnwvWpY/zF30ehNygPlAiAPKdDGXdKyryPJ?= =?utf-8?q?6BScCwDf2qhw37GXoRzVOuHwftE6RPn8RfW3e3djOagmPgGmk41jkAcHx7YWSkzWL?= =?utf-8?q?9+PxVV5fNzQnNzSfrQzgrSZNV83LEHMYQMPYnfA4S3NRTOl5UBTn6dbVMKyvRd8HF?= =?utf-8?q?rMx4x1mcAmdHN4xl+SMZs+E53JKn63CVtYwxh7EJHOt85Y/CGO61oWbKjOaAP+XE7?= =?utf-8?q?8btGjq5hvph4nZpuG5tzjKmbQ7b8a6a+6+6pTEO1ziQWOZg+85YHnf7KkCEaQhS9Q?= =?utf-8?q?2Y6SPkN9IG6O7XuQ004Ih3bzBKGWP1iwcxCwMdICmqxfpdAH/a6zmidbEmUCz8cP8?= =?utf-8?q?alrVC8yfhJKyEhi/UbK+OaF3yVqh71keI7TxwTPulvBKp9EJt+tsSSjR7tkoWNPF2?= =?utf-8?q?2XEPxM2t9Mf9xfkgRf6FgU1Uqpqdzkv2kyyr8w/wv5r0K6WvV88kwfJ8cZ1inf4pR?= =?utf-8?q?sMqsedkzldy6Tv+3L6brx0xUyd2tmcHtFrVZ7fl5FetM9v6D6P3/xjTwJchsnVhhM?= =?utf-8?q?epHt7C5BP/8IUZ65HM2bOugr+GTu41Kcp434+EV1knTZmNL3hFABSN66NImEJqL4b?= =?utf-8?q?UDQYT7YDWCk9Wup3Es6bjJ/cWixVnjgGbsuqKptX4GrcKkjeEGBWXDdIQlnK79t1K?= =?utf-8?q?YwRhVshCzcCQtk2LMHlEbnoKzskt6sPMlGNtzSOehRfPrlHHkvUAc0iT9BWxXjArM?= =?utf-8?q?1yNmLajQjT58yUYjO1S8HmNsTtVuiSIC2fsDWZVHOGvj04K8I8Tnifqg2yrMVpd9i?= =?utf-8?q?jNYavLe4hjD958KIpxKvEaFVZxHyal+BSlXEEvtXlWJ6BQGdPLmzsFgq6werUIBTk?= =?utf-8?q?jlEw1AHsIFMAxzZURCYhCjIAWdGfQIHko7zzG0jazuZUqlwljT+63C9UfpVQswJkz?= =?utf-8?q?x7w9nSmDXRGgHDPlRg3hMEaZNZk9Xw6G4hNCiC9XuzP0d+dgsbb61Q4+XfoBqew0C?= =?utf-8?q?T0994S1KeYNz8cIhx21K4AS9L6fzgkXiBmFboUfhmaDQ6DtcWNkDDPKwJwqA/4bxb?= =?utf-8?q?DJ3dKN5inbG8htTuTiBSQ61fMafl59S3ug8Hw8ypciEuHV4xpE56gGqTt+xaImgOM?= =?utf-8?q?T2EZ45UsiqXaMWPL4gjijFhtqVY7oKCO9k9e/nzkTxQyEFONXZ06gyI54Ok5Unqp5?= =?utf-8?q?WGJvsVsSw08R08rJy+METHTfROo+btVPsu4U/sp5Q6uE8FLbHnpOC6mxU3o1yLF0t?= =?utf-8?q?hWNrFgXrA4PV4Ff9JKevybaSeVDlO1YEg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?EgbVd8Wz/ccSxcr2/rMJzEGfpbcL?= =?utf-8?q?Q9bcUIi0Fc+BCPqy5EvZG1CJ2dYW+Q69saBJX45mLW9v2T3+7crA6gG9svEPVPrOg?= =?utf-8?q?I2VXse1d4lw0TVkeHOAyRrPBPlfA45rJuSOU5WhBIAmvkGjNbUCbD75UlDSp3dQ/r?= =?utf-8?q?I5Jbo9svq0M8OGlCD9ipSbE7b9GtxQI/D86YLF3aPWjTJ6KTyF61Uc//Q83V6dxhj?= =?utf-8?q?T45xRAAcwnBwZmTQIz+wM208ux4pUm5T9OisrymeVo0OiGeSLZ8WxGCqdbygJEzUH?= =?utf-8?q?6iWB9MR9zqusEDjLYvBrNYHxV71mUg6rOD6B0HfAQ4xLyEZgx5G6fSMKgamrGPgzB?= =?utf-8?q?NXJUV8QY6PrHNYLmtm3b7L78CDGX0VCRM9hVIen5dMwvoAQbT3859cp4iuYUszD2J?= =?utf-8?q?/FaSnMlEldOECd+cEif+3i11AQv5I3W9bN7+bkg6g95gBeSccMUUd/9Fc1lc5drhe?= =?utf-8?q?XPVWBs4JhqXAtd+KR5V+znxd7GYN5zNV615WB3nIXVGNtQqpdSd2Hk2r02SfiABSJ?= =?utf-8?q?9QaF2tJRUDoqojn870w/RfkOUNauf9u2789/NiMGZF8nPRr8j0nuZYMQm+9PIqgWt?= =?utf-8?q?1Ow/QBJ72tNLBz7zRfSpnNvZMDj1OdTxQHIsYzis/naIrAm4+v+7H42olpmDyOcxt?= =?utf-8?q?LUGjlr5l7Btc1sX6TxpD5DLW3K//2RkIvLfSLiUyqR490+ksjlpEkE05wmHzIrG/+?= =?utf-8?q?qL8fzdh/ZRakam7KqQVDDe53AYW/6ghyjOpGjemk2q/8NIEs/3mTI5I9JXWBq17zw?= =?utf-8?q?GyIrJMfuFjHwrbx4c1PlLN0Wxc9zvYZjS0Tehz0QNIMK6axRmHOM+Etmqa+mR/Tsn?= =?utf-8?q?R1Gm4uAbwJUHpwSfxUj2PHZkdOt6fSHKTnkF6+L72vhmvZRXJXmNR8mR0uYublviY?= =?utf-8?q?Mb18wUspiZg6O1yy+ifflmpKEcEtgo2EhVmoa0/0agC8H0+30eyrUnLc9mNtN+dSk?= =?utf-8?q?jzZxxG4pzJ/R9/372WS5S18WSTzcijsGDB96YbvRgWTPKYwY1N8o7Nga+0eM1Pyet?= =?utf-8?q?cqUy8ZWkJRAbRp5+yjxo2EeclWp/sS6BLxa7uOw1UIoC+oHOt+hn7y9pYs08IornC?= =?utf-8?q?A1POkJul89y5e6XLcKtlDgNGx0ExIAeBimgUL5HzDinDRL9IIrGkKdf9+M2qeHVu/?= =?utf-8?q?H/qLIw9IIvJPPqmfJ09qb3DCddkgU9QcBhgutj1ZFRi+UbHbqAjoax2qXnkquMbvy?= =?utf-8?q?jyfYRCibR8hv54KjFjwvsUsdco+4NaWL6P7Rdp7nXl0jlAC62tf1YUna/TtebC+Xr?= =?utf-8?q?/quWrrLEPOG66Lq3e682NoY1fx3SxFYrimVFLH9jt3U8cB3hhT+8UHG8Otu8sOx6K?= =?utf-8?q?Jc2pevVYVFCPhB3SPslwSKBKxuUaNCoXYjLFzMara3RwLV+w+gg/YtwL/m1HXFQ9p?= =?utf-8?q?/Uii2wY13TyxHzyPGSL21eVdy7ERwmFOJ0MWHhgemmxBO47X1t1SBNj2pA1iMSmd3?= =?utf-8?q?clzEBMzw6XCUzL+8UiAtfBeDODzPsVAPPfXVC6aCudZZTqm4z8l3TxqPFK0EhmvLd?= =?utf-8?q?bBr+v0KGUub0?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7522b18d-0c26-4bbb-7e19-08dd76e7e9bc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 21:54:18.9890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zxAQLACspjhR8fUUhk07JHo8mt9mAbeltC8pX1bZKTyF6tr4+LBAK+j5KsTblquaNaIubKm4Ez4mvq8Xb0X6Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6993 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_145421_760760_8F5B15C7 X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use dev_err_probe() simplify code. No functional changes intended. Signed-off-by: Frank Li --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 073ea5912de3b..398cc03443be3 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -428,19 +428,14 @@ static int mxc_isi_probe(struct platform_device *pdev) return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n"); isi->regs = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(isi->regs)) { - dev_err(dev, "Failed to get ISI register map\n"); - return PTR_ERR(isi->regs); - } + if (IS_ERR(isi->regs)) + return dev_err_probe(dev, PTR_ERR(isi->regs), "Failed to get ISI register map\n"); if (isi->pdata->gasket_ops) { isi->gasket = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,blk-ctrl"); - if (IS_ERR(isi->gasket)) { - ret = PTR_ERR(isi->gasket); - dev_err(dev, "failed to get gasket: %d\n", ret); - return ret; - } + if (IS_ERR(isi->gasket)) + return dev_err_probe(dev, PTR_ERR(isi->gasket), "failed to get gasket\n"); } dma_size = isi->pdata->has_36bit_dma ? 36 : 32;