| Message ID | 20250408-rk3576-pwm-v1-1-a49286c2ca8e@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Rockchip RK3576 PWM Support Through MFPWM | expand |
On Tue, Apr 08, 2025 at 02:32:13PM +0200, Nicolas Frattaroli wrote: > With the introduction of the RK3576, the maximum device function ID used > increased to 14, as anyone can easily verify for themselves with: > > rg -g '*-pinctrl.dtsi' '<\d+\s+RK_P..\s+(?<func>\d+)\s.*>;$' --trim \ > -NI -r '$func' arch/arm64/boot/dts/rockchip/ | sort -g | uniq > > Unfortunately, this wasn't caught by dt-validate as those pins are > omit-if-no-ref and we had no reference to them in any tree so far. > > Once again kick the can down the road by increasing the limit to 14. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > index 960758dc417f7405010fab067bfbf6f5c4704179..125af766b99297dc229db158846daea974dda28e 100644 > --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > @@ -135,7 +135,7 @@ additionalProperties: > description: > Pin bank index. > - minimum: 0 > - maximum: 13 > + maximum: 14 > description: > Mux 0 means GPIO and mux 1 to N means > the specific device function. > > -- > 2.49.0 >
On Tue, Apr 08, 2025 at 02:32:13PM +0200, Nicolas Frattaroli wrote: > With the introduction of the RK3576, the maximum device function ID used > increased to 14, as anyone can easily verify for themselves with: > > rg -g '*-pinctrl.dtsi' '<\d+\s+RK_P..\s+(?<func>\d+)\s.*>;$' --trim \ > -NI -r '$func' arch/arm64/boot/dts/rockchip/ | sort -g | uniq > > Unfortunately, this wasn't caught by dt-validate as those pins are > omit-if-no-ref and we had no reference to them in any tree so far. Sounds like we need a way to disable that for validation. We'd need a dtc flag to ignore that and then set that flag for CHECK_DTBS. Rob
diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml index 960758dc417f7405010fab067bfbf6f5c4704179..125af766b99297dc229db158846daea974dda28e 100644 --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml @@ -135,7 +135,7 @@ additionalProperties: description: Pin bank index. - minimum: 0 - maximum: 13 + maximum: 14 description: Mux 0 means GPIO and mux 1 to N means the specific device function.
With the introduction of the RK3576, the maximum device function ID used increased to 14, as anyone can easily verify for themselves with: rg -g '*-pinctrl.dtsi' '<\d+\s+RK_P..\s+(?<func>\d+)\s.*>;$' --trim \ -NI -r '$func' arch/arm64/boot/dts/rockchip/ | sort -g | uniq Unfortunately, this wasn't caught by dt-validate as those pins are omit-if-no-ref and we had no reference to them in any tree so far. Once again kick the can down the road by increasing the limit to 14. Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> --- Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)