From patchwork Tue Apr 8 02:59:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Zhu X-Patchwork-Id: 14042107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F650C36010 for ; Tue, 8 Apr 2025 03:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IzJ+4AuRn2P5jpXCGDnX1KId/yylUIGQK13gqDzlVjs=; b=026/KuGPePM8YVEVJsT6Bbc5ED rvRxZs4b/jou5HoUUEcp+7Bx2RLQNbKEa2Sk1162F6nVN/WR0gF25GCgiWAKiU6jO+Xs4X1XbGUDT mt+JYjZW1LBAngKGLR8yqERxn04Ne+8b5/U0QdnzAS0TbnwndsLZ9j2krav3RTvIP6ljmJ+0WLnQE An9urPCwUEERMMSeFInmB+eY7T2GVC9iOPoENjX0+gkOJUO+To3icl7bBpXvF20BC/flp9uAcYuzI B9s32iL7jV/aPZTZYIGPTSu23Ofm9Dikn7KF4v9J70CdCZCXTRIpQSjD9Os2GFNQI+SUN4IOq6cXp oRP+p0MQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zRc-00000002bXg-01y6; Tue, 08 Apr 2025 03:16:12 +0000 Received: from mail-northeuropeazlp170130004.outbound.protection.outlook.com ([2a01:111:f403:c200::4] helo=DUZPR83CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zD7-00000002Zcl-2BXM for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 03:01:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PdzdZTpKHQO0biUoxKIsrnmkS06O1fS0NX9ii+NtuGkWX06wdP4/7Tr+o+QTIxUHp6pjbffL5SUuYKL2jSt5IH2FhAGc17XO1u9OYrhyvdri9XFox/8k3BtZoXucWD2Pdd1DCukFeTOxtwD6pkymQMsWCIDhWHP5fjeH9wGeVfmYF7S3u+Edia2ejZMT3MDlBXNEk8PyBVwBSZ6lEYpV2MURuvLrmaFt22LvqpPw1BQSKqvYbVUjY5Qmcv6ll926SzXuPPKyJHpc155AYi6l7/8X39MuoUgqT3YZsvAb+Gka2q0gDC4//AcDs4BTy6932cI84UlCCc/4EqDOxKsXyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IzJ+4AuRn2P5jpXCGDnX1KId/yylUIGQK13gqDzlVjs=; b=QtCVrJHZOcVWdIScceWQBoqGOEyb6XQOft1JyyGyS45lORrh/jUzfs+edufWOiPNfs3w54sNn1/hnrw8pKpmwHV1K/Yg6/1nrGdQd6j7CXRDoFbyEyvIjXQLKBtzp0Jva5XruSGhAOBbd66ImlQJR+HnIf0Oanf+5Ws7H4KmjZWZhyIK9ZvF57ZBM/63Bc3DtK3brh87l7gycrYdXNaUW7+/cQeL1j1mOUQCeownUg8YzFJqMWu8DJ1YjgrSnTC5q0BkqG+kkHBl5znud3twXFJ+A0iB7C2vAo+qZfcwNNv16Of/yByzH3gpgo2zgE/ls8FW1BSsG8IBIv0WTf7dMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IzJ+4AuRn2P5jpXCGDnX1KId/yylUIGQK13gqDzlVjs=; b=BjDY/CmL5yaYitqT3jk5QUgpLri2s+Q0DJc8+cvIv0VINa5l2RbkOqfJmUbZCz1DIG+1HF89/fJsL2ZnVSJgZmbE/8cl9bg9ivNygiW0lVLXHEc3emRX/eFtw5uk1iE2GCUH/SeAxd/rxtKJlDss3lK4Qx6ykb19jcvnCQ/d5OtiGzj3WZCEtrZ6dGPv/OSRnGZkPkGMb0mp7uEUfgIaQscMswfXPz6k3slOaQF1WfGPaxvgAnXE4zIRv2JI4VfjUpYwR1NACiYxBrRFs32Z3U7DkNNtwjZExBofVH999TtuNB6/I/RckH3yyQ/V1i2TVk7yFW3sX7H3qNjz0sy8mg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by PA4PR04MB7536.eurprd04.prod.outlook.com (2603:10a6:102:e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.31; Tue, 8 Apr 2025 03:01:11 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8606.033; Tue, 8 Apr 2025 03:01:11 +0000 From: Richard Zhu To: frank.li@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , Frank Li Subject: [PATCH v5 4/7] PCI: imx6: Workaround i.MX95 PCIe may not exit L23 ready Date: Tue, 8 Apr 2025 10:59:27 +0800 Message-Id: <20250408025930.1863551-5-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250408025930.1863551-1-hongxing.zhu@nxp.com> References: <20250408025930.1863551-1-hongxing.zhu@nxp.com> X-ClientProxiedBy: SG2P153CA0051.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::20) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|PA4PR04MB7536:EE_ X-MS-Office365-Filtering-Correlation-Id: 49506467-6623-410f-77ff-08dd76499dc8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: KyMqDYh2W+elybYYT/JLmXWmGJbVunqsR7luwcum1KNF0ZjfR8VayjQON12Ze0nN1jetoZmxj849qONBe2zNoif9eGmk5nkDuGEb5jdM2Ii76rxQVU7MBJ2IVWRsJjHrJKdIqtsnRZDwam4L1ytVsj3HU2Z30Bx4mBNPJSANnqje6K6YpiFc2Xw37drH43uaWYT0ZcmIuHqkDzEvmMDxPbARpm+dSKIu0Wk5hfQhCBSg/NewYB3GiUH/tE+0np947o2+P+Ag22Ai08yAf6CmLLL7KT5XCrOCfrduskfIzx7U/EPmoMfwmYeMugy6B6I0/P0Kyvf03ywDoGXy6LrZgoZSQAi+qzkDNdtt0hfrZ0adDT7aqr1srvMs8jZzzL+AkRww2s8LR3MPolaMtfF5NPyTDwCeRQ7ORTf2CZJjGntWx/QoW0/ReJy5v7xdB7w1UqVQRldkh5jAzI3Fc1/R5qOE93FweT2SgUu/J6f+mrTeqQvfq6EKqf+eH0bnFq2pE7GU8I/8QJi0RIkv+BXvL8xBIL2CIwvOqknq0k/J+M50sxJo3o7CBjbvWNl1a2wCSJOUgnNZECigumiL7slrWx13pNxdlKFtaKob5Eq3pdxEiIaXTgSF5FbyPbao7KSx0DPlBQCpsxqiN2Tzvb/TiaBX5tf5TdIB/vql3jbI3Z7/kI5l8f608kgtLEzR8cuiwxE2BrOSkrgmwmtPBJVrN+dWDeo79eco5VV7kitR4JJjQ8eTRdK/It1ScwPURmy18I3L3XU5ZZxo0hFIYmE2m06qJab7OOuTlDaspalM+9SDPcni4iWbTeHdI2foVGtv9dDyhEDduVkK+oZE0oOvPxT88HZx/GxzzgyjTw0C79EOvP+XwJ2qja9pEPWL7cgkCLdNb0MYeuqEu1GTm7tOd+m+F6gDsPkNEi8nf+IzaDlvOCARDbCUVU95JQi9KLgGB1b3q2ksWRpIkZuFCaUS66Gd+7k3+P4CksRcRQlLoOfLKJN/GZ30jemHPV5EgmqjOybfI/+LIbUcAnsXID+04hNhieLOnotp4s6QIaZDeiZccHUWQ+kdvDNQtwSKCAorEf6jLbCcu/g5q1CbAKj/j0Cxg+IXY8S+JtcqZYbNABHYsoYO+k3sTktn7N9+oatNmcACpkJxuBzkTFKR7MBah+czxuFlk73saiV4E9PJhj/2xdbuepE/sQ7Yk5RHovBjAeXTAg5qE5EAK4M38QoSO73P1NS6i7zZAmtV3kSrTmFLTfYDoqxgBiU7H/7bx5ySBK9iCxuMOMtT2ybLXg2eIkCl/nBYHbq4Bk1Vbj4/u51I18tdJbXJ8m/3NjAQdcyeVHN+ri7wknE9HwnGM0lwQ4KcNbbPiJ6A6PQigd1+UArerlIXLUwI+xQ62a7I2ijsWw+CBBhCsuk0D7goTBEoIMmWzCx4w8xSf/YzroJbpowiXbBIY6A77R1v/IzR+rkYK5H+gOP2jztw39LK/RYmSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k4LJkJqUKhB0Jr03/JBKOLP9gYQeGsvkqGdpmwcIUSPjQAQu5WfNNPiErljlw9daqiK8EpRo+UNBdmvJIcKKP3GlW8RPe2Bvx/zbGirEx4uDo/uYp+k72oyGRu/hRj8V3l+qf5G5ouQ0pu9Rukp9dk4RcT0uFX2uIGpEG0FdkzQ9wY8FQ5JJVOWbxELveFPeNev+itGAtJnxvAoshmMzrzd3mULhv7AZpyTJBICmtYI98sVPXIzX79NErogMgNZVww7HXUjUAuBFZMH/qZM5SWebReNmin6BQtH6wfriG3arMYX/dPs7aDvDhtLe/MrS4jcX9B9HrdVV9+9fHVpVr9plI75exLxBt0GqqIKVSpDYDgtqLYCiZFEgVKU5OblAEHD3ZD9ltij2s88FZMji/37u12i7EhfZ9wDfvXdPPmVoUdmqmAdjpPx+YLe8r08gBJ+DFcyfy0bAjhAOl82i4Z7zF1/iR3bq/bC0ZfVMor3VeHlENl/IKtV0dSaHQQaXhUfKDavllaDyc5tPdG6nwBUwAeLtKVZ+BF+6EFcjMrMifHxZEmhHzuTmylfQGl8Xdwewa+0dnUZPGXduOoBLeQZjudymtnY9MPEupZRvFewBBgNgMesoE/RyaZALqri341UfDeftD5ZZKpKxwWZOTCVoqrXeSaeGT7zAaQNo9UeEPwGMExm/mkyjzADZCXX5qB45ZJ1albAlpxIThMc4iuHFthD8XMxR3uCUscKgsAAxBcHoSFjb7Yp1GNtYPeCt7cwrh/upra0vrFQMuvIzrv/zeZNdiHQQJNccbI9AKQvu6WtpCKTr1OR8fS5X1onCnN2Ow9Y5p2EW34AMHJDL1BfP6xBShKqV5qfSAqV9zGbvDgSs16lKn02paV4lgYR42Gk3pY2WwVDtYOVNYHzR5QozsRxjMdxy7Y7MHXzlhjA/PJHAn9oK/LjmYemcTcouDT3+gXOX9yrv23IUirc3IueKuOsICT0asU8UU2EzJnIpLTr4x+eCVqy5vZervRhthjWl++1LHryA42WIbOyUKtDViac/jlsRWnHbybFmlvzAz5BNpbEFlgRvdLpzrm0iLq4o4Tfsgu6iQZO6v9GohiQrYas5S43/w4xrhg1tNQ+YSm9T572lzNXDPPW5CvIs5ewZ4Q53tLt+3lh9s36t+jY/z9UdYnY3AjvwL4/yHdob/QD3X3wSO1HGx3/1IaofxwMjZeajiEzDoVAKrl+ctkcyNtWcs0Hd/35cWkcjfu3LGNQr7b1J/Qr43j59c3+UEn0SCp4XN+wgwcaq/kCUwWNmeYjaYVmglCU2sQkVqwQFR3/wA8ystgRYVMaNlGtCwohrsurlhK/foVnueu5Mtex/qbfrzsTRCouDL67mjdUtewq9iKGOTs3lbVImhuw7EkDUuoToS5sB56STC0AZ0oTMJK9+uuhnOoX1uhP1R5dLQ8ShRox0JomWo2n/v9jDYq+HpMPHcOkw5kxE3Pz55wWirUdlj4nyP7dr7QS+gg55HePsuDMt5aWjeWbMVISrnIJuMW2tFUjFpQD+ispCcHG7ggqHN6sI/xjdBq8f2kphUl/pQMXG115eYRHUi/GY X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49506467-6623-410f-77ff-08dd76499dc8 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 03:01:11.0925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cm6k+EFtLpS2byDEZvmkfRmk2JLrE9c7qY1JAIPQnYoi9/DE7ZoNIuhjysqrSfEqGI0ppdj8nuhJHKCK66hRgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7536 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_200113_558796_1E4B6D47 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ERR051624: The Controller Without Vaux Cannot Exit L23 Ready Through Beacon or PERST# De-assertion When the auxiliary power is not available, the controller cannot exit from L23 Ready with beacon or PERST# de-assertion when main power is not removed. Workaround: Set SS_RW_REG_1[SYS_AUX_PWR_DET] to 1. Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 7c60b712480a..016b86add959 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -48,6 +48,8 @@ #define IMX95_PCIE_SS_RW_REG_0 0xf0 #define IMX95_PCIE_REF_CLKEN BIT(23) #define IMX95_PCIE_PHY_CR_PARA_SEL BIT(9) +#define IMX95_PCIE_SS_RW_REG_1 0xf4 +#define IMX95_PCIE_SYS_AUX_PWR_DET BIT(31) #define IMX95_PE0_GEN_CTRL_1 0x1050 #define IMX95_PCIE_DEVICE_TYPE GENMASK(3, 0) @@ -227,6 +229,19 @@ static unsigned int imx_pcie_grp_offset(const struct imx_pcie *imx_pcie) static int imx95_pcie_init_phy(struct imx_pcie *imx_pcie) { + /* + * ERR051624: The Controller Without Vaux Cannot Exit L23 Ready + * Through Beacon or PERST# De-assertion + * + * When the auxiliary power is not available, the controller + * cannot exit from L23 Ready with beacon or PERST# de-assertion + * when main power is not removed. + * + * Workaround: Set SS_RW_REG_1[SYS_AUX_PWR_DET] to 1. + */ + regmap_set_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_SS_RW_REG_1, + IMX95_PCIE_SYS_AUX_PWR_DET); + regmap_update_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_SS_RW_REG_0, IMX95_PCIE_PHY_CR_PARA_SEL,