| Message ID | 20250408155321.613868-1-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,1/2] net: phy: mediatek: permit to compile test GE SOC PHY driver | expand |
On Tue, Apr 08, 2025 at 05:53:13PM +0200, Christian Marangi wrote: > When commit 462a3daad679 ("net: phy: mediatek: fix compile-test > dependencies") fixed the dependency, it should have also introduced > an or on COMPILE_TEST to permit this driver to be compile-tested even if > NVMEM_MTK_EFUSE wasn't selected. The driver makes use of NVMEM API that > are always compiled (return error) so the driver can actually be > compiled even without that config. > > Fixes: 462a3daad679 ("net: phy: mediatek: fix compile-test dependencies") > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Acked-by: Daniel Golle <daniel@makrotopia.org> > --- > drivers/net/phy/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mediatek/Kconfig b/drivers/net/phy/mediatek/Kconfig > index 2a8ac5aed0f8..c80b4c5b7b66 100644 > --- a/drivers/net/phy/mediatek/Kconfig > +++ b/drivers/net/phy/mediatek/Kconfig > @@ -16,7 +16,7 @@ config MEDIATEK_GE_PHY > config MEDIATEK_GE_SOC_PHY > tristate "MediaTek SoC Ethernet PHYs" > depends on (ARM64 && ARCH_MEDIATEK) || COMPILE_TEST > - depends on NVMEM_MTK_EFUSE > + depends on NVMEM_MTK_EFUSE || COMPILE_TEST > select MTK_NET_PHYLIB > help > Supports MediaTek SoC built-in Gigabit Ethernet PHYs. > -- > 2.48.1 >
On Tue, Apr 08, 2025 at 05:53:13PM +0200, Christian Marangi wrote: > When commit 462a3daad679 ("net: phy: mediatek: fix compile-test > dependencies") fixed the dependency, it should have also introduced > an or on COMPILE_TEST to permit this driver to be compile-tested even if > NVMEM_MTK_EFUSE wasn't selected. The driver makes use of NVMEM API that > are always compiled (return error) so the driver can actually be > compiled even without that config. > > Fixes: 462a3daad679 ("net: phy: mediatek: fix compile-test dependencies") > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/phy/mediatek/Kconfig b/drivers/net/phy/mediatek/Kconfig index 2a8ac5aed0f8..c80b4c5b7b66 100644 --- a/drivers/net/phy/mediatek/Kconfig +++ b/drivers/net/phy/mediatek/Kconfig @@ -16,7 +16,7 @@ config MEDIATEK_GE_PHY config MEDIATEK_GE_SOC_PHY tristate "MediaTek SoC Ethernet PHYs" depends on (ARM64 && ARCH_MEDIATEK) || COMPILE_TEST - depends on NVMEM_MTK_EFUSE + depends on NVMEM_MTK_EFUSE || COMPILE_TEST select MTK_NET_PHYLIB help Supports MediaTek SoC built-in Gigabit Ethernet PHYs.
When commit 462a3daad679 ("net: phy: mediatek: fix compile-test dependencies") fixed the dependency, it should have also introduced an or on COMPILE_TEST to permit this driver to be compile-tested even if NVMEM_MTK_EFUSE wasn't selected. The driver makes use of NVMEM API that are always compiled (return error) so the driver can actually be compiled even without that config. Fixes: 462a3daad679 ("net: phy: mediatek: fix compile-test dependencies") Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- drivers/net/phy/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)