| Message ID | 20250410090251.1103979-4-primoz.fiser@norik.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Update PHYTEC i.MX93 DTS | expand |
On Thu, Apr 10, 2025 at 11:02:41AM +0200, Primoz Fiser wrote: > There is already an external pull-down resistor on the LED output line. > It makes no sense to have both pull-down and pull-up resistors enabled > at the same time. Thus disable the internal pull-down. > > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> > --- Reviewed-by: Frank Li <Frank.Li@nxp.com> > arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi > index 442ee067a047..82f680d891c2 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi > @@ -196,7 +196,7 @@ MX93_PAD_ENET2_TD2__ENET1_TX_CLK 0x4000050e > > pinctrl_leds: ledsgrp { > fsl,pins = < > - MX93_PAD_I2C1_SDA__GPIO1_IO01 0x31e > + MX93_PAD_I2C1_SDA__GPIO1_IO01 0x11e > >; > }; > > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi index 442ee067a047..82f680d891c2 100644 --- a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi @@ -196,7 +196,7 @@ MX93_PAD_ENET2_TD2__ENET1_TX_CLK 0x4000050e pinctrl_leds: ledsgrp { fsl,pins = < - MX93_PAD_I2C1_SDA__GPIO1_IO01 0x31e + MX93_PAD_I2C1_SDA__GPIO1_IO01 0x11e >; };
There is already an external pull-down resistor on the LED output line. It makes no sense to have both pull-down and pull-up resistors enabled at the same time. Thus disable the internal pull-down. Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> --- arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)