From patchwork Fri Apr 11 09:57:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wei Fang X-Patchwork-Id: 14048195 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94E66C369A8 for ; Fri, 11 Apr 2025 11:19:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Message-Id:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o4PDo7S25nbumDzP4V65kvg0syGRtWi02tga+8OkrCg=; b=qOCwY+p55+AoN9om8YuxjPFzTv ACscoOaYHgiExUeBjm7bmYexwabs3FFh+KVhG7JqtIt2xPmrCHsoo9OkmQOqa/EQ+5D1ReeWKTPVe PStiN4LyioVaBfcSmtONFxDoE/4v6ZH2SgCe3MxHb7cluodYtmrSa1dWjrlcshCP1aBtmj3b+kTly 4idpWLSHW5P2GVxwbZRNDnEi4gXqHO05N6poojhWfPDGOSELQeJDTohXQyo4BhzkwdOUZf2lvgWrV Qs9bOEjJxKjX8JFmxrfNzhMTSk3i1PVWEoZHgyaBKzGItGn75MxRciG6Ya084tuCndQ4B7rbsiY7p hGrzTl9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3CPZ-0000000DUwF-3KuB; Fri, 11 Apr 2025 11:19:05 +0000 Received: from mail-am6eur05on2060b.outbound.protection.outlook.com ([2a01:111:f403:2612::60b] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3BRx-0000000DLdw-35v5 for linux-arm-kernel@lists.infradead.org; Fri, 11 Apr 2025 10:17:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WKqv6f4ddR4OTn8JqtxsKvMsx2lkEvmjuFLI4kyrxKUOpnt/Mo3hf3Br5pvX+0esSmnB/FHfRTGEonKPL5vN8j2763gkDKoq18RMhfQ+eAX6lY1nmyN1u6bAJuhv3bz9YJe9PDN2il/1cytSfIwy96szCZG4u5OQmjWXPsv1QG5FIwSuLuZSSPn6V6un+w4gEAiuGi7wUmWbGGPVXP3OIcHqNzQzdYZ/oGW+JitQUSeceQ3datEdq8z1XcFQTMkhmYxfRqTcwTC6RvTs/uhMwG2JuG9j9TyuTnwbD1iyTI2bUKlL+/8NVezUxVE99iFhmhTrjWBwikDefQ7+NtcOhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o4PDo7S25nbumDzP4V65kvg0syGRtWi02tga+8OkrCg=; b=bHmnDTn5d6115L1Vn4oFiWT3xBNlfS8Uvcycv4knu4PJPKWnzxwVXkJR1sbyZcOfQI8evFi53IfhuLNkt6Jlw0bAKE80CoEw1HHRxQHkuJEnH/phAfpyeuwUEos63v+PPu3k0tTq6lJZC4qBLx09k8Am1ibHxStRiv3/SCRrTAbkBsnB3dyx+gNiyFzftgIqbuo2MwijG+qA9m3oYzYJze7MjhOZrQ7JVhBB0lgZaprQ/UmQ3MWhPuSFkQPi/0j04AU95J7TGBTP/U/Thy2qrvYT0w/IG1azHEAMqqpnVMfBierjvaGtXhOOoMdnw7yX2EwN93KWCvdCbeiDfTz08A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o4PDo7S25nbumDzP4V65kvg0syGRtWi02tga+8OkrCg=; b=Ot9KRibOTrEdm2oi8sPQvSE3SKHWcs61gog3zrKz05/9UPP47sE+FSdujs9+b8sZZNtXAJoPrNSmGJtQecAVuCgvWdL7j3TX3JTzmZUopzgcuXT8mkEqGqwIvRjVFmVGpKdN5Kb/CynNUWNX5QCHgkOAGOX52dGXuFuaxaq/TOPH5ME7KZ7/Jc6qNqLTghy82flDjnM+4UDKIXSe/qAMYxRTI0UVr3c1U6yr0sEOZkUIF+M1OUeWeJDXv5FBwOnrVQVTcOvv3B4GNFic3Pwu+O+imJjGoGC/BdKs9XIjX2K2rrN6nd1dZcknbHO6lXkSrGdcR1OQC5SxT2vWuQrROg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8505.eurprd04.prod.outlook.com (2603:10a6:20b:40a::14) by AS8PR04MB8900.eurprd04.prod.outlook.com (2603:10a6:20b:42f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.27; Fri, 11 Apr 2025 10:17:27 +0000 Received: from AM9PR04MB8505.eurprd04.prod.outlook.com ([fe80::bb21:d7c8:f7f7:7868]) by AM9PR04MB8505.eurprd04.prod.outlook.com ([fe80::bb21:d7c8:f7f7:7868%3]) with mapi id 15.20.8606.028; Fri, 11 Apr 2025 10:17:27 +0000 From: Wei Fang To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: christophe.leroy@csgroup.eu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 net-next 06/14] net: enetc: add set/get_rss_table() hooks to enetc_si_ops Date: Fri, 11 Apr 2025 17:57:44 +0800 Message-Id: <20250411095752.3072696-7-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250411095752.3072696-1-wei.fang@nxp.com> References: <20250411095752.3072696-1-wei.fang@nxp.com> X-ClientProxiedBy: SI2PR01CA0021.apcprd01.prod.exchangelabs.com (2603:1096:4:192::19) To AM9PR04MB8505.eurprd04.prod.outlook.com (2603:10a6:20b:40a::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8505:EE_|AS8PR04MB8900:EE_ X-MS-Office365-Filtering-Correlation-Id: 230eab67-0320-4b00-984b-08dd78e20f3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: DtU1GYkQw+Va4TiSKMefucmgO1bxV28elFhWUCdjnLuvd/6ZzVKNK6MytYMUh6TAuGcwXYt+bHYxx/YNcA9UrnYiOsISFbXqm5gunzY2jBeRdqxBLnOgPRewaXZVza99lxE7GZ7MIrEZDcsETv/V8xYlTxHTqYbzUXGBqOVx1rjxoGgTCUYeqJozJilD8xSFMEWCr+cxMmQjhry1Feg/D9B0nsT+WXuM3eTJ1tKf7ssJh5q88R6eP4SmpnnGs+nbIhxDajuTHGmKCailDmG0VqTQp4TBrJf/oGwU7UCvByvYt1rcDbzzWzrlb61fhJAc4eV4vAiMNFJnCup3x/jhMEv7M1NUXhzI2hsMetC4utZaBHK6hhN20k2fC7gqlmlaM9MvuDOy8p81EEK1dzxhpNCsc2ZE9qLcYe679voN6ACQwMN+/Oiunw+zoi9V22R6FkMQ5vH4l4Q4sPJOCU9ZY/YWH9NQfwzMsxst6rgaIuduwnuj634rPLR+S79GwQdoqK5zi0qMb6HCnxyvb3t4bFQIM/YN2lf/fa/swWjKgpGbaVulaDuKwxWByr0SBzVDw0BhDigmukKzX2dkX2Hy8t7KBfT6ELR67hte1eoUNkDcMBCCSKmdEve386/rD1x9AHGHgpyiXy2zGnZzLgNYa3bw7VzzjvHDpIz1ySkJ1a5TNNIvgI68V8ilJHvSaUjbAl7NGbF76OXpsU7icOQ3RxhrmZlPsAiKwzXWnATNFl/LLheeuZ/1rVZXXl7e7UevsJGLzqGIfEVvLLpMsGCpApTr/kuyQ1w3GWRkXfKICwAYxhvYSRak6ub38652QtoHBprN++AYi5yl1eEx5IWzaa85YGwnCU1acgdoVNShKKqpzK+tNdRF9W8iQNOF+3mg57M2hRhi6/4MKEXh1r/IfdJrLzxK5z47Ap9ZSuxLMGgaTDALM+jh0nlnQx3Aica3pCg5s1NlJorEjaWxCRJP2p6rHU6efLXIyRIWJkkoVC3KGhiz186ozwprGC/zL5sv6deMaeeb6EImGHeHGt7V5K6ZAnAUugu64t+xBX3Yzum3ByNW1YHBXzWtLQTcEjDuxqXyRwmSYwa0zNALt7yev91kEmYGo/XPrr6vxpOCzTXHVfsTGNp7htKlTR7yTD3dsK760K0N3Ja1NWiFYFCS+UEJB4Z4IpZupXlYhdy7KBYszqJRF+5XrJa0YiU56KUliiTaeG2kGdOiYnSqrN7niApDg2yXNcj883jVh49dlTvdHA4XBC1YBYikLdVDl5doGRn50ZQP8BGfhsLU6p3RwU4EyippQfiWlIKAxwMBCXTbqm8kyBe3AK3eyx6kEdI74wpbfUHxfHU15qB8DTrIdHp2tCdd6/PopleGIq1WmLN8rjsv2XTQFMftr94fnIzqK2dGRtDwDPp7Zz/cGfj9dQswQM9lzimqsPufA3toeZl1lcAtSIIo/gouVBNVAxxYKC/2ZqBynIrxA1/vv7jPLA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8505.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sUBMES6LazVP78TZsd5nfmMJmrrSZxtZUSsFHMfklWA5yfTxMWufExT3PPPsSN4Jd9mKLlqiv0yUeNBxQy/7X6451CtG3TZT0OAC5RkwTLNRawHZ57H5CyLmL08HxLB63vMFieqwOTo4/wUEXsdDUAn+f0GVndHg/9Xf/wZBwkEhxWhg4Da8+5uhLqnDCBScaLQj/2/6eXJhkawvCJS4YiWfE+7bUUPsge7yzKYbLILpXAcznW31QbWtryhmLMBBR3mP7Q9EueWQU1Wyt5OKK/a6/cGUHcFe8YRit5asl4JjrwsOmgavfsyBlQlA9ZuoeMlgJZkKmsvwO9uip+kizLTgBb3U/VBXMtEChpTfL7hwtOWosYvZzM/4pmbWSqWpwD8mLHA0rRwbWneNowqStn7OxL+hXsWdNvpQ6cmvRWvyPJutVjr3643sxlFOdRqv78U2XEV58X/OsQuwHTJHNk1IjZ6SesnKF1tC0sk1GrzXGiSctIoc5n7feIxlChlDb4KGc9mTaM/BL3HMsA6rHvxKBu2volyM9d/VwISd9ZG5W/peLaX2AidfP/SxcmWH2JFI/MTaGZULv7uLePRQeDwJtcTNEUokVAUKJ6MEJ80xQjUBlXIsX6y5MTTm7WgaaQfDLltQq1Nkli/FEKkV2GJsXm1nV76vC1e7bomSUgQpT712RryXjMG9fndLr7MLMkbLQ7pUvLmZ/VBnsD4x8OPDKmfM75zFAJ0Zj2olXC4WeM+7a6RG46S3vWpYkv3qu/aY2/lC35SkzIB4Sfa707034ESXKIP1t4jppo/QkpmnbYy62SBjYV2JWIeJsvvTRvtSddEtnNtzhCyS1AxGTItxG8KE1VusglC7ihuIShMprssl+6QyrDHrogF+CkkhS4+rUFM/92L7vmkMu2BehULPfXiEWnexfDEzGXwBrhb6LiEhSYQKpqE/cxPu+kGBk64Esw3if8IZplfdUICDKkuF473KfUD3RS4Ag7lfEapCjauY4GSGiGtz+vs4uz/Vk6jcWxF3Z1mo0hHijb54nd4LWm7KiqD0p0QVJKdFOQ2247T+UMLr1MwU3yAyiw8TGAXofHtOSAnbVJIB5qrnOjUHjuX0UkzD6ag834IDL4anlXMqxQD13srhrJ7wLgUEwc5gVfeqFlPo5Tw/dLwUSzPrVGZmxBVrubD26qbREzwFmurEhkFH0VHD4R1fsWZPzknE4Q4ZDD/qhibZkNWUSBWef5CcrbWkF+igm0/ZPDiJ38BAHWCWyl0VfENRzFj/TXdbMhML5BmR1bToqKN9+dJfY/lDDKFPehhZ2QGomik+ZEodNc4dXARfPhoZxCcbJs71peHpNvUc/Ow8QUliqvY8q6Ecdluzn0sg3my7xDXFvCHJUvPcXFkRTuU1O2mrR9edFrphCEuCMJuI9p8TMFHZ6WwCSyVu1UfzXeP1d2hvBWzPKvkSnmFA35NkqLwTvit5zvgkneIPeCSlRn9v1MkTMtrCASbegqrCt0XPf5ITB27i0fYYopmO6hbj1ihzsO+aopRzY5tRGxQwFYvZEs3z7l1VDkDCmF1fgNRjklj3cEEjYldH89u/8z5pM6UJ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 230eab67-0320-4b00-984b-08dd78e20f3a X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8505.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 10:17:27.2615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 17XxcBPXkxXiTiyrZIVzF4BIhvaOjG7jO8A7rXOUZfIye1hR9Zieh3229UVXB7wklrYIpuGLKTfTBBgwqxgXHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8900 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250411_031729_781868_73209CEB X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since i.MX95 ENETC (v4) uses NTMP 2.0 to manage the RSS table, which is different from LS1028A ENETC (v1). In order to reuse some functions related to the RSS table, so add .get_rss_table() and .set_rss_table() hooks to enetc_si_ops. Signed-off-by: Wei Fang --- v5 changes: Add enetc_set_default_rss_key() to enetc_pf_common.c and use it in both enetc v1 and v4 drivers --- drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- drivers/net/ethernet/freescale/enetc/enetc.h | 13 +++++++++++++ .../net/ethernet/freescale/enetc/enetc_ethtool.c | 12 ++++++------ drivers/net/ethernet/freescale/enetc/enetc_pf.c | 6 ++++++ drivers/net/ethernet/freescale/enetc/enetc_vf.c | 6 ++++++ 5 files changed, 32 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index 3832d2cd91ba..2a8fa455e96b 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -2405,7 +2405,7 @@ static int enetc_setup_default_rss_table(struct enetc_si *si, int num_groups) for (i = 0; i < si->num_rss; i++) rss_table[i] = i % num_groups; - enetc_set_rss_table(si, rss_table, si->num_rss); + si->ops->set_rss_table(si, rss_table, si->num_rss); kfree(rss_table); diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h b/drivers/net/ethernet/freescale/enetc/enetc.h index b53ecc882a90..786042029b1e 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.h +++ b/drivers/net/ethernet/freescale/enetc/enetc.h @@ -279,6 +279,19 @@ struct enetc_platform_info { const struct enetc_drvdata *data; }; +struct enetc_si; + +/* + * This structure defines the some common hooks for ENETC PSI and VSI. + * In addition, since VSI only uses the struct enetc_si as its private + * driver data, so this structure also define some hooks specifically + * for VSI. For VSI-specific hooks, the format is ‘vf_*()’. + */ +struct enetc_si_ops { + int (*get_rss_table)(struct enetc_si *si, u32 *table, int count); + int (*set_rss_table)(struct enetc_si *si, const u32 *table, int count); +}; + /* PCI IEP device data */ struct enetc_si { struct pci_dev *pdev; diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c index ece3ae28ba82..d14182401d81 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c @@ -681,7 +681,8 @@ static int enetc_get_rxfh(struct net_device *ndev, struct ethtool_rxfh_param *rxfh) { struct enetc_ndev_priv *priv = netdev_priv(ndev); - struct enetc_hw *hw = &priv->si->hw; + struct enetc_si *si = priv->si; + struct enetc_hw *hw = &si->hw; int err = 0, i; /* return hash function */ @@ -695,8 +696,7 @@ static int enetc_get_rxfh(struct net_device *ndev, /* return RSS table */ if (rxfh->indir) - err = enetc_get_rss_table(priv->si, rxfh->indir, - priv->si->num_rss); + err = si->ops->get_rss_table(si, rxfh->indir, si->num_rss); return err; } @@ -715,7 +715,8 @@ static int enetc_set_rxfh(struct net_device *ndev, struct netlink_ext_ack *extack) { struct enetc_ndev_priv *priv = netdev_priv(ndev); - struct enetc_hw *hw = &priv->si->hw; + struct enetc_si *si = priv->si; + struct enetc_hw *hw = &si->hw; int err = 0; /* set hash key, if PF */ @@ -724,8 +725,7 @@ static int enetc_set_rxfh(struct net_device *ndev, /* set RSS table */ if (rxfh->indir) - err = enetc_set_rss_table(priv->si, rxfh->indir, - priv->si->num_rss); + err = si->ops->set_rss_table(si, rxfh->indir, si->num_rss); return err; } diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c index f76403f7aee8..8dabb80ec04c 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c @@ -905,6 +905,11 @@ static int enetc_pf_register_with_ierb(struct pci_dev *pdev) return enetc_ierb_register_pf(ierb_pdev, pdev); } +static const struct enetc_si_ops enetc_psi_ops = { + .get_rss_table = enetc_get_rss_table, + .set_rss_table = enetc_set_rss_table, +}; + static struct enetc_si *enetc_psi_create(struct pci_dev *pdev) { struct enetc_si *si; @@ -924,6 +929,7 @@ static struct enetc_si *enetc_psi_create(struct pci_dev *pdev) } si->revision = enetc_get_ip_revision(&si->hw); + si->ops = &enetc_psi_ops; err = enetc_get_driver_data(si); if (err) { dev_err(&pdev->dev, "Could not get PF driver data\n"); diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c b/drivers/net/ethernet/freescale/enetc/enetc_vf.c index 3768752b6008..4fafe4e18a37 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_vf.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_vf.c @@ -162,6 +162,11 @@ static void enetc_vf_netdev_setup(struct enetc_si *si, struct net_device *ndev, enetc_load_primary_mac_addr(&si->hw, ndev); } +static const struct enetc_si_ops enetc_vsi_ops = { + .get_rss_table = enetc_get_rss_table, + .set_rss_table = enetc_set_rss_table, +}; + static int enetc_vf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) { @@ -176,6 +181,7 @@ static int enetc_vf_probe(struct pci_dev *pdev, si = pci_get_drvdata(pdev); si->revision = ENETC_REV_1_0; + si->ops = &enetc_vsi_ops; err = enetc_get_driver_data(si); if (err) { dev_err_probe(&pdev->dev, err,