From patchwork Tue Apr 15 11:23:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 14052177 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DA81C369AB for ; Tue, 15 Apr 2025 12:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=xqiBmH3cXQhVO3Oi9TyesxzQNNmvWhKNONR9ZJLERQE=; b=JC/WHUEkYDy6R4dL9fnBDdn/w3 FmM8bAAIgMUtfGT1fcD/r7Y8U/DFbcdRgByHzKRu/g67PG+xMhRBn3pE4ebV7p+QwBY5Q9yiDxgC8 junTojWds3Q1oeSnX6IF+osPieIgu3iHAHqXKHkBF1rOpUBqsqA38ONGAXIoUjo/7/Nuvf5ZrnxlI xFgW/tl8HIyuBz1PeSSyvUR2Zdhk9ULX+t5dXQEYJqfKgPculwIosdswRoKr8OnZOox8ti8Fl2c/8 5ov+RYpkoJHZzmk0dWuVBljNylMvhJTUSaNevHyLWZ+X0i+2AUTLx0L0VPJt9XzTZO2qzr7E26Cz6 1zUIUECw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4fHe-00000005iAt-3tji; Tue, 15 Apr 2025 12:20:58 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4eOH-00000005WIL-2kp8 for linux-arm-kernel@lists.infradead.org; Tue, 15 Apr 2025 11:23:47 +0000 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-736a7e126c7so4603810b3a.3 for ; Tue, 15 Apr 2025 04:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1744716224; x=1745321024; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xqiBmH3cXQhVO3Oi9TyesxzQNNmvWhKNONR9ZJLERQE=; b=YEuWuOkC4FZu/PeSL56ckBLZqQx9egdNhshXBC5Zs9KnLKFseRwWpVsI2OWrBJBBDd /dTzYAYNmT479QKNXAbRtWtLqJyvu8Mp2g9TDb3mF5F4EDC586KOzE3aHXM7Y3W4I7Xn 84bu0Pcz+DkEcLp2RCriATmTyhXN/cymPi8Xw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744716224; x=1745321024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xqiBmH3cXQhVO3Oi9TyesxzQNNmvWhKNONR9ZJLERQE=; b=whfDLDOT9dHydkS+Upn4mqTFRo1SopbNKfzKAG3+3lT81mHUukM+wVJkpda0rjVDTC 5xJObN1gT0Kr7V22oR6CA11vflvYLfDrJ0kRqRReYOmj/ve8TkTV6Os7wPwBZpnP4hI6 iDwNTA16sjfPC+qP0RFwoP2NbSWQYizMy8Xq7lJzL/ykA5oeeae7COTP/nampjfnpIlf L0IQR6WE8r59OxV8q7fV63qCzY8dWdTRI9eUx55RrSDm50rPR88KfaSB3Kko5tlToiFi laNM8yU4rusTrNd0b4wIdXaBYsuYdWSAaPvnKMotOD18l14N21fwTh7zYd/lvjq5RfJM VD7Q== X-Forwarded-Encrypted: i=1; AJvYcCWbUI4iI5kiMWtoY50ZV1ymBxM9JDmy2NEc8nxZK4pL69MRZ/j86LvsKhS1jLE9UVkld870vmHcxQ1LwcvIZsZH@lists.infradead.org X-Gm-Message-State: AOJu0YzgjCflSQUxraDTayta4wo0vZOttl27bHKd9YiL6Yz0mqo1/EA1 Wxjo5bn87Uj72fDZd02FWDhcAEfkDglPw+3aIh9nfFF28c4pllWEpcy0YXF5Lg== X-Gm-Gg: ASbGnctzPNFKE7pTFWvADsLoKaKyptbuOv72DEzoVipHhUqcy9rtfr5uMINEDXN4Pua 1E3TC8OeH1Xd7r02bK7MWmSI4vEiRldcrpq9FA07/c2GvBcZMn3vheI74m3cHl8tvYLm1bP6vPp SZxssI94IUxhXHKAkDARcXEju9YQ6lb89/st1bsGkB8gmVzYjgVGsQv1mUzehW5FazrBSQvzWhx 1hKbEZWEZK2qMrPDar+t6n1jGrGs1kihdm20eQkl6WTTAGgia1U7NPyEMiM+HNvYM+RApr8N1Up H3s4/7h1mG6KqQFmNwfRInI1nkX/+iabQ4z429efeWAu2L9tIjugcx0+GQ== X-Google-Smtp-Source: AGHT+IHLztgc2AXA8MRVXKVLULr5aHlO9vKzoTKy2KAhml+hRnJpGVjxL+/NKMKFeR5E/N1M9tqKmA== X-Received: by 2002:a05:6a00:1481:b0:736:ab1e:b1ab with SMTP id d2e1a72fcca58-73bd0e97a1emr19543011b3a.0.1744716224175; Tue, 15 Apr 2025 04:23:44 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:558:e14a:ece3:dc28]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd22f105asm8244136b3a.116.2025.04.15.04.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 04:23:43 -0700 (PDT) From: Chen-Yu Tsai To: Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Hao Chang , Qingliang Li Subject: [PATCH] pinctrl: mediatek: common-v1: Fix EINT breakage on older controllers Date: Tue, 15 Apr 2025 19:23:37 +0800 Message-ID: <20250415112339.2385454-1-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.604.gff1f9ca942-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250415_042345_722202_A00780D3 X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When EINT support for multiple addresses was introduced, the driver library for the older generations (pinctrl-mtk-common) was not fixed together. This resulted in invalid pointer accesses. Fix up the filled in |struct mtk_eint| in pinctrl-mtk-common to match what is now expected by the mtk-eint library. Reported-by: "Uwe Kleine-König" Closes: https://lore.kernel.org/all/43nd5jxpk7b7fv46frqlfjnqfh5jlpqsemeoakqzd4wdi3df6y@w7ycd3k5ezvn/ Fixes: 3ef9f710efcb ("pinctrl: mediatek: Add EINT support for multiple addresses") Cc: Hao Chang Cc: Qingliang Li Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- Stepped on this today on an MT8173 Chromebook. Thanks goes out to Uwe for pointing out what was broken. This should be applied and sent to Torvald's tree ASAP. drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 91edb539925a..7585de11854b 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -1015,7 +1015,13 @@ static int mtk_eint_init(struct mtk_pinctrl *pctl, struct platform_device *pdev) if (!pctl->eint) return -ENOMEM; - pctl->eint->base = devm_platform_ioremap_resource(pdev, 0); + pctl->eint->nbase = 1; + /* mtk-eint expects an array */ + pctl->eint->base = devm_kzalloc(pctl->dev, sizeof(pctl->eint->base), GFP_KERNEL); + if (IS_ERR(pctl->eint->base)) + return -ENOMEM; + + pctl->eint->base[0] = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pctl->eint->base)) return PTR_ERR(pctl->eint->base);