[v3,03/15] arm64: dts: freescale: imx93-phycore-som: Disable LED pull-up

Commit Message

Primoz Fiser April 18, 2025, 6:30 a.m. UTC

There is already an external pull-down resistor on the LED output line.
It makes no sense to have both pull-down and pull-up resistors enabled
at the same time. Thus disable the internal pull-down.

Signed-off-by: Primoz Fiser <[e-mail]>
Reviewed-by: Frank Li <[e-mail]>
---
Changes in v3:
- no changes

 arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dirk Gouders April 18, 2025, 8:16 a.m. UTC | #1

Primoz Fiser <[e-mail]> writes:

> There is already an external pull-down resistor on the LED output line.
> It makes no sense to have both pull-down and pull-up resistors enabled
> at the same time. Thus disable the internal pull-down.
                         ~~~~~~~              ~~~~~~~~~
Sorry for disturbing, but I couldn't resist: the above somehow
contradicts the subject line -- at least when reading this just by
chance.

Regards,

Dirk

Primoz Fiser April 18, 2025, 9:18 a.m. UTC | #2

Hi Dirk,

On 18. 04. 25 10:16, Dirk Gouders wrote:
> Primoz Fiser <[e-mail]> writes:
> 
>> There is already an external pull-down resistor on the LED output line.
>> It makes no sense to have both pull-down and pull-up resistors enabled
>> at the same time. Thus disable the internal pull-down.
>                          ~~~~~~~              ~~~~~~~~~
> Sorry for disturbing, but I couldn't resist: the above somehow
> contradicts the subject line -- at least when reading this just by
> chance.

Yeah... it should say "disable the internal pull-up".

Great attention to details :)

Thanks,

BR,
Primoz

> 
> Regards,
> 
> Dirk

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
index 0528e293c03d..06a9e674e338 100644
--- a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
@@ -196,7 +196,7 @@  MX93_PAD_ENET2_TD2__ENET1_TX_CLK		0x4000050e
 
 	pinctrl_leds: ledsgrp {
 		fsl,pins = <
-			MX93_PAD_I2C1_SDA__GPIO1_IO01		0x31e
+			MX93_PAD_I2C1_SDA__GPIO1_IO01		0x11e
 		>;
 	};