From patchwork Mon Nov 2 12:02:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Valdis_Kl=C4=93tnieks?= X-Patchwork-Id: 11873781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4265C00A89 for ; Mon, 2 Nov 2020 12:04:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 172D922226 for ; Mon, 2 Nov 2020 12:04:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zNG9E/bk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=vt-edu.20150623.gappssmtp.com header.i=@vt-edu.20150623.gappssmtp.com header.b="ZCCUSnwZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 172D922226 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Message-ID:Date:Mime-Version:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=DD28+MtAKButwV7hve0YwSxtuewXqaL/hTjmhoL5/aQ=; b=zNG 9E/bk9qyciqfbJ8hbVzrCBsS0Eaf+z6iGkYXdZtlU1Lni7e9X1ViRuypEklM1O6xVDo+qvdQcyFtX TMTlXejz+t08Kh9iT6HzmAwv77pHwzYKIXEhZCFc3jjtbKELc4Ic21EMi9S5OyZshlYUgxu+ElhtZ H4bsRtJO6p6rDUnp4N/Gug8Rn3F2b0lv+D3H6GXgBmDZpkxKOly3LaSwPfnvAIJj8zO0NLEz8Rf42 kIBkqSgpatqTJZ5jBB3kGtBSzKMltw3xGORCCE+GDDEGkUy63rgFG4RwiNvKcxBc0Jco9siUp6Zqc MbwHgRoU0UyTj2iY+CRhHQOqonve/cQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYXX-00018s-Lk; Mon, 02 Nov 2020 12:02:24 +0000 Received: from mail-il1-x141.google.com ([2607:f8b0:4864:20::141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYXM-00015j-HV for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 12:02:18 +0000 Received: by mail-il1-x141.google.com with SMTP id f16so12733541ilr.0 for ; Mon, 02 Nov 2020 04:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:mime-version:content-transfer-encoding :date:message-id; bh=4lUtMbemKtwULeWB/GtzN61KZP8PLo1ylcMvc2DrBNE=; b=ZCCUSnwZrwi0KVDyv5VwDc84EmLHx5WwqlwF9WWaUWvMCVM/ngqnFIOG2D/5Y+qAgr XDX5mBhr828bKSJMlhawIGKOhA3cG1gtj6pGsyUMfS459qxW5xgBKxA3gUGjEDZt0NXL +W0Iarc3kuaCKRlq5h+NkbPD03yhhAm4hqGp+6AcTYi+98Gb5kcCKP6pN6ua4NSAi4S1 R3pIh1L0CG1j8QwsYCK6ubZJDttbdLkIniasV9Gkb5dwBcd6vd6TIRGIiUpszKqh7B31 nH2zE9iM9PCPaQyAu57y2o0tETBek9PlroR3tpoYZIDAu8WAbwagV8tJ3UUALtd2q3AL Cu+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:mime-version :content-transfer-encoding:date:message-id; bh=4lUtMbemKtwULeWB/GtzN61KZP8PLo1ylcMvc2DrBNE=; b=OZmWnl2+RZeJlnox797UsvYK50SjMFjf13kL2aR0HB+4EknSzDcyMmXm+pPyYF+/FS zPsxKG73+HVxj2OVaBk0rqHNi1OjKChJQA282xIGfT+A6qU51qTzJmraxSNmFH8hs8a2 IXCqDmlxvxKRCdc0svevndDAUSTfFbYS2vBKEmEphiuAUZmH0boEHYs4Xr5NMKxNqIhU 6lMR6ZSnuyYHn7mzVSQlSq3Jrdw/jefxekSqjvlwL/cDXBBdzc6qaoZheDa3ySZM15ho yEw5KqrUOFXpZJVoo/D6iSR8xWzJ4+UzWZzswNuPH6IrjnGfZFrL+ejkVCQk9nDERZI9 lH2w== X-Gm-Message-State: AOAM531X6iXrDgNSWf1U2YLUDCjORseK0CMRgp6h5KrhEQbMvOW1XrzP nR3XOwGYOhvVXorLF0sLSN6ntA== X-Google-Smtp-Source: ABdhPJyXxscq1wNR3piVhMnm5hW9AcsE7JlM6nPhY+kolBvI4nSMh63pvoyBanFPGM7hw59EiRiYGA== X-Received: by 2002:a92:844b:: with SMTP id l72mr9784093ild.244.1604318529367; Mon, 02 Nov 2020 04:02:09 -0800 (PST) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id q16sm10359649ilj.22.2020.11.02.04.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 04:02:06 -0800 (PST) From: "Valdis =?utf-8?q?Kl=C4=93tnieks?= " X-Google-Original-From: "Valdis =?utf-8?q?Kl=C4=93tnieks?= " X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Dong Aisheng , Michael Turquette , Shawn Guo , Stephen Boyd , Sascha Hauer Subject: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o Mime-Version: 1.0 Date: Mon, 02 Nov 2020 07:02:05 -0500 Message-ID: <208469.1604318525@turing-police> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_070212_767867_4B03AD03 X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org commit 77d8f3068c63ee0983f0b5ba3207d3f7cce11be4 (HEAD) Author: Dong Aisheng Date: Wed Jul 29 16:00:10 2020 +0800 clk: imx: scu: add two cells binding support This missed a #include, which results in some nasty errors when built as a module CC [M] drivers/clk/imx/clk-scu.o In file included from ./include/linux/device.h:32, from ./include/linux/of_platform.h:9, from drivers/clk/imx/clk-scu.c:11: ./include/linux/device/driver.h:290:1: warning: data definition has no type or storage class device_initcall(__driver##_init); ^~~~~~~~~~~~~~~ ./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver' builtin_driver(__platform_driver, platform_driver_register) ^~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' builtin_platform_driver(imx_clk_scu_driver); ^~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/device/driver.h:290:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int] device_initcall(__driver##_init); ^~~~~~~~~~~~~~~ ./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver' builtin_driver(__platform_driver, platform_driver_register) ^~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' builtin_platform_driver(imx_clk_scu_driver); ^~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: warning: parameter names (without types) in function declaration In file included from ./include/linux/device.h:32, from ./include/linux/of_platform.h:9, from drivers/clk/imx/clk-scu.c:11: drivers/clk/imx/clk-scu.c:545:25: warning: 'imx_clk_scu_driver_init' defined but not used [-Wunused-function] builtin_platform_driver(imx_clk_scu_driver); ^~~~~~~~~~~~~~~~~~ ./include/linux/device/driver.h:286:19: note: in definition of macro 'builtin_driver' static int __init __driver##_init(void) \ ^~~~~~~~ drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver' builtin_platform_driver(imx_clk_scu_driver); ^~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[3]: *** [scripts/Makefile.build:283: drivers/clk/imx/clk-scu.o] Error 1 Fix by providing the include. Signed-off-by: Valdis Kletnieks Reported-by: kernel test robot diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 229a290ca5b6..15d382f6f9f8 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include