From patchwork Thu Feb 21 10:44:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2171171 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id D76DD3FD4E for ; Thu, 21 Feb 2013 10:48:29 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U8TeO-00010U-Pk; Thu, 21 Feb 2013 10:45:16 +0000 Received: from moutng.kundenserver.de ([212.227.17.9]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U8TeM-0000zz-OR for linux-arm-kernel@lists.infradead.org; Thu, 21 Feb 2013 10:45:15 +0000 Received: from wuerfel.localnet (HSI-KBW-46-223-90-92.hsi.kabel-badenwuerttemberg.de [46.223.90.92]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0LyQ4I-1Uu4HJ3hQM-015Acp; Thu, 21 Feb 2013 11:45:12 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: select ARCH_WANT_OPTIONAL_GPIOLIB Date: Thu, 21 Feb 2013 11:44:51 +0100 Message-ID: <2173132.bncoOm6QsM@wuerfel> User-Agent: KMail/4.10 rc3 (Linux/3.8.0-4-generic; KDE/4.10.0; x86_64; ; ) In-Reply-To: References: <20130218111410.GA10572@e106331-lin.cambridge.arm.com> <1634805.kh17mYrJe5@wuerfel> MIME-Version: 1.0 X-Provags-ID: V02:K0:7uhwJjM7gPaGCM1GBQxpvX3ih2V2BhSBbLrc5Gr6eiX PDtIwpfqAjmLVx/kIsN4M4O9VTCf0ohNES3O2wSweL4m9G2zX5 ww7Oc3kEmT6wDzZ/sXzMUikDUE7InETGjvfD5uJX07/n3Qkif1 I/gLTjty5wCe+PWlZVhhBiuUiO5qN8QaMWOWRvATnMNPmbJ8B7 QI+41nXFrhqukUzNa1BNtLb6+7XhM5T+fbgJqW4VBQF6Zzi2eS UNmcxf2fZmsAGvD4oX0J3hQvMndgjXvlRVrB5569pfzUarkLJn QorEMAtkHf9WrThUr5sLWk70X9x2NT1DE3wk0GrVxCQdzeowM+ XYjlAUJLTIK2H/zMOD94= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130221_054515_059747_0F971731 X-CRM114-Status: GOOD ( 10.39 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.9 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Grant Likely , Mark Rutland , Linus Walleij , Shawn Guo , Catalin Marinas X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org An architecture should not unconditionally enable 'GENERIC_GPIO' without providing an implementation. In case of arm64, selecting ARCH_WANT_OPTIONAL_GPIOLIB is the right solution, because it lets us enable GPIOLIB when configuring the kernel, and that implicitly turns on GENERIC_GPIO. Signed-off-by: Arnd Bergmann ---- On Thursday 21 February 2013 10:36:41 Grant Likely wrote: > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index ab4aa54..3fab0db 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -3,6 +3,7 @@ config ARM64 > > select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE > > select ARCH_WANT_COMPAT_IPC_PARSE_VERSION > > select ARCH_WANT_FRAME_POINTERS > > + select ARCH_WANT_OPTIONAL_GPIOLIB > > select ARM_AMBA > > select ARM_ARCH_TIMER > > select CLONE_BACKWARDS > > @@ -92,9 +93,6 @@ config SWIOTLB > > config IOMMU_HELPER > > def_bool SWIOTLB > > > > -config GENERIC_GPIO > > - def_bool y > > - > > source "init/Kconfig" > > > > source "kernel/Kconfig.freezer" > > I've not asked Linus to pull the GPIO tree yet because of this issue. > Can someone please test this on aarch64 and send me a properly > formatted patch? It was wrong, the new version below is good though. Tested with defconfig and allyesconfig on arm64. I found a few more trivial issues with arm64 allyesconfig that I fixed up as well. I'll send separate patches for those. Acked-by: Linus Walleij diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index ab4aa54..38d3f34 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -3,6 +3,7 @@ config ARM64 select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select ARCH_WANT_COMPAT_IPC_PARSE_VERSION select ARCH_WANT_FRAME_POINTERS + select ARCH_WANT_OPTIONAL_GPIOLIB select ARM_AMBA select ARM_ARCH_TIMER select CLONE_BACKWARDS @@ -93,7 +94,7 @@ config IOMMU_HELPER def_bool SWIOTLB config GENERIC_GPIO - def_bool y + bool source "init/Kconfig"