From patchwork Mon Apr 3 07:19:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Birsan X-Patchwork-Id: 9658873 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C36D60352 for ; Mon, 3 Apr 2017 07:44:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C9702843B for ; Mon, 3 Apr 2017 07:44:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F8A22844E; Mon, 3 Apr 2017 07:44:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9F6E628429 for ; Mon, 3 Apr 2017 07:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MFW5onxvD0risjbG2vjhDVqc2nZLd9bV33rxGe7vpI0=; b=gUVcqZdwRPpR6C R1OPmpEBHRdlHQWurpQAPI/5CopDkjT7k91oRvdaw0/Xz1eNmQK27RjuypMHRhAozEU5Bq888WFex jcD4DHafQK8neikULEFoNvnneCkU6vCBekMuyA7Lu5JIMGw9cGprAys67pAEDCuWVrTO0OTCssN9Z 2BAWvbXGwCNXO+0fh49vVuiznqovltSVgb+RRz71NmNSi4gUykjhV9XG2cZWN9ZLbO0p640hHEwix IdvyhcxhdhamuxcEg1SCnpXc0ff6stO+2ZDhQHJ4rLvLxQYZqXx2IjR5yoZdCyyn0OkhJRf+S//fo ZyYX86qHJuxYFLS7lYTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cuwej-0004Cz-Dc; Mon, 03 Apr 2017 07:44:05 +0000 Received: from merlin.infradead.org ([2001:4978:20e::2]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cuweh-0004CT-3P for linux-arm-kernel@bombadil.infradead.org; Mon, 03 Apr 2017 07:44:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/fCNyhxVFF8isB8DERnCJj1XS+wUGq9igd1lFdBqLBU=; b=Knu/38BLgQAqJHk2khw5ZuVts Td8SKKcsC/Nry9YUmtpjG5LEj0Su9L0FkyFgnVRTpDaB24NkQbdoRMwXIC5fg2K+RTceW3zU8GN4i 143QWXjhw2HCZcvDrtKzXHUPcMTyyuWeI/y52qwICtbMip94y3u+VgsgtYkCR2Pp9g9BRttPg8HbI M3rJLSCIeNmUc4ODRDmKNZVAQqlIEGM/4GDF1+syetp+qq5cx8ypVYzUD1yoiGIIRn0QBzpx8mMLd uAYZS8snYBVkZwyiWS3F8zeaNbV4/rv99yrnEWqOd9HzQ4yEft2pQ68QchP3ZjXlFu6llMjO73kEO 1l4Sxk6ig==; Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cuwIb-0005R6-Ev for linux-arm-kernel@lists.infradead.org; Mon, 03 Apr 2017 07:21:14 +0000 X-IronPort-AV: E=Sophos;i="5.36,269,1486450800"; d="scan'208";a="884902" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA; 03 Apr 2017 00:20:47 -0700 Received: from localhost.localdomain (10.10.76.4) by chn-sv-exch04.mchp-main.com (10.10.76.105) with Microsoft SMTP Server id 14.3.181.6; Mon, 3 Apr 2017 00:20:46 -0700 From: To: , , , , , Subject: [PATCH linux-next v3 3/4] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error Date: Mon, 3 Apr 2017 10:19:53 +0300 Message-ID: <226692c3b986abe4ec4239472a4d57e32dfc5a71.1491201365.git.cristian.birsan@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170403_032113_662591_AF3F8745 X-CRM114-Status: UNSURE ( 6.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: boris.brezillon@free-electrons.com, ludovic.desroches@atmel.com, alexandre.belloni@free-electrons.com, Cristian Birsan Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Cristian Birsan Use dev_err() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 8bc0b52a..3ccc341 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -1851,8 +1851,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) * but it's clearly harmless... */ if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, - "ODD: EP0 configuration is invalid!\n"); + dev_err(&udc->pdev->dev, + "ODD: EP0 configuration is invalid!\n"); /* Preallocate other endpoints */ n = fifo_mode ? udc->num_ep : udc->configured_ep; @@ -1860,8 +1860,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) ep = &udc->usba_ep[i]; usba_ep_writel(ep, CFG, ep->ept_cfg); if (!(usba_ep_readl(ep, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, - "ODD: EP%d configuration is invalid!\n", i); + dev_err(&udc->pdev->dev, + "ODD: EP%d configuration is invalid!\n", i); } }