diff mbox series

pinctrl: pinctrl-zynqmp: Use pin numbers stored in pin descriptor

Message ID 2413a1f99278d70313960f13daecda9ef54172d8.1716807432.git.michal.simek@amd.com (mailing list archive)
State New
Headers show
Series pinctrl: pinctrl-zynqmp: Use pin numbers stored in pin descriptor | expand

Commit Message

Michal Simek May 27, 2024, 10:57 a.m. UTC 
From: Swati Agarwal <swati.agarwal@amd.com>

Use pin numbers stored in the pin descriptors instead of index value while
creating the pin groups. Pin Id's are not same as Index values for Xilinx
Versal platform, so use the pin values from descriptor which works for both
ZynqMP and Versal platforms.

Signed-off-by: Swati Agarwal <swati.agarwal@amd.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
---

 drivers/pinctrl/pinctrl-zynqmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij May 29, 2024, 7:36 a.m. UTC | #1 
On Mon, May 27, 2024 at 12:57 PM Michal Simek <michal.simek@amd.com> wrote:

> From: Swati Agarwal <swati.agarwal@amd.com>
>
> Use pin numbers stored in the pin descriptors instead of index value while
> creating the pin groups. Pin Id's are not same as Index values for Xilinx
> Versal platform, so use the pin values from descriptor which works for both
> ZynqMP and Versal platforms.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@amd.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>

Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
index 5c46b7d7ebcb..1ea0353767b7 100644
--- a/drivers/pinctrl/pinctrl-zynqmp.c
+++ b/drivers/pinctrl/pinctrl-zynqmp.c
@@ -718,7 +718,7 @@  static int zynqmp_pinctrl_prepare_group_pins(struct device *dev,
 	int ret;
 
 	for (pin = 0; pin < zynqmp_desc.npins; pin++) {
-		ret = zynqmp_pinctrl_create_pin_groups(dev, groups, pin);
+		ret = zynqmp_pinctrl_create_pin_groups(dev, groups, zynqmp_desc.pins[pin].number);
 		if (ret)
 			return ret;
 	}