From patchwork Sun Mar 11 00:56:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 10274467 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 55D4460390 for ; Sun, 11 Mar 2018 00:57:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AA8029327 for ; Sun, 11 Mar 2018 00:57:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2DAA429340; Sun, 11 Mar 2018 00:57:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56DAB29327 for ; Sun, 11 Mar 2018 00:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mPAStqiMIG02TFNSG2WXQ5IHc+aemfKJEkWWtHDj8KA=; b=bZTgz4iOzwa/P5 IwfffTLAx2/LssaZCrfmpt6yvQINTjBtDqtWzXNJxDtWJflV+yvaEXj2bR4Ze091eoxFYbuOVHCFZ I5aYEN1+FirajYeqOQU/k4vhNgsejrD4lWqDlXZuGhKjxHGGoHS62H5iQuSTGENNKKjNN7DOcFAYD jR4OmMcR9Xy9gtr5/BGOrxfcoGlUZ6aGJp072vW5qe9IM6AXGWwmd2hGZLYr1if9BGK9GAHEQ/jb1 mcrIs4qC/NeQkM76nOzIZdX7Qqrju9LSFgl6obcnk9FO4HDUxS4vu0wyh1fWPIqYsX9kizDJdNIaX IcRbMlNKY4+oJWJS4Dxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eupI9-00031f-IG; Sun, 11 Mar 2018 00:56:49 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eupI5-0002ws-1S for linux-arm-kernel@lists.infradead.org; Sun, 11 Mar 2018 00:56:48 +0000 Received: by mail-wm0-x241.google.com with SMTP id 139so10001006wmn.2 for ; Sat, 10 Mar 2018 16:56:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=afJBer1gZsjkfvXo2ihBo73s4uRya0eV/MHvUMRdEVg=; b=WPKFGmn9PtVRYEMPLw5UaeKZdDEjn1MAzrAnqja1w9lqlF1uwtxbjZf54p9J+uVhrw 5pKjtM3YVGYzam9wCks30Q5p6TzjgbD9P2jOfizPUoFzmFfnkPGALOAUioJzNc3BAsLu jSM7Vz/Txowq9jPG3ZEkMax+bBM07D5ghpmBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=afJBer1gZsjkfvXo2ihBo73s4uRya0eV/MHvUMRdEVg=; b=j1DIPGN/0rTeiN+B30soVboTisR+k+xKFNO1vPQqAB4FdAXVTRxX5exzsjOFPwN3VX cocgYa7RxaQo/dICJUGHI08S704d5tf1l8ilvGyINLXzDdrm3HLz9seMFvnhBLD6pYuI 21xmvDqoBYmiHmAME/2T2MkUFYQA28M3rPxTHS4R9ganp+kCxb1Qq/mR3osbVkop7xfI JX11G9hsGMIGCSeMo0IQC/oPXC/07PfEjVJ3zNaqCRpUNKyRBD+5o5jp6HaXMckzrwyR KFzFIH7agNDP/RgEbfESLENiq3VXXiFvXwP7n1ZjREyVeVNkjxM+X1vXu6dGAkCWXmHB B0vg== X-Gm-Message-State: AElRT7Ev0f8JQTI8hVg14fKWVT1g12+OBzG7W6dGnqoigUMg+BHq/rRx g46tXvr32hCoPSwha94AY9x24A== X-Google-Smtp-Source: AG47ELvodLVJv+VDKHQIB+w+OKyBXkbmGIafUE7thqAaOm5Ap3fvaFXxFQEn3W8fEfH8C6ZNtK4QJw== X-Received: by 10.80.242.153 with SMTP id f25mr4765938edm.52.1520729791097; Sat, 10 Mar 2018 16:56:31 -0800 (PST) Received: from [192.168.0.189] (dhcp-5-186-126-104.cgn.ip.fibianet.dk. [5.186.126.104]) by smtp.gmail.com with ESMTPSA id g50sm2940708edb.56.2018.03.10.16.56.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Mar 2018 16:56:30 -0800 (PST) Subject: Re: a Heisenbug tale To: Ard Biesheuvel , Rasmus Villemoes , Russell King References: <1520450729.13685.19.camel@nxp.com> From: Rasmus Villemoes Message-ID: <24703f21-6125-030d-e2ab-4b91cb5c25f8@rasmusvillemoes.dk> Date: Sun, 11 Mar 2018 01:56:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180310_165646_018798_DAEFB648 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Leonard Crestez , Herbert Xu , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 2018-03-09 10:45, Ard Biesheuvel wrote: > On 8 March 2018 at 23:19, Rasmus Villemoes wrote: >> On 2018-03-07 20:25, Leonard Crestez wrote: >>> Hello, >>> >> >> What we ended up doing was to explicitly set the mtime of every file in >> the repo to the same reference time after the git checkout (find ... | >> xargs touch --date=...). I also wanted to send a patch to change the >> Makefile to use the filechk mechanism to avoid updating the .S_shipped >> file when the script produced identical output, but never got around to it. >> > > I had no idea that _shipped files were causing issues like this, and > AFAICT, this is not specific to this use case in arch/arm/crypto, > right? > > Russell, would you mind if we removed the _shipped.S file here and > just assume that perl is available? > Well, in that case I won't need to write a proper changelog for the below, but this seems to work. It will of course still give the spurious build failures when perl is not available and one hits the "files got checked out at almost but not quite the same time", but it would have prevented the spurious -dirty bug. .PRECIOUS: $(obj)/sha256-core.S $(obj)/sha512-core.S diff --git a/arch/arm/crypto/Makefile b/arch/arm/crypto/Makefile index 30ef8e291271..f0cec9a92fd8 100644 --- a/arch/arm/crypto/Makefile +++ b/arch/arm/crypto/Makefile @@ -54,13 +54,14 @@ crct10dif-arm-ce-y := crct10dif-ce-core.o crct10dif-ce-glue.o crc32-arm-ce-y:= crc32-ce-core.o crc32-ce-glue.o chacha20-neon-y := chacha20-neon-core.o chacha20-neon-glue.o -quiet_cmd_perl = PERL $@ - cmd_perl = $(PERL) $(<) > $(@) +define filechk_perl + perl $< +endef $(src)/sha256-core.S_shipped: $(src)/sha256-armv4.pl - $(call cmd,perl) + $(call filechk,perl) $(src)/sha512-core.S_shipped: $(src)/sha512-armv4.pl - $(call cmd,perl) + $(call filechk,perl)