| Message ID | 2492577.tBEnW0tCHD@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/26/2017 12:42 AM, Sergei Shtylyov wrote: > Add the "vsps" property to the DU device node in order to link this node to > the VSPD nodes. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > Changes in version 2: > - rebased the patch. > > This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon Horman's > 'renesas.git' repo. It's only meaningful if the DRM driver patches I've just > posted are applied. Forgot to note that without this patch the DU driver fails to link to VSPD and probe correctly, so there's no video signal. So it makes sense to apply before the DU driver patch (once it's ACKed for merge)... MBR, Sergei
Hi Sergei, On Fri, Jan 27, 2017 at 3:42 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 01/26/2017 12:42 AM, Sergei Shtylyov wrote: > >> Add the "vsps" property to the DU device node in order to link this node >> to >> the VSPD nodes. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> --- >> Changes in version 2: >> - rebased the patch. >> >> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon >> Horman's >> 'renesas.git' repo. It's only meaningful if the DRM driver patches I've >> just >> posted are applied. > > > Forgot to note that without this patch the DU driver fails to link to > VSPD and probe correctly, so there's no video signal. So it makes sense to > apply before the DU driver patch (once it's ACKed for merge)... Doesn't that translate to breaking the DT ABI? Is there someway we can avoid doing that? Thanks, / magnus
On 2/1/2017 2:13 PM, Magnus Damm wrote: >>> Add the "vsps" property to the DU device node in order to link this node >>> to >>> the VSPD nodes. >>> >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>> >>> --- >>> Changes in version 2: >>> - rebased the patch. >>> >>> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon >>> Horman's >>> 'renesas.git' repo. It's only meaningful if the DRM driver patches I've >>> just >>> posted are applied. >> >> >> Forgot to note that without this patch the DU driver fails to link to >> VSPD and probe correctly, so there's no video signal. So it makes sense to >> apply before the DU driver patch (once it's ACKed for merge)... > > Doesn't that translate to breaking the DT ABI? Is there someway we can > avoid doing that? It doesn't -- if this patch is merged ahead of the DU patches. > Thanks, > > / magnus MBR, Sergei
Hi Sergei, On Wed, Feb 1, 2017 at 8:40 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 2/1/2017 2:13 PM, Magnus Damm wrote: > >>>> Add the "vsps" property to the DU device node in order to link this node >>>> to >>>> the VSPD nodes. >>>> >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> >>>> --- >>>> Changes in version 2: >>>> - rebased the patch. >>>> >>>> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon >>>> Horman's >>>> 'renesas.git' repo. It's only meaningful if the DRM driver patches >>>> I've >>>> just >>>> posted are applied. >>> >>> >>> >>> Forgot to note that without this patch the DU driver fails to link to >>> VSPD and probe correctly, so there's no video signal. So it makes sense >>> to >>> apply before the DU driver patch (once it's ACKed for merge)... >> >> >> Doesn't that translate to breaking the DT ABI? Is there someway we can >> avoid doing that? > > > It doesn't -- if this patch is merged ahead of the DU patches. Perhaps I'm misunderstanding, but if you require a DTS patch to be merged before a driver change then doesn't this mean that older DTBs will stop working with newer kernels and the user is forced to update the DTB to avoid breakage? It would be nice if older DTBs could keep on working as before and the DU driver modification would work both with connected VSPs and also keep on working as before in case the VSP connection is not present in DT. Cheers, / magnus
Hello! On 02/01/2017 03:01 PM, Magnus Damm wrote: >>>>> Add the "vsps" property to the DU device node in order to link this node >>>>> to >>>>> the VSPD nodes. >>>>> >>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>>> >>>>> --- >>>>> Changes in version 2: >>>>> - rebased the patch. >>>>> >>>>> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon >>>>> Horman's >>>>> 'renesas.git' repo. It's only meaningful if the DRM driver patches >>>>> I've >>>>> just >>>>> posted are applied. >>>> >>>> >>>> >>>> Forgot to note that without this patch the DU driver fails to link to >>>> VSPD and probe correctly, so there's no video signal. So it makes sense >>>> to >>>> apply before the DU driver patch (once it's ACKed for merge)... >>> >>> >>> Doesn't that translate to breaking the DT ABI? Is there someway we can >>> avoid doing that? >> >> >> It doesn't -- if this patch is merged ahead of the DU patches. > > Perhaps I'm misunderstanding, but if you require a DTS patch to be > merged before a driver change then doesn't this mean that older DTBs > will stop working with newer kernels and the user is forced to update > the DTB to avoid breakage? Yes, it seems so. :-( > It would be nice if older DTBs could keep on working as before and the > DU driver modification would work both with connected VSPs and also > keep on working as before in case the VSP connection is not present in > DT. I'll try to look into that... > Cheers, > > / magnus MBR, Sergei
Index: renesas/arch/arm/boot/dts/r8a7791.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi +++ renesas/arch/arm/boot/dts/r8a7791.dtsi @@ -992,7 +992,7 @@ power-domains = <&sysc R8A7791_PD_ALWAYS_ON>; }; - vsp1@fe930000 { + vspd0: vsp1@fe930000 { compatible = "renesas,vsp1"; reg = <0 0xfe930000 0 0x8000>; interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>; @@ -1000,7 +1000,7 @@ power-domains = <&sysc R8A7791_PD_ALWAYS_ON>; }; - vsp1@fe938000 { + vspd1: vsp1@fe938000 { compatible = "renesas,vsp1"; reg = <0 0xfe938000 0 0x8000>; interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>; @@ -1019,6 +1019,7 @@ <&mstp7_clks R8A7791_CLK_DU1>, <&mstp7_clks R8A7791_CLK_LVDS0>; clock-names = "du.0", "du.1", "lvds.0"; + vsps = <&vspd0 &vspd1>; status = "disabled"; ports {
Add the "vsps" property to the DU device node in order to link this node to the VSPD nodes. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- Changes in version 2: - rebased the patch. This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon Horman's 'renesas.git' repo. It's only meaningful if the DRM driver patches I've just posted are applied. arch/arm/boot/dts/r8a7791.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)