| Message ID | 266765abb8251bd60796a3c4270e3809bfff952e.1738777221.git.u.kleine-koenig@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | pwm: pxa: Use #pwm-cells = <3> | expand |
On Wed, Feb 05, 2025 at 06:54:01PM +0100, Uwe Kleine-König wrote: > The PXA PWM binding is the only one that doesn't pass the PWM line index > as first parameter of the parameter cells. However this can be upgraded > to the mandatory binding for all new PWM drivers without breaking > compatibility for old device trees using #pwm-cells = <1>. > > So bump #pwm-cells to 3 with the (undocumented) promise to keep the old > behaviour for #pwm-cells = <1>. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Wed, 05 Feb 2025 18:54:01 +0100, Uwe Kleine-König wrote: > The PXA PWM binding is the only one that doesn't pass the PWM line index > as first parameter of the parameter cells. However this can be upgraded > to the mandatory binding for all new PWM drivers without breaking > compatibility for old device trees using #pwm-cells = <1>. > > So bump #pwm-cells to 3 with the (undocumented) promise to keep the old > behaviour for #pwm-cells = <1>. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> > --- > Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.example.dtb: pwm@40b00000: #pwm-cells: 3 was expected from schema $id: http://devicetree.org/schemas/pwm/marvell,pxa-pwm.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/266765abb8251bd60796a3c4270e3809bfff952e.1738777221.git.u.kleine-koenig@baylibre.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml index 9ee1946dc2e1..ba7fba67e19e 100644 --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml @@ -25,8 +25,7 @@ properties: maxItems: 1 "#pwm-cells": - # Used for specifying the period length in nanoseconds - const: 1 + const: 3 clocks: maxItems: 1
The PXA PWM binding is the only one that doesn't pass the PWM line index as first parameter of the parameter cells. However this can be upgraded to the mandatory binding for all new PWM drivers without breaking compatibility for old device trees using #pwm-cells = <1>. So bump #pwm-cells to 3 with the (undocumented) promise to keep the old behaviour for #pwm-cells = <1>. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> --- Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)