From patchwork Wed Feb 15 18:14:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 9574719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 14F1360209 for ; Wed, 15 Feb 2017 18:14:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F23DD28503 for ; Wed, 15 Feb 2017 18:14:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6F1C28504; Wed, 15 Feb 2017 18:14:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5A02728494 for ; Wed, 15 Feb 2017 18:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+/gkUSnSsxBflTZgxxbtej21V4vZohpXdAIM2RJzcVA=; b=pnxPP8H1NdKTsi c0rZKmnk6ecJOJG0tmtQ09/Yf17kDNS/bV/byGgLrn41z92pGMweNd49Rjfd9ZvLJFivrv+cZCN9e vExyjoynBVmYu0X7hK/g4I965VKYKMQwHm/FUFsc4hCr8VrME0yD8Gt2W4P4kglqmh7DBXoi2YMuz rAxsppNAVvqJKSHfzDIKd4ttJx0r36WJfj/G7B/6jNMCBSCorgRbbVO6LdYGsQEuGidjNbdggCjPB oKa+pYGQEZjZgXYDoaLO3fTk53sTvmg+r8WWwcX0zyn5MEiemy1HU0nFvDQaM8r5AxxSzjkPeF2f0 9nMnJiDcmsTCX/LOu1Cw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1ce46G-0000mH-Dy; Wed, 15 Feb 2017 18:14:44 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ce46C-0000i5-Cz for linux-arm-kernel@lists.infradead.org; Wed, 15 Feb 2017 18:14:42 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8053FAC57; Wed, 15 Feb 2017 18:14:16 +0000 (UTC) Subject: Re: [PATCH 11/11] ARM64: dts: Prepare Actions Semi S900 and Bubblegum-96 To: Mark Rutland References: <20170215165528.10052-1-afaerber@suse.de> <20170215165528.10052-12-afaerber@suse.de> <20170215171232.GI31733@leverpostej> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <267b586e-06ce-f123-b7cc-dc0feb880ca9@suse.de> Date: Wed, 15 Feb 2017 19:14:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170215171232.GI31733@leverpostej> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170215_101440_861050_39C107AD X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, info@ucrobotics.com, Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , mp-cs@actions-semi.com, Catalin Marinas , nd@arm.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Am 15.02.2017 um 18:12 schrieb Mark Rutland: > On Wed, Feb 15, 2017 at 05:55:28PM +0100, Andreas Färber wrote: >> +#include "s900.dtsi" >> + >> +/ { >> + compatible = "ucrobotics,bubblegum-96", "acts,s900"; >> + model = "Bubblegum-96"; >> + >> + aliases { >> + serial5 = &uart5; >> + }; >> + >> + chosen { >> + stdout-path = "serial5:115200n8"; >> + }; >> +}; > > I didn't spot a memory node here or in the dtsi. Does the FW/bootloader > create one? Heh, apparently... For S500, skeleton.dtsi added that - not entirely clean either. I'll add one here in the .dts and think about adding one in s500-guitar.dtsi as well. >> + >> + psci { >> + compatible = "arm,psci-0.2"; >> + method = "smc"; >> + }; >> + >> + arm-pmu { >> + compatible = "arm,cortex-a53-pmu"; >> + interrupts = , >> + , >> + , >> + ; >> + }; > > Please ad an interrupt-affinity property, as described in > Documentation/devicetree/bindings/arm/pmu.txt. I had done my best to check my properties matched the bindings, but you caught me not checking for any missing properties. Again, my guess is: @@ -99,6 +104,7 @@ , , ; + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; }; timer { >> + >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, >> + > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, >> + > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, >> + > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; >> + }; >> + >> + soc { >> + compatible = "simple-bus"; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + gic: interrupt-controller@e00f1000 { >> + compatible = "arm,gic-400"; >> + reg = <0x0 0xe00f1000 0x0 0x1000>, >> + <0x0 0xe00f2000 0x0 0x1000>, >> + <0x0 0xe00f4000 0x0 0x2000>, >> + <0x0 0xe00f6000 0x0 0x2000>; > > I believe that the second entry should be 0x2000 in length. The vendor tree does have 0x1000, but that might be a mistake of course. I vaguely recall having such discussions elsewhere in the past. @@ -122,7 +128,7 @@ gic: interrupt-controller@e00f1000 { compatible = "arm,gic-400"; reg = <0x0 0xe00f1000 0x0 0x1000>, - <0x0 0xe00f2000 0x0 0x1000>, + <0x0 0xe00f2000 0x0 0x2000>, <0x0 0xe00f4000 0x0 0x2000>, <0x0 0xe00f6000 0x0 0x2000>; interrupts = ; Thanks for the quick review, Andreas --- a/arch/arm64/boot/dts/actions/s900-bubblegum96.dts +++ b/arch/arm64/boot/dts/actions/s900-bubblegum96.dts @@ -55,6 +55,11 @@ chosen { stdout-path = "serial5:115200n8"; }; + + memory { + device_type = "memory"; + reg = <0x0 0x0 0x0 0x80000000>; + }; }; &uart5 { >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + }; > > Why have this empty node? Forgotten about... I see these: reserving fdt memory region: addr=19000000 size=3000000 reserving fdt memory region: addr=20000000 size=20000000 reserving fdt memory region: addr=18fff000 size=1000 reserving fdt memory region: addr=1f000000 size=1000000 Vendor tree says 0x1f000000 is for secure monitor; 0x19000000 for fb, 0x20000000 for ion (ignoring), and 0x20000000 for afinfo - whatever that may be (not me! :)). So as minimum: --- a/arch/arm64/boot/dts/actions/s900.dtsi +++ b/arch/arm64/boot/dts/actions/s900.dtsi @@ -86,6 +86,11 @@ #address-cells = <2>; #size-cells = <2>; ranges; + + secmon@1f000000 { + reg = <0x0 0x1f000000 0x0 0x1000000>; + no-map; + }; }; psci {