| Message ID | 2701c187cf8e0762df38f68cc069ec2c29a3b5a9.1626283322.git.robin.murphy@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: fvp: Remove panel timings | expand |
On Wed, Jul 14, 2021 at 7:22 PM Robin Murphy <robin.murphy@arm.com> wrote: > The simple-panel driver already has hard-coded timings for > "arm,rtsm-display", and as such screams at us for trying to override a > fixed mode from DT. Since the exact values probably don't matter all > that much anyway, just remove the DT node to keep boot quiet. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> Thanks for fixing this, I must have forgotten about it when I added the RTSM display type. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Wed, Jul 14, 2021 at 06:22:38PM +0100, Robin Murphy wrote: > The simple-panel driver already has hard-coded timings for > "arm,rtsm-display", and as such screams at us for trying to override a > fixed mode from DT. Since the exact values probably don't matter all > that much anyway, just remove the DT node to keep boot quiet. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- > arch/arm64/boot/dts/arm/fvp-base-revc.dts | 12 ------------ > 1 file changed, 12 deletions(-) > Hi Robin, Does this need go as fix for v5.14 ? Or can it wait for v5.15 ? Fine either way, let me know. -- Regards, Sudeep
On 2021-07-15 11:57, Sudeep Holla wrote: > On Wed, Jul 14, 2021 at 06:22:38PM +0100, Robin Murphy wrote: >> The simple-panel driver already has hard-coded timings for >> "arm,rtsm-display", and as such screams at us for trying to override a >> fixed mode from DT. Since the exact values probably don't matter all >> that much anyway, just remove the DT node to keep boot quiet. >> >> Signed-off-by: Robin Murphy <robin.murphy@arm.com> >> --- >> arch/arm64/boot/dts/arm/fvp-base-revc.dts | 12 ------------ >> 1 file changed, 12 deletions(-) >> > > Hi Robin, > > Does this need go as fix for v5.14 ? Or can it wait for v5.15 ? > Fine either way, let me know. It's just cleanup really, so 5.15 is fine by me - the driver ignores the DT data so it has no functional effect, it's merely that the warning is annoying. Thanks, Robin.
On Wed, 14 Jul 2021 18:22:38 +0100, Robin Murphy wrote: > The simple-panel driver already has hard-coded timings for > "arm,rtsm-display", and as such screams at us for trying to override a > fixed mode from DT. Since the exact values probably don't matter all > that much anyway, just remove the DT node to keep boot quiet. Applied to sudeep.holla/linux (for-next/juno), thanks! [1/1] arm64: dts: fvp: Remove panel timings https://git.kernel.org/sudeep.holla/c/15934f515911 -- Regards, Sudeep
diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts index b8a21092db4d..2732d8e5bb5d 100644 --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts @@ -192,18 +192,6 @@ panel_in: endpoint { remote-endpoint = <&clcd_pads>; }; }; - - panel-timing { - clock-frequency = <63500127>; - hactive = <1024>; - hback-porch = <152>; - hfront-porch = <48>; - hsync-len = <104>; - vactive = <768>; - vback-porch = <23>; - vfront-porch = <3>; - vsync-len = <4>; - }; }; bus@8000000 {
The simple-panel driver already has hard-coded timings for "arm,rtsm-display", and as such screams at us for trying to override a fixed mode from DT. Since the exact values probably don't matter all that much anyway, just remove the DT node to keep boot quiet. Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 12 ------------ 1 file changed, 12 deletions(-)