From patchwork Mon Sep 8 11:02:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 4861281 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 65107C0338 for ; Mon, 8 Sep 2014 11:05:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4526D20138 for ; Mon, 8 Sep 2014 11:05:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9572E20131 for ; Mon, 8 Sep 2014 11:05:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XQwjB-0007Bm-U3; Mon, 08 Sep 2014 11:03:21 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XQwj4-0006xJ-Kv for linux-arm-kernel@lists.infradead.org; Mon, 08 Sep 2014 11:03:15 +0000 Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue105) with ESMTP (Nemesis) id 0MWBZZ-1XtNju46Z7-00XPKA; Mon, 08 Sep 2014 13:02:36 +0200 From: Arnd Bergmann To: linux-kernel@vger.kernel.org Subject: "mm: introduce dump_vma fix 2" still broken Date: Mon, 08 Sep 2014 13:02:33 +0200 Message-ID: <2815658.dHHBXc7oHP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V02:K0:zuka6K9IRPvXw1rMt0t9D130i1S+j2LLvPlezC5Ir4x gskJerYAYmG3UytxRaVaQsH3BVoJbsjFyeyctPDDliOCDbV5jc zT91/YSoBKxFU4QeSpI8GoO3kxes6jGMMlRYgbwKUQlfk2VgWa qIqFY6WiARwizXU9TV8FJVxSqQzWNv046xG/Kjp3lllJV1l92R N+jzihCqURz3vEdRbgEeJ43cYB4Ch/LvaATXZYBsp0g8uRk417 EfhWG4wkSra0GC9ylidZLltZlIQXmLapKgRC4KmqeavnSa9cIY HUyFi2wKsZYhI1CG+zoLIPbuBMiRYyNsLhijQeV7PArN4ZD8Dm XlsdaFDeTzvo6QCABph4= X-UI-Out-Filterresults: notjunk:1; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140908_040315_004028_87B6C056 X-CRM114-Status: UNSURE ( 8.45 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) Cc: Stephen Rothwell , Andrew Morton , Naoya Horiguchi , linux-arm-kernel@lists.infradead.org, Sasha Levin X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I saw this commit today in linux-next, which fixes a build error, but introduces a new warning: commit a60224c708f880dd937b352b7461cbf14e93012d Author: Stephen Rothwell Date: Mon Sep 8 19:41:54 2014 +1000 mm: introduce dump_vma fix 2 Signed-off-by: Stephen Rothwell /git/arm-soc/mm/page_alloc.c: In function 'dump_vma': /git/arm-soc/mm/page_alloc.c:6744:3: warning: format '%lx' expects argument of type 'long unsigned int', but argument 8 has type 'pgprot_t' [-Wformat=] vma->vm_file, vma->vm_private_data); ^ This happens on machines that use ARM LPAE, where pgprot_t is in fact a 64-bit integer. The simplest fix I see would be add a cast to u64 and always print this as a 64bit value. Arnd diff --git a/mm/page_alloc.c b/mm/page_alloc.c index cb510c08073b..0de60769bcf6 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6739,7 +6739,7 @@ void dump_vma(const struct vm_area_struct *vma) "prot %lx anon_vma %p vm_ops %p\n" "pgoff %lx file %p private_data %p\n", vma, (void *)vma->vm_start, (void *)vma->vm_end, vma->vm_next, - vma->vm_prev, vma->vm_mm, vma->vm_page_prot.pgprot, + vma->vm_prev, vma->vm_mm, pgprot_val(vma->vm_page_prot), vma->anon_vma, vma->vm_ops, vma->vm_pgoff, vma->vm_file, vma->vm_private_data); dump_flags(vma->vm_flags, vmaflags_names, ARRAY_SIZE(vmaflags_names));