From patchwork Mon Apr 8 09:57:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 2406361 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 491E8DFB78 for ; Mon, 8 Apr 2013 09:58:06 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UP8pb-0008E5-3f; Mon, 08 Apr 2013 09:57:43 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UP8pX-0006aj-VM; Mon, 08 Apr 2013 09:57:39 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UP8pT-0006aJ-V7 for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2013 09:57:37 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MKX0005DKZS97V0@mailout3.samsung.com> for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2013 18:57:33 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 98.60.07735.D8492615; Mon, 08 Apr 2013 18:57:33 +0900 (KST) X-AuditID: cbfee68e-b7f946d000001e37-56-5162948d87b2 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id EC.74.17838.D8492615; Mon, 08 Apr 2013 18:57:33 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.120.199]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MKX00CEWKZXJ840@mmp2.samsung.com>; Mon, 08 Apr 2013 18:57:33 +0900 (KST) From: Kukjin Kim To: 'Sylwester Nawrocki' References: <1365366442-16025-1-git-send-email-s.nawrocki@samsung.com> In-reply-to: <1365366442-16025-1-git-send-email-s.nawrocki@samsung.com> Subject: RE: [PATCH] ARM: Samsung: Select ARM_CPU_SUSPEND when required Date: Mon, 08 Apr 2013 18:57:33 +0900 Message-id: <2cd601ce343f$7d6aac50$784004f0$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4zzlc5CvYu76EbTyS+jitaW+ZqbgAcEvpg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t8zA93eKUmBBj3/RS02Pb7GajHj/D4m i8Nv2lktFmx8xGgx7/NOJgdWj52z7rJ7bF5S79G3ZRWjx+dNcgEsUVw2Kak5mWWpRfp2CVwZ hzqbmQpWSVVsW9LE2MDYLdbFyMkhIWAi8anvKjOELSZx4d56ti5GLg4hgWWMEns6z7PDFD1a eZoVIjGdUeLk65VQVX8ZJT43L2MBqWIT0JA4/P4ZWIeIgLlE579+ZpAiZoEpjBJX//cxgSSE BNwkVn7fyQZicwq4S3y4MA2sWRjIbjh+Dcjm4GARUJVY90sGJMwrYCuxaeVJdghbUOLH5Htg 5cwCWhLrdx5ngrDlJTavecsM0iohoC7x6K8uxAlGEguvbIEqF5HY9+IdI8g5EgLX2CVuTJ0L 1ssiICDxbfIhFoheWYlNB6AhISlxcMUNlgmMErOQbJ6FZPMsJJtnIVmxgJFlFaNoakFyQXFS epGRXnFibnFpXrpecn7uJkZIfPbtYLx5wPoQYzLQ+onMUqLJ+cD4ziuJNzQ2M7IwNTE1NjK3 NCNNWEmcV63FOlBIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDI9/Ll9r9gUIGIRvW7hXaMHd5 z7MD3ra9uoaLTJe2TSg7xBLh8WB3crWg19IVURZ/g5cGyX7o1jJonq6gXnH9e0PItILQAoWL uic8XP/Glp576aI7+7/YJq6JH+2undXwYY74viz7sILkdO/JC+uMdufXvHG5Gl8Q63lhYQLv /5ZLtVdZeiLqlViKMxINtZiLihMBytGvweUCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsVy+t9jQd3eKUmBBo3fBSw2Pb7GajHj/D4m i8Nv2lktFmx8xGgx7/NOJgdWj52z7rJ7bF5S79G3ZRWjx+dNcgEsUQ2MNhmpiSmpRQqpecn5 KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAe5UUyhJzSoFCAYnFxUr6dpgm hIa46VrANEbo+oYEwfUYGaCBhHWMGYc6m5kKVklVbFvSxNjA2C3WxcjJISFgIvFo5WlWCFtM 4sK99WxdjFwcQgLTGSVOvl4J5fxllPjcvIwFpIpNQEPi8Ptn7CC2iIC5ROe/fmaQImaBKYwS V//3MYEkhATcJFZ+38kGYnMKuEt8uDANrFkYyG44fg3I5uBgEVCVWPdLBiTMK2ArsWnlSXYI W1Dix+R7YOXMAloS63ceZ4Kw5SU2r3nLDNIqIaAu8eivLsQJRhILr2yBKheR2PfiHeMERqFZ SCbNQjJpFpJJs5C0LGBkWcUomlqQXFCclJ5rqFecmFtcmpeul5yfu4kRHP3PpHYwrmywOMQo wMGoxMMr+SMxUIg1say4MvcQowQHs5II78PapEAh3pTEyqrUovz4otKc1OJDjMlAf05klhJN zgcmprySeENjEzMjSyMzCyMTc3PShJXEeQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYORkdXGx 2rfQYJuGZOuRIx5ratl45zu/farXtslL7P3vs93Pz+qt4ljjw+01mf3YvD8nC92YemPmG0k5 /i66sUaOY0/jhTSvKbPOuWxVmO678UyCZoGIS7OYfWHQhVOmczzZXHsLSo5wm38TWWxRdrlF v/Yvo9TR+2vOrWQu/cmx7cf0f6rbDiuxFGckGmoxFxUnAgC8Ju1SQgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130408_055736_241855_D5715521 X-CRM114-Status: GOOD ( 18.83 ) X-Spam-Score: -9.3 (---------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-9.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.33 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: stable@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Sylwester Nawrocki' , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Sylwester Nawrocki wrote: > > The power management code of S3C24XX, S3C64XX, S5PV210 platform in > arch/arm/plat-samsung/, arch/arm/mach-s3c24xx/, arch/arm/mach-s3c64xx/ > directories uses generic cpu_suspend routine. Make sure it is compiled > in when building with power management support. Without this patch > compilation fails with errors as below. It can be reproduced by using > default config files with CONFIG_SUSPEND disabled and CONFIG_PM_RUNTIME > enabled. > > - s5pv210_defconfig > arch/arm/plat-samsung/built-in.o: In function `s3c_pm_enter': > arch/arm/plat-samsung/pm.c:304: undefined reference to `cpu_suspend' > arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': > arch/arm/plat-samsung/s5p-sleep.S:74: undefined reference to `cpu_resume' > > - s3c24xx_defconfig > arch/arm/mach-s3c24xx/built-in.o: In function `s3c_cpu_resume': > arch/arm/mach-s3c24xx/sleep.S:83: undefined reference to `cpu_resume' > arch/arm/plat-samsung/built-in.o: In function `s3c_pm_enter': > arch/arm/plat-samsung/pm.c:304: undefined reference to `cpu_suspend' > > - s3c64xx_defconfig > arch/arm/mach-s3c64xx/built-in.o: In function `s3c_cpu_resume': > arch/arm/mach-s3c64xx/sleep.S:72: undefined reference to `cpu_resume' > arch/arm/plat-samsung/built-in.o: In function `s3c_pm_enter': > arch/arm/plat-samsung/pm.c:304: undefined reference to `cpu_suspend' > > To fix this issue select ARM_CPU_SUSPEND for PLAT_SAMSUNG when PM is set. > > The build break occurs for kernels at least back to v3.0, however this > patch applies without conflicts only back to v3.7. > > Signed-off-by: Sylwester Nawrocki > Cc: stable@vger.kernel.org > --- > arch/arm/plat-samsung/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index 54d1861..02355ba 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig > @@ -10,6 +10,7 @@ config PLAT_SAMSUNG > default y > select GENERIC_IRQ_CHIP > select NO_IOPORT > + select ARM_CPU_SUSPEND if PM > help > Base platform code for all Samsung SoC based systems > > -- > 1.7.4.1 Yes, right. The pm.c in plat-samsung should be built with arch/arm/kernel/sleep.S and suspend.c. BTW it should be shown in alphabetical order and we don't need more following in mach-exynos. --------8<----------------8<-------- --------8<----------------8<-------- If you have any objections, let me know. Thanks. - Kukjin diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 2f45906..bc0a8b2 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -31,7 +31,6 @@ config CPU_EXYNOS4210 bool "SAMSUNG EXYNOS4210" default y depends on ARCH_EXYNOS4 - select ARM_CPU_SUSPEND if PM select PM_GENERIC_DOMAINS select S5P_PM if PM select S5P_SLEEP if PM diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index b708b3e..30a976d 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -8,6 +8,7 @@ config PLAT_SAMSUNG Bool depends on PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P default y + select ARM_CPU_SUSPEND if PM select GENERIC_IRQ_CHIP select NO_IOPORT help