diff mbox series

arm64: dts: airoha: en7581: Add gpio controller nodes

Message ID 2d27e1ad360dec2c3d78d9800bc93ecb6f9b50c5.1714573214.git.lorenzo@kernel.org (mailing list archive)
State New, archived
Headers show
Series arm64: dts: airoha: en7581: Add gpio controller nodes | expand

Commit Message

Lorenzo Bianconi May 1, 2024, 2:25 p.m. UTC
Introduce the Airoha EN7581 gpio nodes in Airoha EN7581 dtsi

Tested-by: Rajeev Kumar <Rajeev.Kumar@airoha.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
This patch is based on the following pending patch:
https://patchwork.kernel.org/project/spi-devel-general/patch/189790802f3ba1a80c4ab5e064b2425e5a360098.1714571980.git.lorenzo@kernel.org/
---
 arch/arm64/boot/dts/airoha/en7581.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Bartosz Golaszewski May 5, 2024, 12:22 p.m. UTC | #1
On Wed, May 1, 2024 at 4:26 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> Introduce the Airoha EN7581 gpio nodes in Airoha EN7581 dtsi
>
> Tested-by: Rajeev Kumar <Rajeev.Kumar@airoha.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> This patch is based on the following pending patch:
> https://patchwork.kernel.org/project/spi-devel-general/patch/189790802f3ba1a80c4ab5e064b2425e5a360098.1714571980.git.lorenzo@kernel.org/
> ---
>  arch/arm64/boot/dts/airoha/en7581.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi
> index 98c2a86086e1..5d0d76cecfe0 100644
> --- a/arch/arm64/boot/dts/airoha/en7581.dtsi
> +++ b/arch/arm64/boot/dts/airoha/en7581.dtsi
> @@ -178,5 +178,25 @@ spi_nand: nand@0 {
>                                 spi-rx-bus-width = <2>;
>                         };
>                 };
> +
> +               gpio0: gpio@1fbf0200 {

These labels are not used anywhere.

Bart

> +                       compatible = "airoha,en7523-gpio";
> +                       reg = <0 0x1fbf0204 0 0x4>,
> +                             <0 0x1fbf0200 0 0x4>,
> +                             <0 0x1fbf0220 0 0x4>,
> +                             <0 0x1fbf0214 0 0x4>;
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +               };
> +
> +               gpio1: gpio@1fbf0270 {
> +                       compatible = "airoha,en7523-gpio";
> +                       reg = <0 0x1fbf0270 0 0x4>,
> +                             <0 0x1fbf0260 0 0x4>,
> +                             <0 0x1fbf0264 0 0x4>,
> +                             <0 0x1fbf0278 0 0x4>;
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +               };
>         };
>  };
> --
> 2.44.0
>
Lorenzo Bianconi May 7, 2024, 10:05 a.m. UTC | #2
> On Wed, May 1, 2024 at 4:26 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >
> > Introduce the Airoha EN7581 gpio nodes in Airoha EN7581 dtsi
> >
> > Tested-by: Rajeev Kumar <Rajeev.Kumar@airoha.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > This patch is based on the following pending patch:
> > https://patchwork.kernel.org/project/spi-devel-general/patch/189790802f3ba1a80c4ab5e064b2425e5a360098.1714571980.git.lorenzo@kernel.org/
> > ---
> >  arch/arm64/boot/dts/airoha/en7581.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi
> > index 98c2a86086e1..5d0d76cecfe0 100644
> > --- a/arch/arm64/boot/dts/airoha/en7581.dtsi
> > +++ b/arch/arm64/boot/dts/airoha/en7581.dtsi
> > @@ -178,5 +178,25 @@ spi_nand: nand@0 {
> >                                 spi-rx-bus-width = <2>;
> >                         };
> >                 };
> > +
> > +               gpio0: gpio@1fbf0200 {
> 
> These labels are not used anywhere.
> 
> Bart

ack. Let's drop this patch for the moment, I am planning to the work gpio
support.

Regards,
Lorenzo

> 
> > +                       compatible = "airoha,en7523-gpio";
> > +                       reg = <0 0x1fbf0204 0 0x4>,
> > +                             <0 0x1fbf0200 0 0x4>,
> > +                             <0 0x1fbf0220 0 0x4>,
> > +                             <0 0x1fbf0214 0 0x4>;
> > +                       gpio-controller;
> > +                       #gpio-cells = <2>;
> > +               };
> > +
> > +               gpio1: gpio@1fbf0270 {
> > +                       compatible = "airoha,en7523-gpio";
> > +                       reg = <0 0x1fbf0270 0 0x4>,
> > +                             <0 0x1fbf0260 0 0x4>,
> > +                             <0 0x1fbf0264 0 0x4>,
> > +                             <0 0x1fbf0278 0 0x4>;
> > +                       gpio-controller;
> > +                       #gpio-cells = <2>;
> > +               };
> >         };
> >  };
> > --
> > 2.44.0
> >
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi
index 98c2a86086e1..5d0d76cecfe0 100644
--- a/arch/arm64/boot/dts/airoha/en7581.dtsi
+++ b/arch/arm64/boot/dts/airoha/en7581.dtsi
@@ -178,5 +178,25 @@  spi_nand: nand@0 {
 				spi-rx-bus-width = <2>;
 			};
 		};
+
+		gpio0: gpio@1fbf0200 {
+			compatible = "airoha,en7523-gpio";
+			reg = <0 0x1fbf0204 0 0x4>,
+			      <0 0x1fbf0200 0 0x4>,
+			      <0 0x1fbf0220 0 0x4>,
+			      <0 0x1fbf0214 0 0x4>;
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
+
+		gpio1: gpio@1fbf0270 {
+			compatible = "airoha,en7523-gpio";
+			reg = <0 0x1fbf0270 0 0x4>,
+			      <0 0x1fbf0260 0 0x4>,
+			      <0 0x1fbf0264 0 0x4>,
+			      <0 0x1fbf0278 0 0x4>;
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
 	};
 };