From patchwork Tue Oct 6 21:47:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7340241 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B8FA8BEEA4 for ; Tue, 6 Oct 2015 21:50:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E2F9A20394 for ; Tue, 6 Oct 2015 21:50:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00B5F202A1 for ; Tue, 6 Oct 2015 21:50:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zja5n-0001VG-Hy; Tue, 06 Oct 2015 21:48:15 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zja5l-0001R8-7D for linux-arm-kernel@lists.infradead.org; Tue, 06 Oct 2015 21:48:13 +0000 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0M5fdw-1aYGvz3MyG-00xdP7; Tue, 06 Oct 2015 23:47:47 +0200 From: Arnd Bergmann To: netdev@vger.kernel.org Subject: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Date: Tue, 06 Oct 2015 23:47:44 +0200 Message-ID: <30258520.VaA2vDyUiY@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:EQ9Q4GkIsVgOA5iC4ewbyRKIM2d/OVyxxi7dnIAKkItcIik208q YTYdcVZCzvWGRojqEioHyaOnZhbe5DlaE67dRP6WQFoE1tBoC5vKlM7LMHnnWa/Ji70OiJj WnzOYPoErgNNxwHZtCT9X8EEOV7uayXrveMOhyXdbm4YBPzACmNDPpBV8VmIKIvtuBswn7s corESEZ1PGnHyAVljBE+Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:9iPIlzOVvXQ=:uR79yiSDqQ1oDryG8dqMxM JYfsr860eILJdXOeLw8nS3wa1bi5sIzgVkDi05UcTF7DJLXkPVUKDFOgsVhdYVT3x97Pt+eUq aDNfdyv9QjF0Ggv2uvJpQKVh85sA1yIXDw1WXg41t1L/bnMvvxgFDYczohTg/UFusIe6jZETH FTt/ARPntAkihy1NNm+4XCHSJp+8HJPGUgJqm/dZp5XeS4Sm0bXflpTrJ+xcsWO2mNmrUOuWt EkIOC8Z+NvC57wF0J0sS4OWljP2eRx1s7Ne7nL8MpX7Nqj3InIOj/hwTX3ROMeaZqB48+07nj O4RPPzWTTKUxCG3jcs4690H9hnkmjh3Gh2aD8YH8nBfSqqmQudPhWhj8spp9qQcZrV9wzk852 2pHUpkg1DmKQvBfSTSZ9ovBeHifCzp6qc7RxwwzToOWbF/lgKYpq03WcMmidLvZJ8h6I3Cfyx gj7qF4qK5nSTKbrwBn58/8jVsxtKpEjWUHwqm0hZi1HVRKYAfC0zyL8oVS8TI1Mt4bdZDHKMJ PJZqc4sZv5VcHjks7FLNbrz4KKIl8RJJzhIR6z0LQ3v5AWPeXSZdIwixHQSgTqxDOKxklLz3y pxgul7hJbDSica/H6oUE0vz9dOSwfVnZnUk1eSDz1zRwZCTfG01bJcrAUnjTc6DdgahZqZaif wVom0acuZ3T72PgPUsZTBro/1DL2IQs0ZgxgobiN/r3F0BaeimjzNqr54MAlVlySyijYxQq0z eSWhAwSPNjmc1f0i X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151006_144813_466388_A4C6672C X-CRM114-Status: GOOD ( 13.22 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Ido Schimmel , Jiri Pirko , Scott Feldman , Elad Raz , davem@davemloft.net, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The recently added mlxsw driver produces warnings in ARM allmodconfig: drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow] linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32' drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be' This changes the type of the local variable to u64, which gets rid of the warning and seems nicer than adding #ifdefs. Signed-off-by: Arnd Bergmann Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" Acked-by: Jiri Pirko diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c index 462cea31ecbb..cd11e3591741 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/pci.c +++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c @@ -1567,8 +1567,8 @@ static int mlxsw_pci_cmd_exec(void *bus_priv, u16 opcode, u8 opcode_mod, u8 *p_status) { struct mlxsw_pci *mlxsw_pci = bus_priv; - dma_addr_t in_mapaddr = mlxsw_pci->cmd.in_mbox.mapaddr; - dma_addr_t out_mapaddr = mlxsw_pci->cmd.out_mbox.mapaddr; + u64 in_mapaddr = mlxsw_pci->cmd.in_mbox.mapaddr; + u64 out_mapaddr = mlxsw_pci->cmd.out_mbox.mapaddr; bool evreq = mlxsw_pci->cmd.nopoll; unsigned long timeout = msecs_to_jiffies(MLXSW_PCI_CIR_TIMEOUT_MSECS); bool *p_wait_done = &mlxsw_pci->cmd.wait_done;