From patchwork Mon Aug 26 10:06:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 2849505 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 75455BF546 for ; Mon, 26 Aug 2013 10:07:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 67CC020131 for ; Mon, 26 Aug 2013 10:07:51 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 303702012E for ; Mon, 26 Aug 2013 10:07:50 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VDti7-0005tg-8B; Mon, 26 Aug 2013 10:07:47 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VDti5-0002Rm-0h; Mon, 26 Aug 2013 10:07:45 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VDti0-0002RA-Ge for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2013 10:07:42 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MS40075KURWQX51@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2013 19:07:08 +0900 (KST) X-AuditID: cbfee61b-b7f776d0000016c8-cd-521b28cc15c1 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 59.D0.05832.CC82B125; Mon, 26 Aug 2013 19:07:08 +0900 (KST) Received: from amdc1032.localnet ([106.116.147.136]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MS4008SIURVA360@mmp1.samsung.com>; Mon, 26 Aug 2013 19:07:08 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Kukjin Kim Subject: Re: [GIT PULL 3/3] 2nd Round Samsung mach-exynos for v3.12 Date: Mon, 26 Aug 2013 12:06:48 +0200 Message-id: <3145165.ZB7l3vNJ7a@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-45-generic; KDE/4.8.5; i686; ; ) In-reply-to: <1f7701cea1f1$431f2d30$c95d8790$%kim@samsung.com> References: <1f7701cea1f1$431f2d30$c95d8790$%kim@samsung.com> MIME-version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t9jAd0zGtJBBk0nxCwaroZYHPuyhc3i 76Rj7Ba9C66yWWx6fI3VYsb5fUwWp65/ZnNg9/j9axKjx6ZVnWwem5fUe1w50cTq0bdlFaPH 501yAWxRXDYpqTmZZalF+nYJXBm/7x9kLXgrWNE8/R9TA2M7XxcjJ4eEgInEzokfmSBsMYkL 99azdTFycQgJLGKU2H/5AVhCSKCFSeL9TFcQm03ASmJi+ypGEFtEQE2iZ/FWRpAGZoFXjBLH Zs1gA0kICzhL9F55AWazCKhKnL+2GWgQBwevgKbEtmlVIGFRAVeJc4t+sIDYnAJ2ErvPbWOF 2GUr0bd2FtheXgFBiR+T74HVMAvIS+zbP5UVwtaSWL/zONMERoFZSMpmISmbhaRsASPzKkbR 1ILkguKk9FwjveLE3OLSvHS95PzcTYzgUH8mvYNxVYPFIUYBDkYlHt4ANukgIdbEsuLK3EOM EhzMSiK85qJAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rwHW60DhQTSE0tSs1NTC1KLYLJMHJxS DYzMqjs8+V7adjKK3rshqfrC9MtN86DaU8/8TMR1hJM/ytwp3HS3/po4r66jz6aC4EXu4sWp fFWB09gEpzHPl4mudS0qZBDhWHcr4mPxk25rm6L2WrdkS/PyapsfRmXXHpqHR4hxP1g2sz8y KW9DZOBy9gOnN2Y535sh59B9+LqV3f9Jn4QDlFiKMxINtZiLihMBvhD84XECAAA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130826_060740_799470_4AC21173 X-CRM114-Status: GOOD ( 12.41 ) X-Spam-Score: -9.3 (---------) Cc: 'linux-samsung-soc' , 'Arnd Bergmann' , Amit Daniel Kachhap , arm@kernel.org, 'Olof Johansson' , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Monday, August 26, 2013 09:14:42 AM Kukjin Kim wrote: > The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092: > > Linux 3.11-rc1 (2013-07-14 15:18:27 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > tags/samsung-mach-exynos > > for you to fetch changes up to f52616f4233d71d0fb00f06f86d046d18d2b7f3b: > > ARM: EXYNOS: always enable PM domains support for EXYNOS4X12 (2013-08-19 > 05:05:16 +0900) > > ---------------------------------------------------------------- > update mach-exynos > - enable ARCH_HAS_BANDGAP for exynos SoCs > - skip C1 cpuidle for exynos5440 because non-supporting > - always enable PM domains for exynos4x12 > > ---------------------------------------------------------------- > Amit Daniel Kachhap (2): > ARM: EXYNOS: enable ARCH_HAS_BANDGAP > ARM: EXYNOS: Skip C1 cpuidle state for exynos5440 The patch "ARM: EXYNOS: Skip C1 cpuidle state for exynos5440": is incorrect as noted a month ago in: http://lists.infradead.org/pipermail/linux-arm-kernel/2013-July/186355.html [ Because of the deficiency in the core cpuidle core (device->state_count not being used by governors' code) only sysfs entries for C1 state will be disabled and EXYNOS cpuidle driver will still attempt to use C1 state. also non-working device->state_count is planned to be removed by: http://permalink.gmane.org/gmane.linux.power-management.general/37390 To disable C1 state on EXYNOS5440 something like: static int __init exynos4_init_cpuidle(void) { ... if (soc_is_exynos5440()) exynos4_idle_driver.state_count = 1; ... } should be done instead. Best regards, --- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -210,7 +210,7 @@ static int __init exynos4_init_cpuidle(void) device->cpu = cpu_id; /* Support IDLE only */ - if (cpu_id != 0) + if (soc_is_exynos5440() || cpu_id != 0) device->state_count = 1; ret = cpuidle_register_device(device);